From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/skl: Use proper plane dimensions for DDB and WM calculations Date: Tue, 12 Jan 2016 14:07:33 +0200 Message-ID: <20160112120733.GR23290@intel.com> References: <1450711877-18753-1-git-send-email-matthew.d.roper@intel.com> <20160111193103.GN23290@intel.com> <20160111221306.GO21100@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id AD51289B8F for ; Tue, 12 Jan 2016 04:07:38 -0800 (PST) Content-Disposition: inline In-Reply-To: <20160111221306.GO21100@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: "Kondapally, Kalyan" , intel-gfx@lists.freedesktop.org, Ville =?iso-8859-1?Q?Syrj=E4l=E4?= List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKYW4gMTEsIDIwMTYgYXQgMDI6MTM6MDZQTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBPbiBNb24sIEphbiAxMSwgMjAxNiBhdCAwOTozMTowM1BNICswMjAwLCBWaWxsZSBTeXJq w6Rsw6Qgd3JvdGU6Cj4gPiBPbiBNb24sIERlYyAyMSwgMjAxNSBhdCAwNzozMToxN0FNIC0wODAw LCBNYXR0IFJvcGVyIHdyb3RlOgo+ID4gPiBJbiBjb21taXQKPiA+ID4gCj4gPiA+ICAgICAgICAg Y29tbWl0IDAyNGM5MDQ1MjIxZmU0NTQ4Mjg2M2M0N2M0YjRjNDdkMzdmOTdjYmYKPiA+ID4gICAg ICAgICBBdXRob3I6IE1hdHQgUm9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gPiA+ ICAgICAgICAgRGF0ZTogICBUaHUgU2VwIDI0IDE1OjUzOjExIDIwMTUgLTA3MDAKPiA+ID4gCj4g PiA+ICAgICAgICAgICAgIGRybS9pOTE1L3NrbDogRWxpbWluYXRlIHVzYWdlIG9mIHBpcGVfd21f cGFyYW1ldGVycyBmcm9tIFNLTC1zdHlsZSBXTSAodjQpCj4gPiA+IAo+ID4gPiBJIGZ1bWJsZWQg d2hpbGUgY29udmVydGluZyB0aGUgZGltZW5zaW9ucyBzdG9yZWQgaW4gdGhlIHBsYW5lX3BhcmFt ZXRlcnMKPiA+ID4gc3RydWN0dXJlIHRvIHRoZSB2YWx1ZXMgc3RvcmVkIGluIHBsYW5lIHN0YXRl IGFuZCBhY2NpZGVudGFsbHkgcmVwbGFjZWQKPiA+ID4gdGhlIHBsYW5lIGRpbWVuc2lvbnMgd2l0 aCB0aGUgcGlwZSBkaW1lbnNpb25zIGluIGJvdGggdGhlIEREQiBhbGxvY2F0aW9uCj4gPiA+IGZ1 bmN0aW9uIGFuZCB0aGUgV00gY2FsY3VsYXRpb24gZnVuY3Rpb24uICBPbiB0aGUgRERCIHNpZGUg dGhpcyBpcwo+ID4gPiBoYXJtbGVzcyBzaW5jZSB3ZSBlZmZlY3RpdmVseSB0cmVhdCBhbGwgb2Yg b3VyIG5vbi1jdXJzb3IgcGxhbmVzIGFzCj4gPiA+IGZ1bGwtc2NyZWVuIHdoaWNoIG1heSBub3Qg YmUgb3B0aW1hbCwgYnV0IGdlbmVyYWxseSB3b24ndCBjYXVzZSBhbnkKPiA+ID4gcHJvYmxlbXMg ZWl0aGVyIChhbmQgaW4gOTklIG9mIHRoZSBjYXNlcyB3aGVyZSB0aGVyZSdzIG5vIHNwcml0ZSBw bGFuZQo+ID4gPiB1c2FnZSBvciBwcmltYXJ5IHBsYW5lIHdpbmRvd2luZywgdGhlcmUncyBubyBl ZmZlY3QgYXQgYWxsKS4gIE9uIHRoZSBXTQo+ID4gPiBjYWxjdWxhdGlvbiBzaWRlIHRoZXJlJ3Mg bW9yZSBwb3RlbnRpYWwgZm9yIHRoaXMgZnVtYmxlIHRvIGNhdXNlIGFjdHVhbAo+ID4gPiBwcm9i bGVtcyBzaW5jZSBjdXJzb3JzIGFsc28gZ2V0IG1pc2NhbGN1bGF0ZWQuCj4gPiA+IAo+ID4gPiBD YzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGludGVsLmNvbT4KPiA+ID4gQ2M6ICJL b25kYXBhbGx5LCBLYWx5YW4iIDxrYWx5YW4ua29uZGFwYWxseUBpbnRlbC5jb20+Cj4gPiA+IENj OiBSYWRoYWtyaXNobmEgU3JpcGFkYSA8cmFkaGFrcmlzaG5hLnNyaXBhZGFAaW50ZWwuY29tPgo+ ID4gPiBTaWduZWQtb2ZmLWJ5OiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29t Pgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCAyNCAr KysrKysrKysrKysrLS0tLS0tLS0tLS0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxMyBpbnNlcnRp b25zKCspLCAxMSBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0u Ywo+ID4gPiBpbmRleCA4ZDBkNmY1Li5mNGQ0Y2M3IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3BtLmMKPiA+ID4gQEAgLTI4NDUsMjUgKzI4NDUsMjIgQEAgc2tsX3BsYW5lX3JlbGF0 aXZlX2RhdGFfcmF0ZShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3N0YXRlLAo+ID4g PiAgCQkJICAgICBjb25zdCBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpwc3RhdGUsCj4gPiA+ICAJ CQkgICAgIGludCB5KQo+ID4gPiAgewo+ID4gPiAtCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9j cnRjID0gdG9faW50ZWxfY3J0Yyhjc3RhdGUtPmJhc2UuY3J0Yyk7Cj4gPiA+ICsJc3RydWN0IGlu dGVsX3BsYW5lX3N0YXRlICppbnRlbF9wc3RhdGUgPSB0b19pbnRlbF9wbGFuZV9zdGF0ZShwc3Rh dGUpOwo+ID4gPiAgCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0gcHN0YXRlLT5mYjsKPiA+ ID4gKwl1bnNpZ25lZCB3ID0gZHJtX3JlY3Rfd2lkdGgoJmludGVsX3BzdGF0ZS0+ZHN0KTsKPiA+ ID4gKwl1bnNpZ25lZCBoID0gZHJtX3JlY3RfaGVpZ2h0KCZpbnRlbF9wc3RhdGUtPmRzdCk7Cj4g PiAKPiA+IEkgdGhpbmsgeW91J3JlIHN1cHBvc2VkIHRvIHVzZSB0aGUgc3JjIGRpbWVuc2lvbnMg aW4gbW9zdCBwbGFjZXMuCj4gCj4gSG1tLCBqdXN0IHdlbnQgYmFjayB0byBkb3VibGUgY2hlY2sg dGhlIGJwc2VjIGFuZCBpZiBJJ20gaW50ZXJwcmV0aW5nIGl0Cj4gY29ycmVjdGx5LCBpdCBsb29r cyBsaWtlIHdlIGFjdHVhbGx5IG5lZWQgdG8gdXNlIHRoZSBsYXJnZXIgb2YgdGhlIHR3bzoKPiAi RG93biBzY2FsaW5nIGVmZmVjdGl2ZWx5IGluY3JlYXNlcyB0aGUgcGl4ZWwgcmF0ZS4gVXAgc2Nh bGluZyBkb2VzIG5vdAo+IHJlZHVjZSB0aGUgcGl4ZWwgcmF0ZS4iCgpUaGUgcGl4ZWwgcmF0ZSBp cyAiZG93bnNjYWxlIGZhY3RvciAqIHBpeGVsIGNsb2NrIgoKPiAKPiBUaGFua3MgZm9yIHBvaW50 aW5nIHRoYXQgb3V0OyBJJ2xsIHNlbmQgYW4gdXBkYXRlZCBwYXRjaC4KPiAKPiAKPiAKPiBNYXR0 Cj4gCj4gPiAKPiA+ID4gIAo+ID4gPiAgCS8qIGZvciBwbGFuYXIgZm9ybWF0ICovCj4gPiA+ICAJ aWYgKGZiLT5waXhlbF9mb3JtYXQgPT0gRFJNX0ZPUk1BVF9OVjEyKSB7Cj4gPiA+ICAJCWlmICh5 KSAgLyogeS1wbGFuZSBkYXRhIHJhdGUgKi8KPiA+ID4gLQkJCXJldHVybiBpbnRlbF9jcnRjLT5j b25maWctPnBpcGVfc3JjX3cgKgo+ID4gPiAtCQkJCWludGVsX2NydGMtPmNvbmZpZy0+cGlwZV9z cmNfaCAqCj4gPiA+IC0JCQkJZHJtX2Zvcm1hdF9wbGFuZV9jcHAoZmItPnBpeGVsX2Zvcm1hdCwg MCk7Cj4gPiA+ICsJCQlyZXR1cm4gdyAqIGggKiBkcm1fZm9ybWF0X3BsYW5lX2NwcChmYi0+cGl4 ZWxfZm9ybWF0LCAwKTsKPiA+ID4gIAkJZWxzZSAgICAvKiB1di1wbGFuZSBkYXRhIHJhdGUgKi8K PiA+ID4gLQkJCXJldHVybiAoaW50ZWxfY3J0Yy0+Y29uZmlnLT5waXBlX3NyY193LzIpICoKPiA+ ID4gLQkJCQkoaW50ZWxfY3J0Yy0+Y29uZmlnLT5waXBlX3NyY19oLzIpICoKPiA+ID4gKwkJCXJl dHVybiAody8yKSAqIChoLzIpICoKPiA+ID4gIAkJCQlkcm1fZm9ybWF0X3BsYW5lX2NwcChmYi0+ cGl4ZWxfZm9ybWF0LCAxKTsKPiA+ID4gIAl9Cj4gPiA+ICAKPiA+ID4gIAkvKiBmb3IgcGFja2Vk IGZvcm1hdHMgKi8KPiA+ID4gLQlyZXR1cm4gaW50ZWxfY3J0Yy0+Y29uZmlnLT5waXBlX3NyY193 ICoKPiA+ID4gLQkJaW50ZWxfY3J0Yy0+Y29uZmlnLT5waXBlX3NyY19oICoKPiA+ID4gLQkJZHJt X2Zvcm1hdF9wbGFuZV9jcHAoZmItPnBpeGVsX2Zvcm1hdCwgMCk7Cj4gPiA+ICsJcmV0dXJuIHcg KiBoICogZHJtX2Zvcm1hdF9wbGFuZV9jcHAoZmItPnBpeGVsX2Zvcm1hdCwgMCk7Cj4gPiA+ICB9 Cj4gPiA+ICAKPiA+ID4gIC8qCj4gPiA+IEBAIC0yOTYwLDYgKzI5NTcsOCBAQCBza2xfYWxsb2Nh dGVfcGlwZV9kZGIoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNzdGF0ZSwKPiA+ID4gIAkgKiBG SVhNRTogd2UgbWF5IG5vdCBhbGxvY2F0ZSBldmVyeSBzaW5nbGUgYmxvY2sgaGVyZS4KPiA+ID4g IAkgKi8KPiA+ID4gIAl0b3RhbF9kYXRhX3JhdGUgPSBza2xfZ2V0X3RvdGFsX3JlbGF0aXZlX2Rh dGFfcmF0ZShjc3RhdGUpOwo+ID4gPiArCWlmICghdG90YWxfZGF0YV9yYXRlKQo+ID4gPiArCQly ZXR1cm47Cj4gPiA+ICAKPiA+ID4gIAlzdGFydCA9IGFsbG9jLT5zdGFydDsKPiA+ID4gIAlmb3Jf ZWFjaF9pbnRlbF9wbGFuZV9vbl9jcnRjKGRldiwgaW50ZWxfY3J0YywgaW50ZWxfcGxhbmUpIHsK PiA+ID4gQEAgLTMwOTMsMTIgKzMwOTIsMTUgQEAgc3RhdGljIGJvb2wgc2tsX2NvbXB1dGVfcGxh bmVfd20oY29uc3Qgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gPiAgewo+ ID4gPiAgCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lID0gJmludGVsX3BsYW5lLT5iYXNlOwo+ID4g PiAgCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0gcGxhbmUtPnN0YXRlLT5mYjsKPiA+ID4g KwlzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKmludGVsX3BzdGF0ZSA9Cj4gPiA+ICsJCXRvX2lu dGVsX3BsYW5lX3N0YXRlKHBsYW5lLT5zdGF0ZSk7Cj4gPiA+ICAJdWludDMyX3QgbGF0ZW5jeSA9 IGRldl9wcml2LT53bS5za2xfbGF0ZW5jeVtsZXZlbF07Cj4gPiA+ICAJdWludDMyX3QgbWV0aG9k MSwgbWV0aG9kMjsKPiA+ID4gIAl1aW50MzJfdCBwbGFuZV9ieXRlc19wZXJfbGluZSwgcGxhbmVf YmxvY2tzX3Blcl9saW5lOwo+ID4gPiAgCXVpbnQzMl90IHJlc19ibG9ja3MsIHJlc19saW5lczsK PiA+ID4gIAl1aW50MzJfdCBzZWxlY3RlZF9yZXN1bHQ7Cj4gPiA+ICAJdWludDhfdCBieXRlc19w ZXJfcGl4ZWw7Cj4gPiA+ICsJdW5zaWduZWQgdyA9IGRybV9yZWN0X3dpZHRoKCZpbnRlbF9wc3Rh dGUtPmRzdCk7Cj4gPiA+ICAKPiA+ID4gIAlpZiAobGF0ZW5jeSA9PSAwIHx8ICFjc3RhdGUtPmJh c2UuYWN0aXZlIHx8ICFmYikKPiA+ID4gIAkJcmV0dXJuIGZhbHNlOwo+ID4gPiBAQCAtMzEwOSwx MiArMzExMSwxMiBAQCBzdGF0aWMgYm9vbCBza2xfY29tcHV0ZV9wbGFuZV93bShjb25zdCBzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiA+ICAJCQkJIGxhdGVuY3kpOwo+ID4g PiAgCW1ldGhvZDIgPSBza2xfd21fbWV0aG9kMihza2xfcGlwZV9waXhlbF9yYXRlKGNzdGF0ZSks Cj4gPiA+ICAJCQkJIGNzdGF0ZS0+YmFzZS5hZGp1c3RlZF9tb2RlLmNydGNfaHRvdGFsLAo+ID4g PiAtCQkJCSBjc3RhdGUtPnBpcGVfc3JjX3csCj4gPiA+ICsJCQkJIHcsCj4gPiA+ICAJCQkJIGJ5 dGVzX3Blcl9waXhlbCwKPiA+ID4gIAkJCQkgZmItPm1vZGlmaWVyWzBdLAo+ID4gPiAgCQkJCSBs YXRlbmN5KTsKPiA+ID4gIAo+ID4gPiAtCXBsYW5lX2J5dGVzX3Blcl9saW5lID0gY3N0YXRlLT5w aXBlX3NyY193ICogYnl0ZXNfcGVyX3BpeGVsOwo+ID4gPiArCXBsYW5lX2J5dGVzX3Blcl9saW5l ID0gdyAqIGJ5dGVzX3Blcl9waXhlbDsKPiA+ID4gIAlwbGFuZV9ibG9ja3NfcGVyX2xpbmUgPSBE SVZfUk9VTkRfVVAocGxhbmVfYnl0ZXNfcGVyX2xpbmUsIDUxMik7Cj4gPiA+ICAKPiA+ID4gIAlp ZiAoZmItPm1vZGlmaWVyWzBdID09IEk5MTVfRk9STUFUX01PRF9ZX1RJTEVEIHx8Cj4gPiA+IC0t IAo+ID4gPiAyLjEuNAo+ID4gPiAKPiA+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KPiA+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gPiBJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiA+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPiA+IAo+ID4gLS0gCj4gPiBWaWxsZSBT eXJqw6Rsw6QKPiA+IEludGVsIE9UQwo+IAo+IC0tIAo+IE1hdHQgUm9wZXIKPiBHcmFwaGljcyBT b2Z0d2FyZSBFbmdpbmVlcgo+IElvVEcgUGxhdGZvcm0gRW5hYmxpbmcgJiBEZXZlbG9wbWVudAo+ IEludGVsIENvcnBvcmF0aW9uCj4gKDkxNikgMzU2LTI3OTUKCi0tIApWaWxsZSBTeXJqw6Rsw6QK SW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==