From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1761625AbcALMf4 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jan 2016 07:35:56 -0500
Received: from mail.skyhub.de ([78.46.96.112]:41988 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752032AbcALMfy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jan 2016 07:35:54 -0500
Date: Tue, 12 Jan 2016 13:35:40 +0100
From: Borislav Petkov <bp@alien8.de>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
        Michal Marek <mmarek@suse.cz>, Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andi Kleen <andi@firstfloor.org>, Pedro Alves <palves@redhat.com>,
        Namhyung Kim <namhyung@gmail.com>,
        Bernd Petrovitsch <bernd@petrovitsch.priv.at>,
        Chris J Arges <chris.j.arges@canonical.com>,
        Andrew Morton <akpm@linux-foundation.org>, Jiri Slaby <jslaby@suse.cz>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [PATCH v15 02/25] tools: Make list.h self-sufficient
Message-ID: <20160112123540.GA22699@pd.tnic>
References: <cover.1450442274.git.jpoimboe@redhat.com>
 <59cdc19c6589d1b5ef43d83b0e2d5a4a40301374.1450442274.git.jpoimboe@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <59cdc19c6589d1b5ef43d83b0e2d5a4a40301374.1450442274.git.jpoimboe@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 18, 2015 at 06:39:16AM -0600, Josh Poimboeuf wrote:
> Commit 7f5f873c6a07 added the use of the WRITE_ONCE macro to the kernel

nitpick: we like to do this commit quoting style:

  7f5f873c6a07 ("rculist: Use WRITE_ONCE() when deleting from reader-visible list")

Checkpatch catches that:

ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit 7f5f873c6a07 ("rculist: Use WRITE_ONCE() when deleting from reader-visible list")'
#21: 
Commit 7f5f873c6a07 added the use of the WRITE_ONCE macro to the kernel

> version of list.h, which broke the stacktool build because the tools
> list.h includes the kernel list.h.
> 
> Avoid this type of situation in the future and make list.h
> self-sufficient by copying the kernel list.h routines directly into
> tools list.h.
> 
> This is a straight copy except for adjustments to the include statements
> and copying of the tools-specific list routines (list_del_range and
> list_for_each_from).
> 
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> ---
>  tools/include/linux/list.h | 753 ++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 747 insertions(+), 6 deletions(-)

...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.