From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34597)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1aIwmA-00063q-Rq
	for qemu-devel@nongnu.org; Tue, 12 Jan 2016 06:06:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1aIwm7-0002i0-MP
	for qemu-devel@nongnu.org; Tue, 12 Jan 2016 06:06:10 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33667)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1aIwm7-0002gT-HZ
	for qemu-devel@nongnu.org; Tue, 12 Jan 2016 06:06:07 -0500
Date: Tue, 12 Jan 2016 13:06:02 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20160112130514-mutt-send-email-mst@redhat.com>
References: <1450803119-4223-1-git-send-email-mst@redhat.com>
	<1450803119-4223-15-git-send-email-mst@redhat.com>
	<568F7BE8.9060505@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <568F7BE8.9060505@redhat.com>
Subject: Re: [Qemu-devel] [PULL 14/55] ipmi: Add a local BMC simulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Xiao Guangrong <guangrong.xiao@linux.intel.com>, Corey Minyard <cminyard@mvista.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Shannon Zhao <zhaoshenglong@huawei.com>

On Fri, Jan 08, 2016 at 10:05:44AM +0100, Paolo Bonzini wrote:
> 
> 
> On 22/12/2015 17:53, Michael S. Tsirkin wrote:
> > +{
> > +    if ((netfn & 1) || (netfn > MAX_NETFNS) || (s->netfns[netfn / 2])) {
> 
> Off by one.  The check should be >=, not >.
> 
> Paolo

Corey, can you look into this please?

> > +        return -1;
> > +    }