From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v3 1/2] acpi: Fix proper return code for function acpi_gsi_to_irq Date: Tue, 12 Jan 2016 15:36:53 +0100 Message-ID: <20160112143653.GB30558@pd.tnic> References: <1446857519-5908-1-git-send-email-lho@apm.com> <1446857519-5908-2-git-send-email-lho@apm.com> <20160110110714.GA22896@pd.tnic> <20160111221305.GH4665@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail.skyhub.de ([78.46.96.112]:54300 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933622AbcALOhH (ORCPT ); Tue, 12 Jan 2016 09:37:07 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Tuan Phan Cc: Loc Ho , dougthompson@xmission.com, mchehab@osg.samsung.com, tomasz.nowicki@linaro.org, fu.wei@linaro.org, rjw@rjwysocki.net, lenb@kernel.org, linux-edac@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, Jon Masters , patches@apm.com, Thomas Gleixner On Mon, Jan 11, 2016 at 02:41:41PM -0800, Tuan Phan wrote: > It will be problem because irq number can be 0 on X86? tglx says not really but historically irq 0 has been the timer irq. How about returning a negative value on error and positive or 0 for an IRQ? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. From mboxrd@z Thu Jan 1 00:00:00 1970 From: bp@alien8.de (Borislav Petkov) Date: Tue, 12 Jan 2016 15:36:53 +0100 Subject: [PATCH v3 1/2] acpi: Fix proper return code for function acpi_gsi_to_irq In-Reply-To: References: <1446857519-5908-1-git-send-email-lho@apm.com> <1446857519-5908-2-git-send-email-lho@apm.com> <20160110110714.GA22896@pd.tnic> <20160111221305.GH4665@pd.tnic> Message-ID: <20160112143653.GB30558@pd.tnic> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jan 11, 2016 at 02:41:41PM -0800, Tuan Phan wrote: > It will be problem because irq number can be 0 on X86? tglx says not really but historically irq 0 has been the timer irq. How about returning a negative value on error and positive or 0 for an IRQ? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.