From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763830AbcALRum (ORCPT ); Tue, 12 Jan 2016 12:50:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50306 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763811AbcALRuj (ORCPT ); Tue, 12 Jan 2016 12:50:39 -0500 Date: Tue, 12 Jan 2016 11:50:31 -0600 From: Josh Poimboeuf To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Michal Marek , Peter Zijlstra , Andy Lutomirski , Linus Torvalds , Andi Kleen , Pedro Alves , Namhyung Kim , Bernd Petrovitsch , Chris J Arges , Andrew Morton , Jiri Slaby , Arnaldo Carvalho de Melo , David Vrabel , Konrad Rzeszutek Wilk , Boris Ostrovsky , Jeremy Fitzhardinge , Chris Wright , Alok Kataria , Rusty Russell , Herbert Xu , "David S. Miller" , Mathias Krause , Pavel Machek , "Rafael J. Wysocki" , Len Brown , Matt Fleming Subject: Re: [PATCH v15 00/25] Compile-time stack metadata validation Message-ID: <20160112175031.GE310@treble.redhat.com> References: <20160112171713.GF22699@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160112171713.GF22699@pd.tnic> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 12, 2016 at 06:17:13PM +0100, Borislav Petkov wrote: > On Fri, Dec 18, 2015 at 06:39:14AM -0600, Josh Poimboeuf wrote: > > This is v15 of the compile-time stack metadata validation patch set, > > along with proposed fixes for many of the warnings it found. It's based > > on the tip/master branch. > > Ok, > > Reviewed-by: Borislav Petkov Thanks a lot for your review! > With it applied, my .config gives ~1000 stacktool warnings. Hm, that's kind of shocking. Any chance you have CONFIG_GCOV_KERNEL enabled? I just discovered that it inserts a bunch of unreachable instructions which causes a lot of stacktool warnings. I need to look into that. Otherwise, if you don't have gcov enabled, can you share your .config? -- Josh