All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Janda <felix.janda@posteo.de>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/6] Move from __uint*_t types to uint*_t and likewise for __int*_t
Date: Tue, 12 Jan 2016 22:46:34 +0100	[thread overview]
Message-ID: <20160112214634.GC10558@nyan> (raw)
In-Reply-To: <20160112212405.GL10456@dastard>

Dave Chinner wrote:
> On Tue, Jan 12, 2016 at 08:59:35PM +0100, Felix Janda wrote:
> > The uint*_t and int*_t are defined by C99 and should be prefered
> > over the less portable __uint*_t and __int*_t variants. The
> > necessary <stdint.h> include is in platformdefs.h, which gets
> > included in most places via libxfs.h. In the public headers
> > <stdint.h> is included in <xfs/xfs_types.h>.
> > 
> > Signed-off-by: Felix Janda <felix.janda@posteo.de>
> 
> I can't apply this straight off. Most of the libxfs code that is
> changed is shared with the kernel code, and so the definitions of
> the variables need to be the same as the kernel code. There are
> reasons for the kernel code using __[u]int*_t type variants (e.g.  I
> think the endian conversion static checker requires the __ variants
> for host order variables), and so before making sweeping changes
> like this we need to ensure that we can make the equivalent changes
> to the kernel code as well...

Thanks for the review!

Sorry, I was not aware about this difference between the types.

The simplest fix for musl would be to add defines or something similar
to linux.h.

On the other hand, on the long run it would be preferable to use
the stdint types (consistently).

Felix

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2016-01-12 21:49 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1452627740.git.felix.janda@posteo.de>
2016-01-12 19:59 ` [PATCH 1/6] Move from __uint*_t types to uint*_t and likewise for __int*_t Felix Janda
2016-01-12 21:24   ` Dave Chinner
2016-01-12 21:46     ` Felix Janda [this message]
2016-01-12 22:02       ` Dave Chinner
2016-01-13  7:48     ` Christoph Hellwig
2016-01-20  0:46       ` Dave Chinner
2016-01-12 19:59 ` [PATCH 2/6] libxfs/linux.c: Replace use of ustat by stat Felix Janda
2016-01-12 21:24   ` Dave Chinner
2016-01-12 21:33     ` Felix Janda
2016-01-13  7:55   ` Christoph Hellwig
2016-01-13 17:42     ` Felix Janda
2016-01-14 10:20       ` Christoph Hellwig
2016-01-14 19:07         ` Felix Janda
2016-06-18 14:53         ` Felix Janda
2016-06-22 12:59           ` Christoph Hellwig
2016-09-04  1:23   ` Eric Sandeen
2016-09-08  0:00   ` Dave Chinner
2016-01-12 19:59 ` [PATCH 3/6] fsr/xfs_fsr.c: Include <paths.h> for _PATH_MOUNTED Felix Janda
2016-01-13  7:55   ` Christoph Hellwig
2016-01-12 20:00 ` [PATCH 4/6] linux.h: Use off64_t instead of loff_t Felix Janda
2016-01-13  7:55   ` Christoph Hellwig
2016-01-12 20:00 ` [PATCH 5/6] include/linux.h: Include <stdio.h> for fprintf and stderr Felix Janda
2016-01-13  7:55   ` Christoph Hellwig
2016-01-12 20:00 ` [PATCH 6/6] Add configure check for members of dirent for use in io/readdir.c Felix Janda
2016-01-12 21:30   ` Dave Chinner
2016-01-12 21:37     ` Felix Janda
2016-01-12 22:37       ` Dave Chinner
2016-01-13  7:58   ` Christoph Hellwig
2016-01-13 17:09     ` Felix Janda
2016-01-14 10:17       ` Christoph Hellwig
2016-01-14 19:06         ` Felix Janda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160112214634.GC10558@nyan \
    --to=felix.janda@posteo.de \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.