From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754058AbcANE5P (ORCPT ); Wed, 13 Jan 2016 23:57:15 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:41120 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753694AbcANE4p (ORCPT ); Wed, 13 Jan 2016 23:56:45 -0500 Date: Wed, 13 Jan 2016 23:56:43 -0500 (EST) Message-Id: <20160113.235643.1373342973936029804.davem@davemloft.net> To: haiyangz@microsoft.com Cc: vkuznets@redhat.com, netdev@vger.kernel.org, kys@microsoft.com, devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, eric.dumazet@gmail.com Subject: Re: [PATCH net-next] hv_netvsc: don't make assumptions on struct flow_keys layout From: David Miller In-Reply-To: References: <1452159189-11473-1-git-send-email-vkuznets@redhat.com> <20160110.172558.367101858392871618.davem@davemloft.net> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 Jan 2016 20:56:44 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haiyang Zhang Date: Wed, 13 Jan 2016 23:10:57 +0000 > I have done a comparison of the Toeplitz v.s. Jenkins Hash algorithms, > and found that the Toeplitz provides much better distribution of the > connections into send-indirection-table entries. This fails to take into consideration how massively more expensive Toeplitz is to compute. This also fails to show what the real life performance implications are. Just showing distributions is meaningless if it doesn't indicate what kind of performance distrubtion A or B achieves. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] hv_netvsc: don't make assumptions on struct flow_keys layout Date: Wed, 13 Jan 2016 23:56:43 -0500 (EST) Message-ID: <20160113.235643.1373342973936029804.davem@davemloft.net> References: <1452159189-11473-1-git-send-email-vkuznets@redhat.com> <20160110.172558.367101858392871618.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org To: haiyangz@microsoft.com Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: netdev.vger.kernel.org From: Haiyang Zhang Date: Wed, 13 Jan 2016 23:10:57 +0000 > I have done a comparison of the Toeplitz v.s. Jenkins Hash algorithms, > and found that the Toeplitz provides much better distribution of the > connections into send-indirection-table entries. This fails to take into consideration how massively more expensive Toeplitz is to compute. This also fails to show what the real life performance implications are. Just showing distributions is meaningless if it doesn't indicate what kind of performance distrubtion A or B achieves.