From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id A611F7F37 for ; Wed, 13 Jan 2016 01:49:03 -0600 (CST) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id 924A1304053 for ; Tue, 12 Jan 2016 23:49:03 -0800 (PST) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id A23bdTznK8am8iiU (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Tue, 12 Jan 2016 23:49:02 -0800 (PST) Date: Tue, 12 Jan 2016 23:48:59 -0800 From: Christoph Hellwig Subject: Re: [PATCH 1/6] Move from __uint*_t types to uint*_t and likewise for __int*_t Message-ID: <20160113074859.GB21939@infradead.org> References: <20160112195935.GB568@nyan> <20160112212405.GL10456@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160112212405.GL10456@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: Felix Janda , xfs@oss.sgi.com On Wed, Jan 13, 2016 at 08:24:06AM +1100, Dave Chinner wrote: > I can't apply this straight off. Most of the libxfs code that is > changed is shared with the kernel code, and so the definitions of > the variables need to be the same as the kernel code. There are > reasons for the kernel code using __[u]int*_t type variants (e.g. I > think the endian conversion static checker requires the __ variants > for host order variables), and so before making sweeping changes > like this we need to ensure that we can make the equivalent changes > to the kernel code as well... There is no functional requirement for these types. I'm not sure if they are an IRIXism, or something that was added during the early Linux port, but they certainly aren't nessecary. I'd love to kill them in favour or either the kernel __u/s types or the C99 types which are like the urrent ones just without the __ prefix. Maybe we should get an agreement which ones we want and ask Felix for a patch to the kernel tree? _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs