From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH v3] drm/i915: Do not call API requiring struct_mutex where it is not available Date: Wed, 13 Jan 2016 19:34:54 +0000 Message-ID: <20160113193453.GC29867@nuc-i3427.alporthouse.com> References: <56952011.9020205@intel.com> <1452701781-8721-1-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id BBB317A08D for ; Wed, 13 Jan 2016 11:34:58 -0800 (PST) Content-Disposition: inline In-Reply-To: <1452701781-8721-1-git-send-email-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Daniel Vetter , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKYW4gMTMsIDIwMTYgYXQgMDQ6MTY6MjFQTSArMDAwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K PiAKPiBMUkMgY29kZSB3YXMgY2FsbGluZyBHRU0gQVBJIGxpa2UgaTkxNV9nZW1fb2JqX2dndHRf b2Zmc2V0IGZyb20KPiBwbGFjZXMgd2hlcmUgdGhlIHN0cnVjdF9tdXRleCBjYW5ub3QgYmUgZ3Jh YmJlZCAoaXJxIGhhbmRsZXJzKS4KPiAKPiBUbyBhdm9pZCB0aGF0IHRoaXMgcGF0Y2ggY2FjaGVz IHNvbWUgaW50ZXJlc3RpbmcgYml0cyBhbmQgdmFsdWVzCj4gaW4gdGhlIGVuZ2luZSBhbmQgY29u dGV4dCBzdHJ1Y3R1cmVzLgo+IAo+IFNvbWUgdXNhZ2VzIGFyZSBhbHNvIHJlbW92ZWQgd2hlcmUg dGhleSBhcmUgbm90IG5lZWRlZCBsaWtlIGEKPiBmZXcgYXNzZXJ0cyB3aGljaCBhcmUgZWl0aGVy IGltcG9zc2libGUgb3IgaGF2ZSBiZWVuIGNoZWNrZWQKPiBhbHJlYWR5IGR1cmluZyBlbmdpbmUg aW5pdGlhbGl6YXRpb24uCj4gCj4gU2lkZSBiZW5lZml0IGlzIGFsc28gdGhhdCBpbnRlcnJ1cHQg aGFuZGxlcnMgYW5kIGNvbW1hbmQKPiBzdWJtaXNzaW9uIHN0b3AgZXZhbHVhdGluZyBpbnZhcmlh bnQgY29uZGl0aW9uYWxzLCBsaWtlIHdoYXQKPiBHZW4gd2UgYXJlIHJ1bm5pbmcgb24sIG9uIGV2 ZXJ5IGludGVycnVwdCBhbmQgZXZlcnkgY29tbWFuZAo+IHN1Ym1pdHRlZC4KPiAKPiBUaGlzIHBh dGNoIGRlYWxzIHdpdGggbG9naWNhbCByaW5nIGNvbnRleHQgaWQgYW5kIGRlc2NyaXB0b3JzCj4g d2hpbGUgc3Vic2VxdWVudCBwYXRjaGVzIHdpbGwgZGVhbCB3aXRoIHRoZSByZW1haW5pbmcgaXNz dWVzLgo+IAo+IHYyOgo+ICAqIENhY2hlIHRoZSBWTUEgaW5zdGVhZCBvZiB0aGUgYWRkcmVzcy4g KENocmlzIFdpbHNvbikKPiAgKiBJbmNvcnBvcmF0ZSBEYXZlIEdvcmRvbidzIGdvb2QgY29tbWVu dHMgYW5kIGZ1bmN0aW9uIG5hbWUuCj4gCj4gdjM6Cj4gICogRXh0cmFjdCBjdHggZGVzY3JpcHRv ciB0ZW1wbGF0ZSB0byBhIGZ1bmN0aW9uIGFuZCBncm91cAo+ICAgIGZ1bmN0aW9ucyBkZWFsaW5n IHdpdGggY3R4IGRlc2NyaXB0b3IgJiBjbyB0b2dldGhlciBuZWFyCj4gICAgdG9wIG9mIHRoZSBm aWxlLiAoRGF2ZSBHb3Jkb24pCj4gCj4gU2lnbmVkLW9mZi1ieTogVHZydGtvIFVyc3VsaW4gPHR2 cnRrby51cnN1bGluQGludGVsLmNvbT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRl ckBmZndsbC5jaD4KPiBDYzogRGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVsLmNvbT4K CkNvbnNpZGVyaW5nIHRoZSBjdXJyZW50IHN0YXRlIG9mIGFmZmFpcnMsIHRoaXMgaXMgbm90IGJh ZC4gSSBoYXZlIGEKZGlmZmVyZW50IHNoYWRlIG9mIHNsaWdodGx5LW9mZi13aGl0ZSB0aGF0IEkg bGlrZSBidXQgdGhhdCBhcHBsaWVzIHRvIGEKd29ybGQgd2hlcmUgZXhlY2xpc3RzIGlzIG1vcmUg cmVxdWVzdCBmb2N1c2VkLCBlLmcuOgoKc3RhdGljIHUzMiBleGVjbGlzdHNfcmVxdWVzdF93cml0 ZV90YWlsKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxKQp7CiAgICAgICAgc3RydWN0 IGludGVsX3JpbmcgKnJpbmcgPSByZXEtPnJpbmc7CiAgICAgICAgc3RydWN0IGk5MTVfaHdfcHBn dHQgKnBwZ3R0ID0gcmVxLT5jdHgtPnBwZ3R0OwoKICAgICAgICBpZiAocHBndHQgJiYgIVVTRVNf RlVMTF80OEJJVF9QUEdUVChyZXEtPmk5MTUpKSB7CiAgICAgICAgICAgICAgICAvKiBUcnVlIDMy YiBQUEdUVCB3aXRoIGR5bmFtaWMgcGFnZSBhbGxvY2F0aW9uOiB1cGRhdGUgUERQCiAgICAgICAg ICAgICAgICAgKiByZWdpc3RlcnMgYW5kIHBvaW50IHRoZSB1bmFsbG9jYXRlZCBQRFBzIHRvIHNj cmF0Y2ggcGFnZS4KICAgICAgICAgICAgICAgICAqIFBNTDQgaXMgYWxsb2NhdGVkIGR1cmluZyBw cGd0dCBpbml0LCBzbyB0aGlzIGlzIG5vdCBuZWVkZWQKICAgICAgICAgICAgICAgICAqIGluIDQ4 LWJpdCBtb2RlLgogICAgICAgICAgICAgICAgICovCiAgICAgICAgICAgICAgICBpZiAocHBndHQt PnBkX2RpcnR5X3JpbmdzICYgaW50ZWxfZW5naW5lX2ZsYWcocmVxLT5lbmdpbmUpKSB7CiAgICAg ICAgICAgICAgICAgICAgICAgIEFTU0lHTl9DVFhfUERQKHBwZ3R0LCByaW5nLT5yZWdpc3RlcnMs IDMpOwogICAgICAgICAgICAgICAgICAgICAgICBBU1NJR05fQ1RYX1BEUChwcGd0dCwgcmluZy0+ cmVnaXN0ZXJzLCAyKTsKICAgICAgICAgICAgICAgICAgICAgICAgQVNTSUdOX0NUWF9QRFAocHBn dHQsIHJpbmctPnJlZ2lzdGVycywgMSk7CiAgICAgICAgICAgICAgICAgICAgICAgIEFTU0lHTl9D VFhfUERQKHBwZ3R0LCByaW5nLT5yZWdpc3RlcnMsIDApOwogICAgICAgICAgICAgICAgICAgICAg ICBwcGd0dC0+cGRfZGlydHlfcmluZ3MgJj0gfmludGVsX2VuZ2luZV9mbGFnKHJlcS0+ZW5naW5l KTsKICAgICAgICAgICAgICAgIH0KICAgICAgICB9CgogICAgICAgIHJpbmctPnJlZ2lzdGVyc1tD VFhfUklOR19UQUlMKzFdID0gcmVxLT50YWlsOwogICAgICAgIHJldHVybiByaW5nLT5jb250ZXh0 X2Rlc2NyaXB0b3I7Cn0KCndoZXJlIHRoZSByZXEtPnJpbmcgaXMgbXVjaCBtb3JlIHJlYWRpbHkg YXZhaWxhYmxlIHRoYW4KCXN0cnVjdCBpbnRlbF9jb250ZXh0X2VuZ2luZSAqY2UgPSAmcmVxLT5j dHgtPmVuZ2luZVtyZXEtPmVuZ2luZS0+aWRdOwp0aG91Z2ggYSByZXEtPmNvbnRleHRfZW5naW5l IHdvdWxkIHNodXQgbWUgdXAgZW50aXJlbHkuIAoKCj4gKy8qKgo+ICsgKiBpbnRlbF9leGVjbGlz dHNfY3R4X2lkKCkgLSBnZXQgdGhlIEV4ZWNsaXN0cyBDb250ZXh0IElECj4gKyAqIEBjdHg6IENv bnRleHQgdG8gZ2V0IHRoZSBJRCBmb3IKPiArICogQHJpbmc6IEVuZ2luZSB0byBnZXQgdGhlIElE IGZvcgo+ICsgKgo+ICsgKiBEbyBub3QgY29uZnVzZSB3aXRoIGN0eC0+aWQhIFVuZm9ydHVuYXRl bHkgd2UgaGF2ZSBhIG5hbWUgb3ZlcmxvYWQKPiArICogaGVyZTogdGhlIG9sZCBjb250ZXh0IElE IHdlIHBhc3MgdG8gdXNlcnNwYWNlIGFzIGEgaGFuZGxlciBzbyB0aGF0Cj4gKyAqIHRoZXkgY2Fu IHJlZmVyIHRvIGEgY29udGV4dCwgYW5kIHRoZSBuZXcgY29udGV4dCBJRCB3ZSBwYXNzIHRvIHRo ZQo+ICsgKiBFTFNQIHNvIHRoYXQgdGhlIEdQVSBjYW4gaW5mb3JtIHVzIG9mIHRoZSBjb250ZXh0 IHN0YXR1cyB2aWEKPiArICogaW50ZXJydXB0cy4KPiArICoKPiArICogVGhlIGNvbnRleHQgSUQg aXMgYSBwb3J0aW9uIG9mIHRoZSBjb250ZXh0IGRlc2NyaXB0b3IsIHNvIHdlIGNhbgo+ICsgKiBq dXN0IGV4dHJhY3QgdGhlIHJlcXVpcmVkIHBhcnQgZnJvbSB0aGUgY2FjaGVkIGRlc2NyaXB0b3Iu Cj4gKyAqCj4gKyAqIFJldHVybjogMjAtYml0cyBnbG9iYWxseSB1bmlxdWUgY29udGV4dCBJRC4K PiArICovCj4gK3UzMiBpbnRlbF9leGVjbGlzdHNfY3R4X2lkKHN0cnVjdCBpbnRlbF9jb250ZXh0 ICpjdHgsCj4gKwkJCSAgIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcpCgpJIHdvdWxkIHN1 Z2dlc3QgaW50ZWxfZXhlY2xpc3RzX3N0YXR1c190YWcgKG9yIGF0IGxlYXN0IG9mZmVyIGl0IGFz IGEKc3RhcnRpbmcgcG9pbnQgZm9yIGEgbm9uLWNvbmZsaWN0aW5nIG5hbWUpLgoKPiArewo+ICsJ cmV0dXJuIGludGVsX2xyX2NvbnRleHRfZGVzY3JpcHRvcihjdHgsIHJpbmcpID4+IEdFTjhfQ1RY X0lEX1NISUZUOwo+ICB9CgpOZXh0IHVwIG9uIHRoZSBoaXQgbGlzdCBpcyBzdHJ1Y3QgaW50ZWxf Y29udGV4dF9lbmdpbmUhCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9yaW5nYnVmZmVyLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgK PiBpbmRleCA3MzQ5ZDkyNTgxOTEuLjg1Y2UyMjcyZjkyYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiBAQCAtMjY5LDYgKzI2OSw4IEBAIHN0cnVjdCAgaW50 ZWxfZW5naW5lX2NzIHsKPiAgCXN0cnVjdCBsaXN0X2hlYWQgZXhlY2xpc3RfcXVldWU7Cj4gIAlz dHJ1Y3QgbGlzdF9oZWFkIGV4ZWNsaXN0X3JldGlyZWRfcmVxX2xpc3Q7Cj4gIAl1OCBuZXh0X2Nv bnRleHRfc3RhdHVzX2J1ZmZlcjsKPiArCWJvb2wgZGlzYWJsZV9saXRlX3Jlc3RvcmVfd2E7CgpU aGUgaG9sZXMsIHRoZSBob2xlcyEKCj4gKwl1MzIgY3R4X2Rlc2NfdGVtcGxhdGU7CgpJIHdvdWxk IHN1Z2dlc3QgdGhpcyBpcyBiZXR0ZXIgbmFtZWQgc29tZXRoaW5nIGxpa2UKZXhlY2xpc3RfY29u dGV4dF9iYXNlX2Rlc2NyaXB0b3Igc2luY2Ugd2UgYWxyZWFkeSBoYXZlIGJlZW4gdXNpbmcgdGhl CmV4ZWNsaXN0XyBwcmVmaXggdG8gZGlzdGluZ3Vpc2ggbHJjIHNwZWNpZmljIHN0YXRlLCBhbmQg YmVpbmcgdmVyYm9zZQpkb2Vzbid0IHJlYWxseSBodXJ0IHdoZW4gd2Ugb25seSB1c2UgaXQgdHdp Y2UuCgpSZXZpZXdlZC1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+ Ci1DaHJpcwoKLS0gCkNocmlzIFdpbHNvbiwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBD ZW50cmUKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK