From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755035AbcANWG2 (ORCPT ); Thu, 14 Jan 2016 17:06:28 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:50629 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750894AbcANWG1 (ORCPT ); Thu, 14 Jan 2016 17:06:27 -0500 Date: Thu, 14 Jan 2016 17:06:25 -0500 (EST) Message-Id: <20160114.170625.332893838261533719.davem@davemloft.net> To: tom@herbertland.com Cc: haiyangz@microsoft.com, eric.dumazet@gmail.com, gnomes@lxorguk.ukuu.org.uk, vkuznets@redhat.com, netdev@vger.kernel.org, kys@microsoft.com, devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] hv_netvsc: don't make assumptions on struct flow_keys layout From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 14 Jan 2016 14:06:26 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Herbert Date: Thu, 14 Jan 2016 13:44:24 -0800 > The fact that we can negatively affect the output of Toeplitz so > predictably is actually a liability and not a benefit. This sort of > thing can be the basis of a DOS attack and is why we kicked out XOR > hash in favor of Jenkins. +1 Toeplitz should not be used for any software calculated flow hash whatsoever.