On 12 Jan 2016 09:45, Jiri Slaby wrote: > On 01/11/2016, 02:14 AM, Mike Frysinger wrote: > > Commit 9d99a8dda154 ("nvme: move hardware structures out of the uapi > > version of nvme.h") renamed nvme.h to nvme_ioctl.h, but the uapi list > > still refers to nvme.h. People trying to install the headers hit a > > failure as the header no longer exists. > > Wouldn't reverting the rename be nicer to userspace? So that the > filename is preserved and anybody who #included nvme.h still can do so? i have no opinion on either route on a related note, shouldn't headers install be part of the automatic kernel checks that are run against repos on kernel.org ? who runs that thing ? -mike