From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752237AbcANH5d (ORCPT ); Thu, 14 Jan 2016 02:57:33 -0500 Received: from e06smtp08.uk.ibm.com ([195.75.94.104]:51869 "EHLO e06smtp08.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751831AbcANH5a (ORCPT ); Thu, 14 Jan 2016 02:57:30 -0500 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: heiko.carstens@de.ibm.com X-IBM-RcptTo: linux-alpha@vger.kernel.org;linux-ia64@vger.kernel.org;linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org Date: Thu, 14 Jan 2016 08:57:20 +0100 From: Heiko Carstens To: Ard Biesheuvel Cc: Andrew Morton , linux-alpha@vger.kernel.org, "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-ia64@vger.kernel.org" , linux-s390@vger.kernel.org, "x86@kernel.org" , "hpa@zytor.com" , "mingo@redhat.com" , schwidefsky@de.ibm.com, Matt Turner , ink@jurassic.park.msu.ru, Richard Henderson , Tony Luck , "Yu, Fenghua" , Catalin Marinas , Will Deacon , Arnd Bergmann , Helge Deller , Mark Rutland Subject: Re: [PATCH v2 0/6] generic relative extable support Message-ID: <20160114075720.GB4073@osiris> References: <1452007180-27411-1-git-send-email-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16011407-0033-0000-0000-000005632170 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2016 at 02:59:46PM +0100, Ard Biesheuvel wrote: > On 5 January 2016 at 16:19, Ard Biesheuvel wrote: > > There are currently four architectures (x86, ia64, alpha and s390) whose > > user-access exception tables are relative to the table entry address rather > > than absolute. Each of these architectures has its own search_extable() and > > sort_extable() implementation, which are not only mostly identical to each > > other, but also deviate very little from the generic absolute implementations > > in lib/extable.c that they override. > > > > So before making arm64 the fifth architecture that reimplements this, let's > > refactor the existing code so that all of these architectures use common code > > for searching and sorting the relative extables. Archs may set > > ARCH_HAS_RELATIVE_EXTABLE to indicate that the table consists of a pair of > > relative ints, and may define swap_ex_entry_fixup() if the fixup member needs > > special treatment in the swapping step of the sorting routine (such as alpha). > > > > [...] > > Now that I have collected acks for all the patches, I think this is > good to go in. > > @Andrew: since this touches 5 different architectures, is this perhaps > something that could go in via your tree after -rc1? > (assuming that the s390 bugfix has been merged by then) Your s390 bugfix has been merged. See git commit id bcb7825a77f4 ("s390: fix normalization bug in exception table sorting"). Thanks, Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko.carstens@de.ibm.com (Heiko Carstens) Date: Thu, 14 Jan 2016 08:57:20 +0100 Subject: [PATCH v2 0/6] generic relative extable support In-Reply-To: References: <1452007180-27411-1-git-send-email-ard.biesheuvel@linaro.org> Message-ID: <20160114075720.GB4073@osiris> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jan 11, 2016 at 02:59:46PM +0100, Ard Biesheuvel wrote: > On 5 January 2016 at 16:19, Ard Biesheuvel wrote: > > There are currently four architectures (x86, ia64, alpha and s390) whose > > user-access exception tables are relative to the table entry address rather > > than absolute. Each of these architectures has its own search_extable() and > > sort_extable() implementation, which are not only mostly identical to each > > other, but also deviate very little from the generic absolute implementations > > in lib/extable.c that they override. > > > > So before making arm64 the fifth architecture that reimplements this, let's > > refactor the existing code so that all of these architectures use common code > > for searching and sorting the relative extables. Archs may set > > ARCH_HAS_RELATIVE_EXTABLE to indicate that the table consists of a pair of > > relative ints, and may define swap_ex_entry_fixup() if the fixup member needs > > special treatment in the swapping step of the sorting routine (such as alpha). > > > > [...] > > Now that I have collected acks for all the patches, I think this is > good to go in. > > @Andrew: since this touches 5 different architectures, is this perhaps > something that could go in via your tree after -rc1? > (assuming that the s390 bugfix has been merged by then) Your s390 bugfix has been merged. See git commit id bcb7825a77f4 ("s390: fix normalization bug in exception table sorting"). Thanks, Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Carstens Date: Thu, 14 Jan 2016 07:57:20 +0000 Subject: Re: [PATCH v2 0/6] generic relative extable support Message-Id: <20160114075720.GB4073@osiris> List-Id: References: <1452007180-27411-1-git-send-email-ard.biesheuvel@linaro.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ard Biesheuvel Cc: Andrew Morton , linux-alpha@vger.kernel.org, "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-ia64@vger.kernel.org" , linux-s390@vger.kernel.org, "x86@kernel.org" , "hpa@zytor.com" , "mingo@redhat.com" , schwidefsky@de.ibm.com, Matt Turner , ink@jurassic.park.msu.ru, Richard Henderson , Tony Luck , "Yu, Fenghua" , Catalin Marinas , Will Deacon , Arnd Bergmann , Helge Deller , Mark Rutland On Mon, Jan 11, 2016 at 02:59:46PM +0100, Ard Biesheuvel wrote: > On 5 January 2016 at 16:19, Ard Biesheuvel wrote: > > There are currently four architectures (x86, ia64, alpha and s390) whose > > user-access exception tables are relative to the table entry address rather > > than absolute. Each of these architectures has its own search_extable() and > > sort_extable() implementation, which are not only mostly identical to each > > other, but also deviate very little from the generic absolute implementations > > in lib/extable.c that they override. > > > > So before making arm64 the fifth architecture that reimplements this, let's > > refactor the existing code so that all of these architectures use common code > > for searching and sorting the relative extables. Archs may set > > ARCH_HAS_RELATIVE_EXTABLE to indicate that the table consists of a pair of > > relative ints, and may define swap_ex_entry_fixup() if the fixup member needs > > special treatment in the swapping step of the sorting routine (such as alpha). > > > > [...] > > Now that I have collected acks for all the patches, I think this is > good to go in. > > @Andrew: since this touches 5 different architectures, is this perhaps > something that could go in via your tree after -rc1? > (assuming that the s390 bugfix has been merged by then) Your s390 bugfix has been merged. See git commit id bcb7825a77f4 ("s390: fix normalization bug in exception table sorting"). Thanks, Heiko