From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1161069AbcANTOE (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 Jan 2016 14:14:04 -0500
Received: from bombadil.infradead.org ([198.137.202.9]:52435 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753776AbcANTOD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 Jan 2016 14:14:03 -0500
Date: Thu, 14 Jan 2016 20:13:55 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Luca Abeni <luca.abeni@unitn.it>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Juri Lelli <juri.lelli@arm.com>
Subject: Re: [RFC 1/8] Track the active utilisation
Message-ID: <20160114191355.GB6357@twins.programming.kicks-ass.net>
References: <1452785094-3086-1-git-send-email-luca.abeni@unitn.it>
 <1452785094-3086-2-git-send-email-luca.abeni@unitn.it>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1452785094-3086-2-git-send-email-luca.abeni@unitn.it>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 14, 2016 at 04:24:46PM +0100, Luca Abeni wrote:
> +static void add_running_bw(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
> +static void clear_running_bw(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)

I would prefer {add,sub}, I read clear as =0.