From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Decouple execbuf uAPI from internal implementation Date: Thu, 14 Jan 2016 22:09:16 +0000 Message-ID: <20160114220916.GA15852@nuc-i3427.alporthouse.com> References: <1452783779-2364-1-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id 347696E06E for ; Thu, 14 Jan 2016 14:09:27 -0800 (PST) Content-Disposition: inline In-Reply-To: <1452783779-2364-1-git-send-email-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Daniel Vetter , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKYW4gMTQsIDIwMTYgYXQgMDM6MDI6NTlQTSArMDAwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K PiAKPiBBdCB0aGUgbW9tZW50IGV4ZWNidWYgcmluZyBzZWxlY3Rpb24gaXMgZnVsbHkgY291cGxl ZCB0bwo+IGludGVybmFsIHJpbmcgaWRzIHdoaWNoIGlzIG5vdCBhIGdvb2QgdGhpbmcgb24gaXRz IG93bi4KPiAKPiBUaGlzIGRlcGVuZGVuY3kgaXMgYWxzbyBzcHJlYWQgYmV0d2VlbiB0d28gc291 cmNlIGZpbGVzIGFuZAo+IG5vdCBzcGVsbGVkIG91dCBhdCBlaXRoZXIgc2lkZSB3aGljaCBtYWtl cyBpdCBoaWRkZW4gYW5kCj4gZnJhZ2lsZS4KPiAKPiBUaGlzIHBhdGNoIGRlY291cGxlcyB0aGlz IGRlcGVuZGVuY3kgYnkgaW50cm9kdWNpbmcgYW4gZXhwbGljaXQKPiB0cmFuc2xhdGlvbiB0YWJs ZSBvZiBleGVjYnVmIHVBUEkgdG8gcmluZyBpZCBjbG9zZSB0byB0aGUgb25seQo+IGNhbGwgc2l0 ZSAoaTkxNV9nZW1fZG9fZXhlY2J1ZmZlcikuCj4gCj4gVGhpcyB3YXkgd2UgYXJlIGZyZWUgdG8g Y2hhbmdlIGRyaXZlciBpbnRlcm5hbCBpbXBsZW1lbnRhdGlvbgo+IGRldGFpbHMgd2l0aG91dCBi cmVha2luZyB1c2Vyc3BhY2UuIEFsbCBzdGF0ZSByZWxhdGluZyB0byB0aGUKPiB1QVBJIGlzIG5v dyBjb250YWluZWQgaW4sIG9yIG5leHQgdG8sIGk5MTVfZ2VtX2RvX2V4ZWNidWZmZXIuCgpJIHdh cyBoZXNpc3RhbnQgYXQgZmlyc3QsIHNpbmNlICJ3aHk/IiBpc24ndCBmdWxseSBkZXZlbG9wZWQs IGJ1dCB0aGUKY29kZSB3b24gbWUgb3Zlci4KCj4gKyNkZWZpbmUgSTkxNV9VU0VSX1JJTkdTICg0 KQo+ICsKPiArc3RhdGljIGNvbnN0IGVudW0gaW50ZWxfcmluZ19pZCB1c2VyX3JpbmdfbWFwW0k5 MTVfVVNFUl9SSU5HUyArIDFdID0gewo+ICsJW0k5MTVfRVhFQ19ERUZBVUxUXQk9IFJDUywKPiAr CVtJOTE1X0VYRUNfUkVOREVSXQk9IFJDUywKPiArCVtJOTE1X0VYRUNfQkxUXQkJPSBCQ1MsCj4g KwlbSTkxNV9FWEVDX0JTRF0JCT0gVkNTLAo+ICsJW0k5MTVfRVhFQ19WRUJPWF0JPSBWRUNTCj4g K307CgpJIHdhcyB3b25kZXJpbmcgd2hldGhlciBwYWNraW5nIGhlcmUgbWF0dGVyZWQgYXQgYWxs LCBidXQgd2UncmUgdW5kZXIgYQpjYWNoZWxpbmUgc28gaGlnaGx5IHVubGlrZWx5LgoKPiAgc3Rh dGljIGludAo+ICBpOTE1X2dlbV9kb19leGVjYnVmZmVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs IHZvaWQgKmRhdGEsCj4gIAkJICAgICAgIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwKPiBAQCAtMTM5 Myw2ICsxMzkzLDcgQEAgaTkxNV9nZW1fZG9fZXhlY2J1ZmZlcihzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2LCB2b2lkICpkYXRhLAo+ICAJc3RydWN0IGk5MTVfZXhlY2J1ZmZlcl9wYXJhbXMgcGFyYW1z X21hc3RlcjsgLyogWFhYOiB3aWxsIGJlIHJlbW92ZWQgbGF0ZXIgKi8KPiAgCXN0cnVjdCBpOTE1 X2V4ZWNidWZmZXJfcGFyYW1zICpwYXJhbXMgPSAmcGFyYW1zX21hc3RlcjsKPiAgCWNvbnN0IHUz MiBjdHhfaWQgPSBpOTE1X2V4ZWNidWZmZXIyX2dldF9jb250ZXh0X2lkKCphcmdzKTsKPiArCXVu c2lnbmVkIGludCB1c2VyX3JpbmdfaWQgPSBhcmdzLT5mbGFncyAmIEk5MTVfRVhFQ19SSU5HX01B U0s7Cj4gIAl1MzIgZGlzcGF0Y2hfZmxhZ3M7Cj4gIAlpbnQgcmV0Owo+ICAJYm9vbCBuZWVkX3Jl bG9jczsKPiBAQCAtMTQxNCw0OSArMTQxNSwzOSBAQCBpOTE1X2dlbV9kb19leGVjYnVmZmVyKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gIAlpZiAoYXJncy0+ZmxhZ3MgJiBJ OTE1X0VYRUNfSVNfUElOTkVEKQo+ICAJCWRpc3BhdGNoX2ZsYWdzIHw9IEk5MTVfRElTUEFUQ0hf UElOTkVEOwo+ICAKPiAtCWlmICgoYXJncy0+ZmxhZ3MgJiBJOTE1X0VYRUNfUklOR19NQVNLKSA+ IExBU1RfVVNFUl9SSU5HKSB7Cj4gLQkJRFJNX0RFQlVHKCJleGVjYnVmIHdpdGggdW5rbm93biBy aW5nOiAlZFxuIiwKPiAtCQkJICAoaW50KShhcmdzLT5mbGFncyAmIEk5MTVfRVhFQ19SSU5HX01B U0spKTsKPiArCWlmICh1c2VyX3JpbmdfaWQgPiBJOTE1X1VTRVJfUklOR1MpIHsKPiArCQlEUk1f REVCVUcoImV4ZWNidWYgd2l0aCB1bmtub3duIHJpbmc6ICV1XG4iLCB1c2VyX3JpbmdfaWQpOwo+ ICAJCXJldHVybiAtRUlOVkFMOwo+ICAJfQo+ICAKPiAtCWlmICgoKGFyZ3MtPmZsYWdzICYgSTkx NV9FWEVDX1JJTkdfTUFTSykgIT0gSTkxNV9FWEVDX0JTRCkgJiYKPiArCWlmICgodXNlcl9yaW5n X2lkICE9IEk5MTVfRVhFQ19CU0QpICYmCj4gIAkgICAgKChhcmdzLT5mbGFncyAmIEk5MTVfRVhF Q19CU0RfTUFTSykgIT0gMCkpIHsKPiAgCQlEUk1fREVCVUcoImV4ZWNidWYgd2l0aCBub24gYnNk IHJpbmcgYnV0IHdpdGggaW52YWxpZCAiCj4gIAkJCSJic2QgZGlzcGF0Y2ggZmxhZ3M6ICVkXG4i LCAoaW50KShhcmdzLT5mbGFncykpOwo+ICAJCXJldHVybiAtRUlOVkFMOwo+IC0JfSAKPiAtCj4g LQlpZiAoKGFyZ3MtPmZsYWdzICYgSTkxNV9FWEVDX1JJTkdfTUFTSykgPT0gSTkxNV9FWEVDX0RF RkFVTFQpCj4gLQkJcmluZyA9ICZkZXZfcHJpdi0+cmluZ1tSQ1NdOwo+IC0JZWxzZSBpZiAoKGFy Z3MtPmZsYWdzICYgSTkxNV9FWEVDX1JJTkdfTUFTSykgPT0gSTkxNV9FWEVDX0JTRCkgewo+IC0J CWlmIChIQVNfQlNEMihkZXYpKSB7Cj4gLQkJCWludCByaW5nX2lkOwo+IC0KPiAtCQkJc3dpdGNo IChhcmdzLT5mbGFncyAmIEk5MTVfRVhFQ19CU0RfTUFTSykgewo+IC0JCQljYXNlIEk5MTVfRVhF Q19CU0RfREVGQVVMVDoKPiAtCQkJCXJpbmdfaWQgPSBnZW44X2Rpc3BhdGNoX2JzZF9yaW5nKGRl diwgZmlsZSk7Cj4gLQkJCQlyaW5nID0gJmRldl9wcml2LT5yaW5nW3JpbmdfaWRdOwo+IC0JCQkJ YnJlYWs7Cj4gLQkJCWNhc2UgSTkxNV9FWEVDX0JTRF9SSU5HMToKPiAtCQkJCXJpbmcgPSAmZGV2 X3ByaXYtPnJpbmdbVkNTXTsKPiAtCQkJCWJyZWFrOwo+IC0JCQljYXNlIEk5MTVfRVhFQ19CU0Rf UklORzI6Cj4gLQkJCQlyaW5nID0gJmRldl9wcml2LT5yaW5nW1ZDUzJdOwo+IC0JCQkJYnJlYWs7 Cj4gLQkJCWRlZmF1bHQ6Cj4gLQkJCQlEUk1fREVCVUcoImV4ZWNidWYgd2l0aCB1bmtub3duIGJz ZCByaW5nOiAlZFxuIiwKPiAtCQkJCQkgIChpbnQpKGFyZ3MtPmZsYWdzICYgSTkxNV9FWEVDX0JT RF9NQVNLKSk7Cj4gLQkJCQlyZXR1cm4gLUVJTlZBTDsKPiAtCQkJfQo+IC0JCX0gZWxzZQo+IC0J CQlyaW5nID0gJmRldl9wcml2LT5yaW5nW1ZDU107Cj4gLQl9IGVsc2UKPiAtCQlyaW5nID0gJmRl dl9wcml2LT5yaW5nWyhhcmdzLT5mbGFncyAmIEk5MTVfRVhFQ19SSU5HX01BU0spIC0gMV07Cj4g Kwl9Cj4gKwo+ICsJaWYgKHVzZXJfcmluZ19pZCA9PSBJOTE1X0VYRUNfQlNEICYmIEhBU19CU0Qy KGRldikpIHsKCkhBU19CU0QyKGRldl9wcml2KQoKPiArCQl1bnNpZ25lZCBpbnQgYnNkX2lkeCA9 IGFyZ3MtPmZsYWdzICYgSTkxNV9FWEVDX0JTRF9NQVNLOwo+ICsKPiArCQlpZiAoYnNkX2lkeCA9 PSBJOTE1X0VYRUNfQlNEX0RFRkFVTFQpIHsKPiArCQkJYnNkX2lkeCA9IGdlbjhfZGlzcGF0Y2hf YnNkX3JpbmcoZGV2X3ByaXYsIGZpbGUpOwo+ICsJCX0gZWxzZSBpZiAoYnNkX2lkeCA+PSBJOTE1 X0VYRUNfQlNEX1JJTkcxICYmCj4gKwkJCSAgIGJzZF9pZHggPD0gSTkxNV9FWEVDX0JTRF9SSU5H Mikgewo+ICsJCQlic2RfaWR4LS07Cj4gKwkJfSBlbHNlIHsKPiArCQkJRFJNX0RFQlVHKCJleGVj YnVmIHdpdGggdW5rbm93biBic2QgcmluZzogJXVcbiIsCj4gKwkJCQkgIGJzZF9pZHgpOwo+ICsJ CQlyZXR1cm4gLUVJTlZBTDsKPiArCQl9Cj4gKwo+ICsJCXJpbmcgPSAmZGV2X3ByaXYtPnJpbmdb X1ZDUyhic2RfaWR4KV07Cj4gKwl9IGVsc2Ugewo+ICsJCXJpbmcgPSAmZGV2X3ByaXYtPnJpbmdb dXNlcl9yaW5nX21hcFt1c2VyX3JpbmdfaWRdXTsKPiArCX0KPiAgCj4gIAlpZiAoIWludGVsX3Jp bmdfaW5pdGlhbGl6ZWQocmluZykpIHsKPiAtCQlEUk1fREVCVUcoImV4ZWNidWYgd2l0aCBpbnZh bGlkIHJpbmc6ICVkXG4iLAo+IC0JCQkgIChpbnQpKGFyZ3MtPmZsYWdzICYgSTkxNV9FWEVDX1JJ TkdfTUFTSykpOwo+ICsJCURSTV9ERUJVRygiZXhlY2J1ZiB3aXRoIGludmFsaWQgcmluZzogJXVc biIsIHVzZXJfcmluZ19pZCk7Cj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gIAl9CgpPbmUgcXVlc3Rp b24sIGhvdyBkb2VzIHRoaXMgbG9vayBpZiB3ZSBtb3ZlIHRoaXMgc2VjdGlvbiB0byBpdHMgb3du CmZ1bmN0aW9uOgoKcmluZyA9IGViX3NlbGVjdF9yaW5nKGRldl9wcml2LCBmaWxlLCBhcmdzKTsK aWYgKElTX0VSUihyaW5nKSkKCXJldHVybiBQVFJfRVJSKHJpbmcpOwoKRG8geW91IGtlZXAgeW91 ciBjb2RlIHNpemUgcmVkdWN0aW9uPwoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcmluZ2J1ZmZlci5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1 ZmZlci5oCj4gaW5kZXggNzM0OWQ5MjU4MTkxLi5mZGMyMjBmYzJiMTggMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gQEAgLTE0OCwxNCArMTQ4LDE0IEBAIHN0 cnVjdCAgaTkxNV9jdHhfd29ya2Fyb3VuZHMgewo+ICBzdHJ1Y3QgIGludGVsX2VuZ2luZV9jcyB7 Cj4gIAljb25zdCBjaGFyCSpuYW1lOwo+ICAJZW51bSBpbnRlbF9yaW5nX2lkIHsKPiAtCQlSQ1Mg PSAweDAsCj4gLQkJVkNTLAo+ICsJCVJDUyA9IDAsCj4gIAkJQkNTLAo+IC0JCVZFQ1MsCj4gLQkJ VkNTMgo+ICsJCVZDUywKPiArCQlWQ1MyLAkvKiBLZWVwIGluc3RhbmNlcyBvZiB0aGUgc2FtZSB0 eXBlIGVuZ2luZSB0b2dldGhlci4gKi8KPiArCQlWRUNTCgpUZWNobmljYWxseSwgdGhpcyBicmVh a3MgdXNlcnNwYWNlIEFCSSBlbHNld2hlcmUuIDp8IFRob3VnaCB0aGUgb25seQp1c2VyIG9mIHRo ZSBpZCBtYXNrIGlzIG9ubHkgbG9va2luZyBmb3IgUkNTPT0wIHZzIHRoZSByZXNldC4KClNvIEkg dGhpbmsgd2Ugd291bGQgY29wZSwgYnV0IHRvIGJlIGV4dHJhIHNhZmUgd2UgY291bGQganVzdCBh dm9pZApyZXNodWZmbGluZyB0aGUgaWRzLiBMZXQgbWUgc2xlZXAgb24gdGhlIGltcGxpY2F0aW9u cy4gV2UgbWF5IHNheSBqdXN0CmJyZWFrIHRoYXQgQUJJIHdoaWxzdCB3ZSBzdGlsbCBjYW4gYW5k IGRvIGEgcmV2ZXJzZS1tYXAgdG8gRVhFQyBiaXQuCkhtbS4KLUNocmlzCgotLSAKQ2hyaXMgV2ls c29uLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRyZQpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=