All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javi Merino <javi.merino@arm.com>
To: Zhang Rui <rui.zhang@intel.com>, Eduardo Valentin <edubezval@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Amit Daniel Kachhap <amit.kachhap@gmail.com>,
	Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH] thermal: cpu_cooling: fix out of bounds access in time_in_idle
Date: Fri, 15 Jan 2016 15:20:56 +0000	[thread overview]
Message-ID: <20160115152055.GA2917@e104805> (raw)
In-Reply-To: <20160105191925.GD3163@e104805>

Eduardo, Rui,

On Tue, Jan 05, 2016 at 07:19:25PM +0000, Javi Merino wrote:
> On Mon, Dec 21, 2015 at 08:49:40AM +0530, Viresh Kumar wrote:
> > On 19-12-15, 12:54, Javi Merino wrote:
> > > In __cpufreq_cooling_register() we allocate the arrays for time_in_idle
> > > and time_in_idle_timestamp to be as big as the number of cpus in this
> > > cpufreq device.  However, in get_load() we access this array using the
> > > cpu number as index, which can result in an out of bound access.
> > > 
> > > Index time_in_idle{,_timestamp} using the index in the cpufreq_device's
> > > allowed_cpus mask, as we do for the load_cpu array in
> > > cpufreq_get_requested_power()
> > > 
> > > Reported-by: Nicolas Boichat <drinkcat@chromium.org>
> > > Cc: Amit Daniel Kachhap <amit.kachhap@gmail.com>
> > > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > > Cc: Zhang Rui <rui.zhang@intel.com>
> > > Cc: Eduardo Valentin <edubezval@gmail.com>
> > > Signed-off-by: Javi Merino <javi.merino@arm.com>
> > > ---
> > >  drivers/thermal/cpu_cooling.c | 14 ++++++++------
> > >  1 file changed, 8 insertions(+), 6 deletions(-)
> > 
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> If there are no more objections, can you pick this up?

Another gentle ping, can this be merged?

Thanks,
Javi

  reply	other threads:[~2016-01-15 15:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-19 12:54 [PATCH] thermal: cpu_cooling: fix out of bounds access in time_in_idle Javi Merino
2015-12-21  3:19 ` Viresh Kumar
2016-01-05 19:19   ` Javi Merino
2016-01-15 15:20     ` Javi Merino [this message]
2016-01-18  2:25       ` Nicolas Boichat
2016-01-25 14:44         ` Javi Merino
2016-02-11 12:00 Javi Merino
2016-02-11 15:00 ` Eduardo Valentin
2016-02-11 18:45   ` Javi Merino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160115152055.GA2917@e104805 \
    --to=javi.merino@arm.com \
    --cc=amit.kachhap@gmail.com \
    --cc=edubezval@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.