From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751471AbcARGPB (ORCPT ); Mon, 18 Jan 2016 01:15:01 -0500 Received: from mail-pf0-f173.google.com ([209.85.192.173]:35638 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750857AbcARGPA (ORCPT ); Mon, 18 Jan 2016 01:15:00 -0500 Date: Sun, 17 Jan 2016 22:14:56 -0800 From: Dmitry Torokhov To: Greg Kroah-Hartman Cc: Rob Herring , Grant Likely , Linus Walleij , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: [PATCH] driver-core: platform: automatically mark wakeup devices Message-ID: <20160118061456.GA9099@dtor-ws> References: <20160118021138.GA20498@dtor-ws> <20160118051125.GA23372@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160118051125.GA23372@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 17, 2016 at 09:11:25PM -0800, Greg Kroah-Hartman wrote: > On Sun, Jan 17, 2016 at 06:11:38PM -0800, Dmitry Torokhov wrote: > > When probing platform drivers let's check if corresponding devices have > > "wakeup-source" property defined (either in device tree, ACPI, or static > > platform properties) and automatically enable such devices as wakeup > > sources for the system. This will help us standardize on the name for this > > property and reduce amount of boilerplate code in the drivers. > > How much boilerplate code can be removed? Do you have an example patch > of this removal for any drivers if we move this logic into the driver core? Admittedly not a lot, a few lines. There is a couple of lines for checking the property and calling device_init_wakeup() and also sometimes clearing wakeup flag is the only thing that is left in remove() method after converting to devm*. I am more interested in standardizing on the property name and having wakeup flag cleared on removal or probe failure, similarly how we do it for driver data in device structure. I do not have good patches in input at the moment as even though we are using "wakeup-source" now lots if the drivers did not start with it and so we have compatibility parsing still that we want to keep around. I want the new drivers to use only this property though. FWIW I2C bus code implements automatic parsing of this property as well and I wonder if we want to do the same for SPI. Thanks. -- Dmitry