From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757389AbcASHpm (ORCPT ); Tue, 19 Jan 2016 02:45:42 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36056 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752086AbcASHpi (ORCPT ); Tue, 19 Jan 2016 02:45:38 -0500 Date: Tue, 19 Jan 2016 08:45:34 +0100 From: Ingo Molnar To: Alexander Shishkin Cc: Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, Arnaldo Carvalho de Melo , Jiri Olsa Subject: Re: [PATCH] perf: Synchronously cleanup child events Message-ID: <20160119074534.GA18237@gmail.com> References: <20160115130932.GL6357@twins.programming.kicks-ass.net> <1452866861-17680-1-git-send-email-alexander.shishkin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452866861-17680-1-git-send-email-alexander.shishkin@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Alexander Shishkin wrote: > The orphan cleanup workqueue doesn't always catch orphans, for example, if they > never schedule after they are orphaned. IOW, the event leak is still very real. > It also wouldn't work for kernel counters. > > Also, there seems to be no reason not to carry out this cleanup procedure > synchronously during parent event's destruction. Absolutely, synchronous cleanup will probably also be quicker at triggering any remaining (and new ;-) races. Thanks, Ingo