From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Date: Tue, 19 Jan 2016 14:10:40 +0100 Subject: [U-Boot] [PATCH] ARM: tegra: rm Jetson TK1 PMIC GPIO programming In-Reply-To: <1453141396-18350-1-git-send-email-swarren@wwwdotorg.org> References: <1453141396-18350-1-git-send-email-swarren@wwwdotorg.org> Message-ID: <20160119131039.GB27966@ulmo.nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Jan 18, 2016 at 11:23:16AM -0700, Stephen Warren wrote: > From: Stephen Warren > > The PMIC is configured such that its GPIOs have the correct configuration > at power-up, so no programming is required. > > In fact, the current programming is actively wrong, since: > > (a) the AS3722 driver configures the GPIO to be an output before setting > its output value, which causes a 0v glitch on the output. > > (b) the AS3722 driver configures the GPIO to drive a high voltage from its > VSUP_GPIO power source rather than its VDD_GPIO_LV power source, so the pin > drives 5V not 1.8V as desired. > > Solve these problems by removing the code which configures the PMIC GPIOs. > > Note that this patch was tested directly on top of v2016.01; since then, > commit 96350f729c42 "dm: tegra: net: Convert tegra boards to driver model > for Ethernet" prevents PCIe from being initialized. Alternatively, simply > revert that commit to get PCIe Ethernet working again, then apply this > patch to test. > > Signed-off-by: Stephen Warren > --- > board/nvidia/jetson-tk1/jetson-tk1.c | 13 ------------- > 1 file changed, 13 deletions(-) Looks reasonable to me: Acked-by: Thierry Reding -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: