From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39724)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1aLa5x-00006n-Tr
	for qemu-devel@nongnu.org; Tue, 19 Jan 2016 12:29:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1aLa5v-0006xx-61
	for qemu-devel@nongnu.org; Tue, 19 Jan 2016 12:29:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52526)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1aLa5v-0006xM-10
	for qemu-devel@nongnu.org; Tue, 19 Jan 2016 12:29:27 -0500
Date: Tue, 19 Jan 2016 18:29:23 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20160119172923.GG4579@noname.redhat.com>
References: <1452517517-3953-1-git-send-email-vsementsov@virtuozzo.com>
	<56981C60.9020005@redhat.com> <56982EA9.6030602@redhat.com>
	<569A4E71.5010004@virtuozzo.com> <569D18CE.5070104@redhat.com>
	<569D5648.6030605@redhat.com> <569DFA95.5020409@virtuozzo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <569DFA95.5020409@virtuozzo.com>
Subject: Re: [Qemu-devel] [PATCH v7] spec: add qcow2 bitmaps extension
 specification
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: famz@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, den@openvz.org, John Snow <jsnow@redhat.com>

Am 19.01.2016 um 09:57 hat Vladimir Sementsov-Ogievskiy geschrieben:
> On 19.01.2016 00:16, Eric Blake wrote:
> >preserving semantics of those extra_data bytes).  We
> >have enough room for future extension, and that's good e
> 
> Ok, so, what should go to the spec? Current wording is ok? Just
> delete "Type-specific":
> 
> +
> +        20 - 23:    extra_data_size
> +                    Size of type-specific extra data.
> +
> +                    For now, as no extra data is defined, extra_data_size is
> +                    reserved and must be zero.
> +
> +        variable:   Extra data for the bitmap.

Please be explicit that if extra_data_size is non-zero, the bitmap must
not be used (i.e. specify the incompatible-feature-bit-like behaviour).

Kevin