From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932651AbcASRwj (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 Jan 2016 12:52:39 -0500
Received: from mail-yk0-f182.google.com ([209.85.160.182]:33958 "EHLO
	mail-yk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932590AbcASRwa (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 Jan 2016 12:52:30 -0500
Date: Tue, 19 Jan 2016 15:52:26 -0200
From: Gustavo Padovan <gustavo@padovan.org>
To: John Harrison <John.C.Harrison@Intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
        dri-devel@lists.freedesktop.org, daniels@collabora.com,
        Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
        Riley Andrews <riandrews@android.com>, Rob Clark <robdclark@gmail.com>,
        Greg Hackmann <ghackmann@google.com>,
        Maarten Lankhorst <maarten.lankhorst@canonical.com>,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: Re: [RFC 00/29] De-stage android's sync framework
Message-ID: <20160119175226.GB8217@joana>
Mail-Followup-To: Gustavo Padovan <gustavo@padovan.org>,
	John Harrison <John.C.Harrison@Intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	dri-devel@lists.freedesktop.org, daniels@collabora.com,
	Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
	Riley Andrews <riandrews@android.com>,
	Rob Clark <robdclark@gmail.com>,
	Greg Hackmann <ghackmann@google.com>,
	Maarten Lankhorst <maarten.lankhorst@canonical.com>,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>
References: <1452869739-3304-1-git-send-email-gustavo@padovan.org>
 <20160119110017.GZ19130@phenom.ffwll.local>
 <20160119152309.GA8217@joana>
 <569E6062.6030309@Intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <569E6062.6030309@Intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2016-01-19 John Harrison <John.C.Harrison@Intel.com>:

> On 19/01/2016 15:23, Gustavo Padovan wrote:
> >Hi Daniel,
> >
> >2016-01-19 Daniel Vetter <daniel@ffwll.ch>:
> >
> >>On Fri, Jan 15, 2016 at 12:55:10PM -0200, Gustavo Padovan wrote:
> >>>From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >>>
> >>>This patch series de-stage the sync framework, and in order to accomplish that
> >>>a bunch of cleanups/improvements on the sync and fence were made.
> >>>
> >>>The sync framework contained some abstractions around struct fence and those
> >>>were removed in the de-staging process among other changes:
> >>>
> >>>Userspace visible changes
> >>>-------------------------
> >>>
> >>>  * The sw_sync file was moved from /dev/sw_sync to <debugfs>/sync/sw_sync. No
> >>>  other change.
> >>>
> >>>Kernel API changes
> >>>------------------
> >>>
> >>>  * struct sync_timeline is now struct fence_timeline
> >>>  * sync_timeline_ops is now fence_timeline_ops and they now carry struct
> >>>  fence as parameter instead of struct sync_pt
> >>>  * a .cleanup() fence op was added to allow sync_fence to run a cleanup when
> >>>  the fence_timeline is destroyed
> >>>  * added fence_add_used_data() to pass a private point to struct fence. This
> >>>  pointer is sent back on the .cleanup op.
> >>>  * The sync timeline function were moved to be fence_timeline functions:
> >>>	 - sync_timeline_create()	-> fence_timeline_create()
> >>>	 - sync_timeline_get()		-> fence_timeline_get()
> >>>	 - sync_timeline_put()		-> fence_timeline_put()
> >>>	 - sync_timeline_destroy()	-> fence_timeline_destroy()
> >>>	 - sync_timeline_signal()	-> fence_timeline_signal()
> >>>
> >>>   * sync_pt_create() was replaced be fence_create_on_timeline()
> >>>
> >>>Internal changes
> >>>----------------
> >>>
> >>>  * fence_timeline_ops was removed in favor of direct use fence_ops
> >>>  * fence default functions were created for fence_ops
> >>>  * removed structs sync_pt, sw_sync_timeline and sw_sync_pt
> >>Bunch of fairly random comments all over:
> >>
> >>- include/uapi/linux/sw_sync.h imo should be dropped, it's just a private
> >>   debugfs interface between fence fds and the testsuite. Since the plan is
> >>   to have the testcases integrated into the kernel tree too we don't need
> >>   a public header.
> >>
> >>- similar for include/linux/sw_sync.h Imo that should all be moved into
> >>   sync_debug.c. Same for sw_sync.c, that should all land in sync_debug
> >>   imo, and made optional with a Kconfig option. At least we should reuse
> >>   CONFIG_DEBUGFS.
> >These two items sounds reasonable to me.
> 
> I have just posted our in-progress IGT for testing i915 syncs (with a CC of
> Gustavo). It uses the sw_sync mechanisms. Can you take a quick look and see
> if it is the kind of thing you would expect us to be doing? Or is it using
> interfaces that you are planning to remove and/or make kernel only?
> 
> I'm not sure having a kernel only test is the best way to go. Having user
> land tests like IGT would be much more versatile.

I agree with you, we should allow IGT and other test tools to access
sw_sync. include/linux/sw_sync.h can be kept private, but the uapi one
needs wil be needed for testing, unless we replicate the header file
inside IGT, but not sure if it is a good idea.

	Gustavo

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gustavo Padovan <gustavo@padovan.org>
Subject: Re: [RFC 00/29] De-stage android's sync framework
Date: Tue, 19 Jan 2016 15:52:26 -0200
Message-ID: <20160119175226.GB8217@joana>
References: <1452869739-3304-1-git-send-email-gustavo@padovan.org>
 <20160119110017.GZ19130@phenom.ffwll.local>
 <20160119152309.GA8217@joana> <569E6062.6030309@Intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-yk0-f176.google.com (mail-yk0-f176.google.com
 [209.85.160.176])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 5481C6E0B2
 for <dri-devel@lists.freedesktop.org>; Tue, 19 Jan 2016 09:52:30 -0800 (PST)
Received: by mail-yk0-f176.google.com with SMTP id a85so578916791ykb.1
 for <dri-devel@lists.freedesktop.org>; Tue, 19 Jan 2016 09:52:30 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <569E6062.6030309@Intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: John Harrison <John.C.Harrison@Intel.com>
Cc: devel@driverdev.osuosl.org, daniels@collabora.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Maarten Lankhorst <maarten.lankhorst@canonical.com>, Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>, Riley Andrews <riandrews@android.com>, Gustavo Padovan <gustavo.padovan@collabora.co.uk>
List-Id: dri-devel@lists.freedesktop.org

MjAxNi0wMS0xOSBKb2huIEhhcnJpc29uIDxKb2huLkMuSGFycmlzb25ASW50ZWwuY29tPjoKCj4g
T24gMTkvMDEvMjAxNiAxNToyMywgR3VzdGF2byBQYWRvdmFuIHdyb3RlOgo+ID5IaSBEYW5pZWws
Cj4gPgo+ID4yMDE2LTAxLTE5IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD46Cj4gPgo+
ID4+T24gRnJpLCBKYW4gMTUsIDIwMTYgYXQgMTI6NTU6MTBQTSAtMDIwMCwgR3VzdGF2byBQYWRv
dmFuIHdyb3RlOgo+ID4+PkZyb206IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNv
bGxhYm9yYS5jby51az4KPiA+Pj4KPiA+Pj5UaGlzIHBhdGNoIHNlcmllcyBkZS1zdGFnZSB0aGUg
c3luYyBmcmFtZXdvcmssIGFuZCBpbiBvcmRlciB0byBhY2NvbXBsaXNoIHRoYXQKPiA+Pj5hIGJ1
bmNoIG9mIGNsZWFudXBzL2ltcHJvdmVtZW50cyBvbiB0aGUgc3luYyBhbmQgZmVuY2Ugd2VyZSBt
YWRlLgo+ID4+Pgo+ID4+PlRoZSBzeW5jIGZyYW1ld29yayBjb250YWluZWQgc29tZSBhYnN0cmFj
dGlvbnMgYXJvdW5kIHN0cnVjdCBmZW5jZSBhbmQgdGhvc2UKPiA+Pj53ZXJlIHJlbW92ZWQgaW4g
dGhlIGRlLXN0YWdpbmcgcHJvY2VzcyBhbW9uZyBvdGhlciBjaGFuZ2VzOgo+ID4+Pgo+ID4+PlVz
ZXJzcGFjZSB2aXNpYmxlIGNoYW5nZXMKPiA+Pj4tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4g
Pj4+Cj4gPj4+ICAqIFRoZSBzd19zeW5jIGZpbGUgd2FzIG1vdmVkIGZyb20gL2Rldi9zd19zeW5j
IHRvIDxkZWJ1Z2ZzPi9zeW5jL3N3X3N5bmMuIE5vCj4gPj4+ICBvdGhlciBjaGFuZ2UuCj4gPj4+
Cj4gPj4+S2VybmVsIEFQSSBjaGFuZ2VzCj4gPj4+LS0tLS0tLS0tLS0tLS0tLS0tCj4gPj4+Cj4g
Pj4+ICAqIHN0cnVjdCBzeW5jX3RpbWVsaW5lIGlzIG5vdyBzdHJ1Y3QgZmVuY2VfdGltZWxpbmUK
PiA+Pj4gICogc3luY190aW1lbGluZV9vcHMgaXMgbm93IGZlbmNlX3RpbWVsaW5lX29wcyBhbmQg
dGhleSBub3cgY2Fycnkgc3RydWN0Cj4gPj4+ICBmZW5jZSBhcyBwYXJhbWV0ZXIgaW5zdGVhZCBv
ZiBzdHJ1Y3Qgc3luY19wdAo+ID4+PiAgKiBhIC5jbGVhbnVwKCkgZmVuY2Ugb3Agd2FzIGFkZGVk
IHRvIGFsbG93IHN5bmNfZmVuY2UgdG8gcnVuIGEgY2xlYW51cCB3aGVuCj4gPj4+ICB0aGUgZmVu
Y2VfdGltZWxpbmUgaXMgZGVzdHJveWVkCj4gPj4+ICAqIGFkZGVkIGZlbmNlX2FkZF91c2VkX2Rh
dGEoKSB0byBwYXNzIGEgcHJpdmF0ZSBwb2ludCB0byBzdHJ1Y3QgZmVuY2UuIFRoaXMKPiA+Pj4g
IHBvaW50ZXIgaXMgc2VudCBiYWNrIG9uIHRoZSAuY2xlYW51cCBvcC4KPiA+Pj4gICogVGhlIHN5
bmMgdGltZWxpbmUgZnVuY3Rpb24gd2VyZSBtb3ZlZCB0byBiZSBmZW5jZV90aW1lbGluZSBmdW5j
dGlvbnM6Cj4gPj4+CSAtIHN5bmNfdGltZWxpbmVfY3JlYXRlKCkJLT4gZmVuY2VfdGltZWxpbmVf
Y3JlYXRlKCkKPiA+Pj4JIC0gc3luY190aW1lbGluZV9nZXQoKQkJLT4gZmVuY2VfdGltZWxpbmVf
Z2V0KCkKPiA+Pj4JIC0gc3luY190aW1lbGluZV9wdXQoKQkJLT4gZmVuY2VfdGltZWxpbmVfcHV0
KCkKPiA+Pj4JIC0gc3luY190aW1lbGluZV9kZXN0cm95KCkJLT4gZmVuY2VfdGltZWxpbmVfZGVz
dHJveSgpCj4gPj4+CSAtIHN5bmNfdGltZWxpbmVfc2lnbmFsKCkJLT4gZmVuY2VfdGltZWxpbmVf
c2lnbmFsKCkKPiA+Pj4KPiA+Pj4gICAqIHN5bmNfcHRfY3JlYXRlKCkgd2FzIHJlcGxhY2VkIGJl
IGZlbmNlX2NyZWF0ZV9vbl90aW1lbGluZSgpCj4gPj4+Cj4gPj4+SW50ZXJuYWwgY2hhbmdlcwo+
ID4+Pi0tLS0tLS0tLS0tLS0tLS0KPiA+Pj4KPiA+Pj4gICogZmVuY2VfdGltZWxpbmVfb3BzIHdh
cyByZW1vdmVkIGluIGZhdm9yIG9mIGRpcmVjdCB1c2UgZmVuY2Vfb3BzCj4gPj4+ICAqIGZlbmNl
IGRlZmF1bHQgZnVuY3Rpb25zIHdlcmUgY3JlYXRlZCBmb3IgZmVuY2Vfb3BzCj4gPj4+ICAqIHJl
bW92ZWQgc3RydWN0cyBzeW5jX3B0LCBzd19zeW5jX3RpbWVsaW5lIGFuZCBzd19zeW5jX3B0Cj4g
Pj5CdW5jaCBvZiBmYWlybHkgcmFuZG9tIGNvbW1lbnRzIGFsbCBvdmVyOgo+ID4+Cj4gPj4tIGlu
Y2x1ZGUvdWFwaS9saW51eC9zd19zeW5jLmggaW1vIHNob3VsZCBiZSBkcm9wcGVkLCBpdCdzIGp1
c3QgYSBwcml2YXRlCj4gPj4gICBkZWJ1Z2ZzIGludGVyZmFjZSBiZXR3ZWVuIGZlbmNlIGZkcyBh
bmQgdGhlIHRlc3RzdWl0ZS4gU2luY2UgdGhlIHBsYW4gaXMKPiA+PiAgIHRvIGhhdmUgdGhlIHRl
c3RjYXNlcyBpbnRlZ3JhdGVkIGludG8gdGhlIGtlcm5lbCB0cmVlIHRvbyB3ZSBkb24ndCBuZWVk
Cj4gPj4gICBhIHB1YmxpYyBoZWFkZXIuCj4gPj4KPiA+Pi0gc2ltaWxhciBmb3IgaW5jbHVkZS9s
aW51eC9zd19zeW5jLmggSW1vIHRoYXQgc2hvdWxkIGFsbCBiZSBtb3ZlZCBpbnRvCj4gPj4gICBz
eW5jX2RlYnVnLmMuIFNhbWUgZm9yIHN3X3N5bmMuYywgdGhhdCBzaG91bGQgYWxsIGxhbmQgaW4g
c3luY19kZWJ1Zwo+ID4+ICAgaW1vLCBhbmQgbWFkZSBvcHRpb25hbCB3aXRoIGEgS2NvbmZpZyBv
cHRpb24uIEF0IGxlYXN0IHdlIHNob3VsZCByZXVzZQo+ID4+ICAgQ09ORklHX0RFQlVHRlMuCj4g
PlRoZXNlIHR3byBpdGVtcyBzb3VuZHMgcmVhc29uYWJsZSB0byBtZS4KPiAKPiBJIGhhdmUganVz
dCBwb3N0ZWQgb3VyIGluLXByb2dyZXNzIElHVCBmb3IgdGVzdGluZyBpOTE1IHN5bmNzICh3aXRo
IGEgQ0Mgb2YKPiBHdXN0YXZvKS4gSXQgdXNlcyB0aGUgc3dfc3luYyBtZWNoYW5pc21zLiBDYW4g
eW91IHRha2UgYSBxdWljayBsb29rIGFuZCBzZWUKPiBpZiBpdCBpcyB0aGUga2luZCBvZiB0aGlu
ZyB5b3Ugd291bGQgZXhwZWN0IHVzIHRvIGJlIGRvaW5nPyBPciBpcyBpdCB1c2luZwo+IGludGVy
ZmFjZXMgdGhhdCB5b3UgYXJlIHBsYW5uaW5nIHRvIHJlbW92ZSBhbmQvb3IgbWFrZSBrZXJuZWwg
b25seT8KPiAKPiBJJ20gbm90IHN1cmUgaGF2aW5nIGEga2VybmVsIG9ubHkgdGVzdCBpcyB0aGUg
YmVzdCB3YXkgdG8gZ28uIEhhdmluZyB1c2VyCj4gbGFuZCB0ZXN0cyBsaWtlIElHVCB3b3VsZCBi
ZSBtdWNoIG1vcmUgdmVyc2F0aWxlLgoKSSBhZ3JlZSB3aXRoIHlvdSwgd2Ugc2hvdWxkIGFsbG93
IElHVCBhbmQgb3RoZXIgdGVzdCB0b29scyB0byBhY2Nlc3MKc3dfc3luYy4gaW5jbHVkZS9saW51
eC9zd19zeW5jLmggY2FuIGJlIGtlcHQgcHJpdmF0ZSwgYnV0IHRoZSB1YXBpIG9uZQpuZWVkcyB3
aWwgYmUgbmVlZGVkIGZvciB0ZXN0aW5nLCB1bmxlc3Mgd2UgcmVwbGljYXRlIHRoZSBoZWFkZXIg
ZmlsZQppbnNpZGUgSUdULCBidXQgbm90IHN1cmUgaWYgaXQgaXMgYSBnb29kIGlkZWEuCgoJR3Vz
dGF2bwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt
ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDov
L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=