From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757689AbcASTzX (ORCPT ); Tue, 19 Jan 2016 14:55:23 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42089 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757631AbcASTzN (ORCPT ); Tue, 19 Jan 2016 14:55:13 -0500 Date: Tue, 19 Jan 2016 11:55:12 -0800 From: Greg Kroah-Hartman To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Alan Stern , Linux-pm mailing list , Kernel development list Subject: Re: Crash introduced by commit b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks are called unconditionally") Message-ID: <20160119195512.GA17729@kroah.com> References: <20160119190709.GA3338@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160119190709.GA3338@pengutronix.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 19, 2016 at 08:07:09PM +0100, Uwe Kleine-König wrote: > Hello Alan, > > On Tue, Jan 19, 2016 at 01:22:22PM -0500, Alan Stern wrote: > > > > Your commit causes my ASUS laptop to crash during early boot. The > > problem occurs in platform_drv_probe(), affecting both the alarmtimer > > and the asus_laptop platform drivers (I can't tell which is the > > critical one). > > > > The old code would not call platform_drv_probe() at all, and probing > > would always succeed immediately because these drivers have no probe > > routine. But with the new code, platform_drv_probe() does run. The > > call to of_clk_set_defaults() returns -ENODEV, as does the call to > > dev_pm_domain_attach(). The call to drv->probe() gets skipped, of > > course. The final return value is -ENODEV, and so probing fails. This > > causes the kernel to crash: blank screen, NumLock LED blinking. > > > > The patch below fixes the problem, but I'm not sure that it's the best > > solution. What is your advice? > You want > > http://mid.gmane.org/1449132704-9952-1-git-send-email-martin.wilck@ts.fujitsu.com > > . > > Greg, I'd welcome this fix in mainline and 4.4.x. Yes it's in my queue to get to after 4.5-rc1 -s out. thanks, greg k-h