From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933022AbcASUKx (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 Jan 2016 15:10:53 -0500
Received: from mail-yk0-f180.google.com ([209.85.160.180]:34428 "EHLO
	mail-yk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932531AbcASUKp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 Jan 2016 15:10:45 -0500
Date: Tue, 19 Jan 2016 18:10:40 -0200
From: Gustavo Padovan <gustavo@padovan.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
        dri-devel@lists.freedesktop.org, daniels@collabora.com,
        Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
        Riley Andrews <riandrews@android.com>, Rob Clark <robdclark@gmail.com>,
        Greg Hackmann <ghackmann@google.com>,
        John Harrison <John.C.Harrison@Intel.com>,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: Re: [RFC 00/29] De-stage android's sync framework
Message-ID: <20160119201040.GD8217@joana>
Mail-Followup-To: Gustavo Padovan <gustavo@padovan.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	dri-devel@lists.freedesktop.org, daniels@collabora.com,
	Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
	Riley Andrews <riandrews@android.com>,
	Rob Clark <robdclark@gmail.com>,
	Greg Hackmann <ghackmann@google.com>,
	John Harrison <John.C.Harrison@Intel.com>,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>
References: <1452869739-3304-1-git-send-email-gustavo@padovan.org>
 <20160119110017.GZ19130@phenom.ffwll.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160119110017.GZ19130@phenom.ffwll.local>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2016-01-19 Daniel Vetter <daniel@ffwll.ch>:

> On Fri, Jan 15, 2016 at 12:55:10PM -0200, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > 
> > This patch series de-stage the sync framework, and in order to accomplish that
> > a bunch of cleanups/improvements on the sync and fence were made.
> > 
> > The sync framework contained some abstractions around struct fence and those
> > were removed in the de-staging process among other changes:
> > 
> > Userspace visible changes
> > -------------------------
> > 
> >  * The sw_sync file was moved from /dev/sw_sync to <debugfs>/sync/sw_sync. No
> >  other change.
> > 
> > Kernel API changes
> > ------------------
> > 
> >  * struct sync_timeline is now struct fence_timeline
> >  * sync_timeline_ops is now fence_timeline_ops and they now carry struct
> >  fence as parameter instead of struct sync_pt
> >  * a .cleanup() fence op was added to allow sync_fence to run a cleanup when
> >  the fence_timeline is destroyed
> >  * added fence_add_used_data() to pass a private point to struct fence. This
> >  pointer is sent back on the .cleanup op.
> >  * The sync timeline function were moved to be fence_timeline functions:
> > 	 - sync_timeline_create()	-> fence_timeline_create()
> > 	 - sync_timeline_get()		-> fence_timeline_get()
> > 	 - sync_timeline_put()		-> fence_timeline_put()
> > 	 - sync_timeline_destroy()	-> fence_timeline_destroy()
> > 	 - sync_timeline_signal()	-> fence_timeline_signal()
> > 
> >   * sync_pt_create() was replaced be fence_create_on_timeline()
> > 
> > Internal changes
> > ----------------
> > 
> >  * fence_timeline_ops was removed in favor of direct use fence_ops
> >  * fence default functions were created for fence_ops
> >  * removed structs sync_pt, sw_sync_timeline and sw_sync_pt
> 
> Bunch of fairly random comments all over:
> 
> - include/uapi/linux/sw_sync.h imo should be dropped, it's just a private
>   debugfs interface between fence fds and the testsuite. Since the plan is
>   to have the testcases integrated into the kernel tree too we don't need
>   a public header.
> 
> - similar for include/linux/sw_sync.h Imo that should all be moved into
>   sync_debug.c. Same for sw_sync.c, that should all land in sync_debug
>   imo, and made optional with a Kconfig option. At least we should reuse
>   CONFIG_DEBUGFS.
> 
> - fence_context and fence_timeline are really the same. timeline has some
>   super-basic support for doing sw-only fence timelines, but imo that's
>   not really worth keeping (and if so better to keep seperate in a
>   sw-fence.c or similar, like seqno-fence.c). The other main thing
>   timeline provides is support to clean up fences on a timeline. And imo
>   that cleanup should be done by the core fence support, not by the add-on
>   stuff.
> 
> Interlude about fence cleanup on driver unload:
> 
> Working drivers imo should never call timeline_destroy when there's still
> an unsignalled fence around for that timeline/context. That just means
> they're broken and failed to clean up all the pending work. So the problem
> really is only what to do with fences where the driver disappeared, and
> for that we essentially need a fence_revoke() function (which could be
> called internally from timeline_free). So here's what I think
> timeline_free should do:
> 
> for_each_fence_on_timel() {
> 	WARN_ON(!fence_is_signalled());
> 
> 	fence_revoke(fence);
> }
> 
> Implementing fence_revoke is a bit tricky since we need to make sure the
> memory contained ->ops and similar stuff doesn't disappear. Simplest
> option might be to grab a temporary reference (using
> kref_get_unless_zero), and then exchange ->ops with one that has only a
> release function. We don't need anything else as long as all fence_*
> functions the kernel might call check for signalling correctly first
> (fence_wait is broken at least).
> 
> Or we just give up (for now) and declare module unload as slightly racy.
> dma-buf is similar. An intermediate option might be to at least add a
> THIS_MODULE reference to each fence (but that's a bit expensive ...).
> 
> - back to timeline vs. context: I have no idea how to best clean up this
>   mess, but least painful option long-term is probably to switch over all
>   current users of fence_context_alloc to timelines and remove the plain
>   context interface.
> 
> - Imo the interface in include/linux/sync.h is duplicating too much of
>   fence.h. I think the only bits we need are the refcounting, creating,
>   fd-install and that's it. Plus a macro to loop over all the fences in a
>   sync_fence. With that drivers will only ever deal with a pile of
>   struct fence, making implicit fencing (using the fence list in dma-buf)
>   and explicit fencing (using the fence list in sync_fence) much more
>   similar.
> 
>   And we can easily do that since no internal users ;-)
> 
> - get_timeline_name and get_driver_name are imo too much indirection, just
>   add ->(drv_)name field to each of these.

I don't think is a good idea to change that now as there are other fence
users in the kernel using get_timeline_name and get_driver_name. What I
propose is try get rid of this when moving ops from fences to
fence_timeline.

	Gustavo

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gustavo Padovan <gustavo@padovan.org>
Subject: Re: [RFC 00/29] De-stage android's sync framework
Date: Tue, 19 Jan 2016 18:10:40 -0200
Message-ID: <20160119201040.GD8217@joana>
References: <1452869739-3304-1-git-send-email-gustavo@padovan.org>
 <20160119110017.GZ19130@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-yk0-f169.google.com (mail-yk0-f169.google.com
 [209.85.160.169])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 65CEA6E86B
 for <dri-devel@lists.freedesktop.org>; Tue, 19 Jan 2016 12:10:45 -0800 (PST)
Received: by mail-yk0-f169.google.com with SMTP id k129so639052372yke.0
 for <dri-devel@lists.freedesktop.org>; Tue, 19 Jan 2016 12:10:45 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20160119110017.GZ19130@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, daniels@collabora.com, Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>, Riley Andrews <riandrews@android.com>, Rob Clark <robdclark@gmail.com>, Greg Hackmann <ghackmann@google.com>, John Harrison <John.C.Harrison@Intel.com>, Gustavo Padovan <gustavo.padovan@collabora.co.uk>
List-Id: dri-devel@lists.freedesktop.org

MjAxNi0wMS0xOSBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+OgoKPiBPbiBGcmksIEph
biAxNSwgMjAxNiBhdCAxMjo1NToxMFBNIC0wMjAwLCBHdXN0YXZvIFBhZG92YW4gd3JvdGU6Cj4g
PiBGcm9tOiBHdXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFkb3ZhbkBjb2xsYWJvcmEuY28udWs+
Cj4gPiAKPiA+IFRoaXMgcGF0Y2ggc2VyaWVzIGRlLXN0YWdlIHRoZSBzeW5jIGZyYW1ld29yaywg
YW5kIGluIG9yZGVyIHRvIGFjY29tcGxpc2ggdGhhdAo+ID4gYSBidW5jaCBvZiBjbGVhbnVwcy9p
bXByb3ZlbWVudHMgb24gdGhlIHN5bmMgYW5kIGZlbmNlIHdlcmUgbWFkZS4KPiA+IAo+ID4gVGhl
IHN5bmMgZnJhbWV3b3JrIGNvbnRhaW5lZCBzb21lIGFic3RyYWN0aW9ucyBhcm91bmQgc3RydWN0
IGZlbmNlIGFuZCB0aG9zZQo+ID4gd2VyZSByZW1vdmVkIGluIHRoZSBkZS1zdGFnaW5nIHByb2Nl
c3MgYW1vbmcgb3RoZXIgY2hhbmdlczoKPiA+IAo+ID4gVXNlcnNwYWNlIHZpc2libGUgY2hhbmdl
cwo+ID4gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gCj4gPiAgKiBUaGUgc3dfc3luYyBm
aWxlIHdhcyBtb3ZlZCBmcm9tIC9kZXYvc3dfc3luYyB0byA8ZGVidWdmcz4vc3luYy9zd19zeW5j
LiBObwo+ID4gIG90aGVyIGNoYW5nZS4KPiA+IAo+ID4gS2VybmVsIEFQSSBjaGFuZ2VzCj4gPiAt
LS0tLS0tLS0tLS0tLS0tLS0KPiA+IAo+ID4gICogc3RydWN0IHN5bmNfdGltZWxpbmUgaXMgbm93
IHN0cnVjdCBmZW5jZV90aW1lbGluZQo+ID4gICogc3luY190aW1lbGluZV9vcHMgaXMgbm93IGZl
bmNlX3RpbWVsaW5lX29wcyBhbmQgdGhleSBub3cgY2Fycnkgc3RydWN0Cj4gPiAgZmVuY2UgYXMg
cGFyYW1ldGVyIGluc3RlYWQgb2Ygc3RydWN0IHN5bmNfcHQKPiA+ICAqIGEgLmNsZWFudXAoKSBm
ZW5jZSBvcCB3YXMgYWRkZWQgdG8gYWxsb3cgc3luY19mZW5jZSB0byBydW4gYSBjbGVhbnVwIHdo
ZW4KPiA+ICB0aGUgZmVuY2VfdGltZWxpbmUgaXMgZGVzdHJveWVkCj4gPiAgKiBhZGRlZCBmZW5j
ZV9hZGRfdXNlZF9kYXRhKCkgdG8gcGFzcyBhIHByaXZhdGUgcG9pbnQgdG8gc3RydWN0IGZlbmNl
LiBUaGlzCj4gPiAgcG9pbnRlciBpcyBzZW50IGJhY2sgb24gdGhlIC5jbGVhbnVwIG9wLgo+ID4g
ICogVGhlIHN5bmMgdGltZWxpbmUgZnVuY3Rpb24gd2VyZSBtb3ZlZCB0byBiZSBmZW5jZV90aW1l
bGluZSBmdW5jdGlvbnM6Cj4gPiAJIC0gc3luY190aW1lbGluZV9jcmVhdGUoKQktPiBmZW5jZV90
aW1lbGluZV9jcmVhdGUoKQo+ID4gCSAtIHN5bmNfdGltZWxpbmVfZ2V0KCkJCS0+IGZlbmNlX3Rp
bWVsaW5lX2dldCgpCj4gPiAJIC0gc3luY190aW1lbGluZV9wdXQoKQkJLT4gZmVuY2VfdGltZWxp
bmVfcHV0KCkKPiA+IAkgLSBzeW5jX3RpbWVsaW5lX2Rlc3Ryb3koKQktPiBmZW5jZV90aW1lbGlu
ZV9kZXN0cm95KCkKPiA+IAkgLSBzeW5jX3RpbWVsaW5lX3NpZ25hbCgpCS0+IGZlbmNlX3RpbWVs
aW5lX3NpZ25hbCgpCj4gPiAKPiA+ICAgKiBzeW5jX3B0X2NyZWF0ZSgpIHdhcyByZXBsYWNlZCBi
ZSBmZW5jZV9jcmVhdGVfb25fdGltZWxpbmUoKQo+ID4gCj4gPiBJbnRlcm5hbCBjaGFuZ2VzCj4g
PiAtLS0tLS0tLS0tLS0tLS0tCj4gPiAKPiA+ICAqIGZlbmNlX3RpbWVsaW5lX29wcyB3YXMgcmVt
b3ZlZCBpbiBmYXZvciBvZiBkaXJlY3QgdXNlIGZlbmNlX29wcwo+ID4gICogZmVuY2UgZGVmYXVs
dCBmdW5jdGlvbnMgd2VyZSBjcmVhdGVkIGZvciBmZW5jZV9vcHMKPiA+ICAqIHJlbW92ZWQgc3Ry
dWN0cyBzeW5jX3B0LCBzd19zeW5jX3RpbWVsaW5lIGFuZCBzd19zeW5jX3B0Cj4gCj4gQnVuY2gg
b2YgZmFpcmx5IHJhbmRvbSBjb21tZW50cyBhbGwgb3ZlcjoKPiAKPiAtIGluY2x1ZGUvdWFwaS9s
aW51eC9zd19zeW5jLmggaW1vIHNob3VsZCBiZSBkcm9wcGVkLCBpdCdzIGp1c3QgYSBwcml2YXRl
Cj4gICBkZWJ1Z2ZzIGludGVyZmFjZSBiZXR3ZWVuIGZlbmNlIGZkcyBhbmQgdGhlIHRlc3RzdWl0
ZS4gU2luY2UgdGhlIHBsYW4gaXMKPiAgIHRvIGhhdmUgdGhlIHRlc3RjYXNlcyBpbnRlZ3JhdGVk
IGludG8gdGhlIGtlcm5lbCB0cmVlIHRvbyB3ZSBkb24ndCBuZWVkCj4gICBhIHB1YmxpYyBoZWFk
ZXIuCj4gCj4gLSBzaW1pbGFyIGZvciBpbmNsdWRlL2xpbnV4L3N3X3N5bmMuaCBJbW8gdGhhdCBz
aG91bGQgYWxsIGJlIG1vdmVkIGludG8KPiAgIHN5bmNfZGVidWcuYy4gU2FtZSBmb3Igc3dfc3lu
Yy5jLCB0aGF0IHNob3VsZCBhbGwgbGFuZCBpbiBzeW5jX2RlYnVnCj4gICBpbW8sIGFuZCBtYWRl
IG9wdGlvbmFsIHdpdGggYSBLY29uZmlnIG9wdGlvbi4gQXQgbGVhc3Qgd2Ugc2hvdWxkIHJldXNl
Cj4gICBDT05GSUdfREVCVUdGUy4KPiAKPiAtIGZlbmNlX2NvbnRleHQgYW5kIGZlbmNlX3RpbWVs
aW5lIGFyZSByZWFsbHkgdGhlIHNhbWUuIHRpbWVsaW5lIGhhcyBzb21lCj4gICBzdXBlci1iYXNp
YyBzdXBwb3J0IGZvciBkb2luZyBzdy1vbmx5IGZlbmNlIHRpbWVsaW5lcywgYnV0IGltbyB0aGF0
J3MKPiAgIG5vdCByZWFsbHkgd29ydGgga2VlcGluZyAoYW5kIGlmIHNvIGJldHRlciB0byBrZWVw
IHNlcGVyYXRlIGluIGEKPiAgIHN3LWZlbmNlLmMgb3Igc2ltaWxhciwgbGlrZSBzZXFuby1mZW5j
ZS5jKS4gVGhlIG90aGVyIG1haW4gdGhpbmcKPiAgIHRpbWVsaW5lIHByb3ZpZGVzIGlzIHN1cHBv
cnQgdG8gY2xlYW4gdXAgZmVuY2VzIG9uIGEgdGltZWxpbmUuIEFuZCBpbW8KPiAgIHRoYXQgY2xl
YW51cCBzaG91bGQgYmUgZG9uZSBieSB0aGUgY29yZSBmZW5jZSBzdXBwb3J0LCBub3QgYnkgdGhl
IGFkZC1vbgo+ICAgc3R1ZmYuCj4gCj4gSW50ZXJsdWRlIGFib3V0IGZlbmNlIGNsZWFudXAgb24g
ZHJpdmVyIHVubG9hZDoKPiAKPiBXb3JraW5nIGRyaXZlcnMgaW1vIHNob3VsZCBuZXZlciBjYWxs
IHRpbWVsaW5lX2Rlc3Ryb3kgd2hlbiB0aGVyZSdzIHN0aWxsCj4gYW4gdW5zaWduYWxsZWQgZmVu
Y2UgYXJvdW5kIGZvciB0aGF0IHRpbWVsaW5lL2NvbnRleHQuIFRoYXQganVzdCBtZWFucwo+IHRo
ZXkncmUgYnJva2VuIGFuZCBmYWlsZWQgdG8gY2xlYW4gdXAgYWxsIHRoZSBwZW5kaW5nIHdvcmsu
IFNvIHRoZSBwcm9ibGVtCj4gcmVhbGx5IGlzIG9ubHkgd2hhdCB0byBkbyB3aXRoIGZlbmNlcyB3
aGVyZSB0aGUgZHJpdmVyIGRpc2FwcGVhcmVkLCBhbmQKPiBmb3IgdGhhdCB3ZSBlc3NlbnRpYWxs
eSBuZWVkIGEgZmVuY2VfcmV2b2tlKCkgZnVuY3Rpb24gKHdoaWNoIGNvdWxkIGJlCj4gY2FsbGVk
IGludGVybmFsbHkgZnJvbSB0aW1lbGluZV9mcmVlKS4gU28gaGVyZSdzIHdoYXQgSSB0aGluawo+
IHRpbWVsaW5lX2ZyZWUgc2hvdWxkIGRvOgo+IAo+IGZvcl9lYWNoX2ZlbmNlX29uX3RpbWVsKCkg
ewo+IAlXQVJOX09OKCFmZW5jZV9pc19zaWduYWxsZWQoKSk7Cj4gCj4gCWZlbmNlX3Jldm9rZShm
ZW5jZSk7Cj4gfQo+IAo+IEltcGxlbWVudGluZyBmZW5jZV9yZXZva2UgaXMgYSBiaXQgdHJpY2t5
IHNpbmNlIHdlIG5lZWQgdG8gbWFrZSBzdXJlIHRoZQo+IG1lbW9yeSBjb250YWluZWQgLT5vcHMg
YW5kIHNpbWlsYXIgc3R1ZmYgZG9lc24ndCBkaXNhcHBlYXIuIFNpbXBsZXN0Cj4gb3B0aW9uIG1p
Z2h0IGJlIHRvIGdyYWIgYSB0ZW1wb3JhcnkgcmVmZXJlbmNlICh1c2luZwo+IGtyZWZfZ2V0X3Vu
bGVzc196ZXJvKSwgYW5kIHRoZW4gZXhjaGFuZ2UgLT5vcHMgd2l0aCBvbmUgdGhhdCBoYXMgb25s
eSBhCj4gcmVsZWFzZSBmdW5jdGlvbi4gV2UgZG9uJ3QgbmVlZCBhbnl0aGluZyBlbHNlIGFzIGxv
bmcgYXMgYWxsIGZlbmNlXyoKPiBmdW5jdGlvbnMgdGhlIGtlcm5lbCBtaWdodCBjYWxsIGNoZWNr
IGZvciBzaWduYWxsaW5nIGNvcnJlY3RseSBmaXJzdAo+IChmZW5jZV93YWl0IGlzIGJyb2tlbiBh
dCBsZWFzdCkuCj4gCj4gT3Igd2UganVzdCBnaXZlIHVwIChmb3Igbm93KSBhbmQgZGVjbGFyZSBt
b2R1bGUgdW5sb2FkIGFzIHNsaWdodGx5IHJhY3kuCj4gZG1hLWJ1ZiBpcyBzaW1pbGFyLiBBbiBp
bnRlcm1lZGlhdGUgb3B0aW9uIG1pZ2h0IGJlIHRvIGF0IGxlYXN0IGFkZCBhCj4gVEhJU19NT0RV
TEUgcmVmZXJlbmNlIHRvIGVhY2ggZmVuY2UgKGJ1dCB0aGF0J3MgYSBiaXQgZXhwZW5zaXZlIC4u
LikuCj4gCj4gLSBiYWNrIHRvIHRpbWVsaW5lIHZzLiBjb250ZXh0OiBJIGhhdmUgbm8gaWRlYSBo
b3cgdG8gYmVzdCBjbGVhbiB1cCB0aGlzCj4gICBtZXNzLCBidXQgbGVhc3QgcGFpbmZ1bCBvcHRp
b24gbG9uZy10ZXJtIGlzIHByb2JhYmx5IHRvIHN3aXRjaCBvdmVyIGFsbAo+ICAgY3VycmVudCB1
c2VycyBvZiBmZW5jZV9jb250ZXh0X2FsbG9jIHRvIHRpbWVsaW5lcyBhbmQgcmVtb3ZlIHRoZSBw
bGFpbgo+ICAgY29udGV4dCBpbnRlcmZhY2UuCj4gCj4gLSBJbW8gdGhlIGludGVyZmFjZSBpbiBp
bmNsdWRlL2xpbnV4L3N5bmMuaCBpcyBkdXBsaWNhdGluZyB0b28gbXVjaCBvZgo+ICAgZmVuY2Uu
aC4gSSB0aGluayB0aGUgb25seSBiaXRzIHdlIG5lZWQgYXJlIHRoZSByZWZjb3VudGluZywgY3Jl
YXRpbmcsCj4gICBmZC1pbnN0YWxsIGFuZCB0aGF0J3MgaXQuIFBsdXMgYSBtYWNybyB0byBsb29w
IG92ZXIgYWxsIHRoZSBmZW5jZXMgaW4gYQo+ICAgc3luY19mZW5jZS4gV2l0aCB0aGF0IGRyaXZl
cnMgd2lsbCBvbmx5IGV2ZXIgZGVhbCB3aXRoIGEgcGlsZSBvZgo+ICAgc3RydWN0IGZlbmNlLCBt
YWtpbmcgaW1wbGljaXQgZmVuY2luZyAodXNpbmcgdGhlIGZlbmNlIGxpc3QgaW4gZG1hLWJ1ZikK
PiAgIGFuZCBleHBsaWNpdCBmZW5jaW5nICh1c2luZyB0aGUgZmVuY2UgbGlzdCBpbiBzeW5jX2Zl
bmNlKSBtdWNoIG1vcmUKPiAgIHNpbWlsYXIuCj4gCj4gICBBbmQgd2UgY2FuIGVhc2lseSBkbyB0
aGF0IHNpbmNlIG5vIGludGVybmFsIHVzZXJzIDstKQo+IAo+IC0gZ2V0X3RpbWVsaW5lX25hbWUg
YW5kIGdldF9kcml2ZXJfbmFtZSBhcmUgaW1vIHRvbyBtdWNoIGluZGlyZWN0aW9uLCBqdXN0Cj4g
ICBhZGQgLT4oZHJ2XyluYW1lIGZpZWxkIHRvIGVhY2ggb2YgdGhlc2UuCgpJIGRvbid0IHRoaW5r
IGlzIGEgZ29vZCBpZGVhIHRvIGNoYW5nZSB0aGF0IG5vdyBhcyB0aGVyZSBhcmUgb3RoZXIgZmVu
Y2UKdXNlcnMgaW4gdGhlIGtlcm5lbCB1c2luZyBnZXRfdGltZWxpbmVfbmFtZSBhbmQgZ2V0X2Ry
aXZlcl9uYW1lLiBXaGF0IEkKcHJvcG9zZSBpcyB0cnkgZ2V0IHJpZCBvZiB0aGlzIHdoZW4gbW92
aW5nIG9wcyBmcm9tIGZlbmNlcyB0bwpmZW5jZV90aW1lbGluZS4KCglHdXN0YXZvCl9fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n
IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRl
c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==