From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933306AbcASWMS (ORCPT ); Tue, 19 Jan 2016 17:12:18 -0500 Received: from one.firstfloor.org ([193.170.194.197]:39030 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932252AbcASWMG (ORCPT ); Tue, 19 Jan 2016 17:12:06 -0500 Date: Tue, 19 Jan 2016 23:12:04 +0100 From: Andi Kleen To: Namhyung Kim Cc: Andi Kleen , Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Stephane Eranian , Wang Nan , Don Zickus , Pekka Enberg , Moinuddin Quadri Subject: Re: [RFC/PATCHSET 00/17] perf tools: Add support for hierachy view (v2) Message-ID: <20160119221204.GO4698@two.firstfloor.org> References: <1452960197-5323-1-git-send-email-namhyung@kernel.org> <20160117193153.GI4698@two.firstfloor.org> <20160119104506.GB1324@danjae.kornet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160119104506.GB1324@danjae.kornet> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Now we only need a better percent-limit that handles all > > leaves correctly... > > Hmm.. could you tell me where the percent-limit doesn't work > correctly? It doesn't work well together with call chains. It only considers the hits on the leaf function, but doesn't hide the individual call chains leading to that function which are below the limit. So if you have a lot of different cold callers you still end up with far too much output. Also would be nice to be able to set it dynamically from the UI. -Andi -- ak@linux.intel.com -- Speaking for myself only.