From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933463AbcATN2G (ORCPT ); Wed, 20 Jan 2016 08:28:06 -0500 Received: from foss.arm.com ([217.140.101.70]:45465 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932347AbcATN2B (ORCPT ); Wed, 20 Jan 2016 08:28:01 -0500 Date: Wed, 20 Jan 2016 13:27:35 +0000 From: Mark Rutland To: Chris Metcalf Cc: Ingo Molnar , Will Deacon , Gilad Ben Yossef , Steven Rostedt , Peter Zijlstra , Andrew Morton , Rik van Riel , Tejun Heo , Frederic Weisbecker , Thomas Gleixner , "Paul E. McKenney" , Christoph Lameter , Viresh Kumar , Catalin Marinas , Andy Lutomirski , Daniel Lezcano , linux-doc@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 00/13] support "task_isolation" mode for nohz_full Message-ID: <20160120132734.GF25829@leverpostej> References: <1451936091-29247-1-git-send-email-cmetcalf@ezchip.com> <56941B86.9090009@ezchip.com> <20160112100708.GA15737@arm.com> <56953CBA.9090208@ezchip.com> <20160113104453.GB9854@gmail.com> <5696BF7C.2080800@ezchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5696BF7C.2080800@ezchip.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chris, Sorry for the delay. I had intended to take a look at this and so held off replying, but my time has been taken up elsewhere. On Wed, Jan 13, 2016 at 04:19:56PM -0500, Chris Metcalf wrote: > On 01/13/2016 05:44 AM, Ingo Molnar wrote: > >* Chris Metcalf wrote: > > > >>(Adding Mark to cc's) > >> > >>On 01/12/2016 05:07 AM, Will Deacon wrote: > >>>On Mon, Jan 11, 2016 at 04:15:50PM -0500, Chris Metcalf wrote: > >>>>Ping! There has been no substantive feedback to this version of > >>>>the patch in the week since I posted it, which optimistically suggests > >>>>to me that people may be satisfied with it. If that's true, Frederic, > >>>>I assume this would be pulled into your tree? > >>>> > >>>>I have slightly updated the v9 patch series since this posting: > >>>> > >>>>[...] > >>>> > >>>>- Incorporated Mark Rutland's changes to convert arm64 > >>>> assembly to C code instead of using my own version. > >>>Please avoid queuing these patches -- the first is already in the arm64 > >>>queue for 4.5 and the second was found to introduce a substantial > >>>performance regression on the syscall entry/exit path. I think Mark had > >>>an updated version to address that, so it would be easier not to have > >>>an old version sitting in some other queue! > >>I am not formally queueing them anywhere (like linux-next), though > >>now that you mention it, that's a pretty good idea - I'll talk to Steven > >>about that, assuming this merge window closes without the task > >>isolation stuff going in. > >NAK. Given the controversy, no way should this stuff go outside the primary trees > >it affects: the scheduler, timer, irq, etc. trees. > > Fair enough. I'll plan to do v10 once the merge window closes. > > Mark, let me know when/if you get a new version of the de-asm stuff > for do_notify_resume() - thanks. If I get the chance soon, I will do, though I suspect I won't have the chance to give that the time it deserves over the next week or two. > Or, would it be helpful if I worked up the option I suggested, where > we check the thread_info flags in the assembly code before calling out > to the new loop in do_notify_resume()? That would probably be for the best. Thanks, Mark.