[PATCH] drm/i915: Limit the auto arming of mmio debugs on vlv/chv

[PATCH] drm/i915: Limit the auto arming of mmio debugs on vlv/chv

[Mika Kuoppala]

The capability to detect unclaimed register access was
recently introduced for vlv/chv platforms. Apparently
there are plenty of unclaimed access on these platforms,
resulting in new dmesg warns. But as we are trying to form
a beachhead for CI/Bat, all new warns are adding to the
noise and thus not desirable at this point in time.

Make it so that if in these platforms the automatic arming
was responsible for mmio_debug enabling, ignore the warns.

If user/dev wants to fix these, he can still do so by
i915.mmio_debug=1234.

Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
---
 drivers/gpu/drm/i915/intel_uncore.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
index c3c13dc929cb..bfa79e5c214e 100644
--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -631,6 +631,15 @@ __unclaimed_reg_debug(struct drm_i915_private *dev_priv,
 		      const bool read,
 		      const bool before)
 {
+	/* XXX. We limit the auto arming traces for mmio
+	 * debugs on these platforms. There are just too many
+	 * revealed by these and CI/Bat suffers from the noise.
+	 * Please fix and then re-enable the automatic traces.
+	 */
+	if (i915.mmio_debug < 2 &&
+	    (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)))
+		return;
+
 	if (WARN(check_for_unclaimed_mmio(dev_priv),
 		 "Unclaimed register detected %s %s register 0x%x\n",
 		 before ? "before" : "after",
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Limit the auto arming of mmio debugs on vlv/chv

[Daniel Vetter]

On Wed, Jan 20, 2016 at 12:32:23PM +0200, Mika Kuoppala wrote:
> The capability to detect unclaimed register access was
> recently introduced for vlv/chv platforms. Apparently
> there are plenty of unclaimed access on these platforms,
> resulting in new dmesg warns. But as we are trying to form
> a beachhead for CI/Bat, all new warns are adding to the
> noise and thus not desirable at this point in time.
> 
> Make it so that if in these platforms the automatic arming
> was responsible for mmio_debug enabling, ignore the warns.
> 
> If user/dev wants to fix these, he can still do so by
> i915.mmio_debug=1234.
> 
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>

Yeah it sucks, but otoh this will make CI more useful for everyone else
and we can keep the original test coverage even.

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> ---
>  drivers/gpu/drm/i915/intel_uncore.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index c3c13dc929cb..bfa79e5c214e 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -631,6 +631,15 @@ __unclaimed_reg_debug(struct drm_i915_private *dev_priv,
>  		      const bool read,
>  		      const bool before)
>  {
> +	/* XXX. We limit the auto arming traces for mmio
> +	 * debugs on these platforms. There are just too many
> +	 * revealed by these and CI/Bat suffers from the noise.
> +	 * Please fix and then re-enable the automatic traces.
> +	 */
> +	if (i915.mmio_debug < 2 &&
> +	    (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)))
> +		return;
> +
>  	if (WARN(check_for_unclaimed_mmio(dev_priv),
>  		 "Unclaimed register detected %s %s register 0x%x\n",
>  		 before ? "before" : "after",
> -- 
> 2.5.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915: Limit the auto arming of mmio debugs on vlv/chv

[Patchwork]

== Summary ==

Built on a84f26193f3fd63600b2f4c280c0046e4a191322 drm-intel-nightly: 2016y-01m-20d-12h-56m-53s UTC integration manifest

Test gem_storedw_loop:
        Subgroup basic-render:
                pass       -> DMESG-WARN (skl-i5k-2) UNSTABLE
                dmesg-warn -> PASS       (skl-i7k-2) UNSTABLE
Test gem_sync:
        Subgroup basic-render:
                dmesg-fail -> PASS       (bdw-nuci7) UNSTABLE
Test kms_flip:
        Subgroup basic-flip-vs-wf_vblank:
                dmesg-warn -> PASS       (byt-nuc)
Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-a:
                skip       -> PASS       (byt-nuc)
        Subgroup nonblocking-crc-pipe-b:
                dmesg-warn -> PASS       (byt-nuc)
        Subgroup nonblocking-crc-pipe-c:
                dmesg-warn -> PASS       (bsw-nuc-2)
        Subgroup read-crc-pipe-a-frame-sequence:
                dmesg-warn -> PASS       (byt-nuc)
        Subgroup read-crc-pipe-c-frame-sequence:
                dmesg-warn -> PASS       (bsw-nuc-2)

bdw-nuci7        total:143  pass:134  dwarn:0   dfail:0   fail:0   skip:9  
bdw-ultra        total:140  pass:132  dwarn:1   dfail:1   fail:0   skip:6  
bsw-nuc-2        total:143  pass:119  dwarn:0   dfail:0   fail:0   skip:24 
byt-nuc          total:143  pass:127  dwarn:1   dfail:0   fail:0   skip:15 
hsw-brixbox      total:143  pass:136  dwarn:0   dfail:0   fail:0   skip:7  
hsw-gt2          total:143  pass:139  dwarn:0   dfail:0   fail:0   skip:4  
ilk-hp8440p      total:143  pass:103  dwarn:2   dfail:0   fail:0   skip:38 
ivb-t430s        total:143  pass:137  dwarn:0   dfail:0   fail:0   skip:6  
skl-i5k-2        total:143  pass:133  dwarn:2   dfail:0   fail:0   skip:8  
skl-i7k-2        total:143  pass:134  dwarn:1   dfail:0   fail:0   skip:8  
snb-dellxps      total:143  pass:129  dwarn:0   dfail:0   fail:0   skip:14 
snb-x220t        total:143  pass:129  dwarn:0   dfail:0   fail:1   skip:13 

Results at /archive/results/CI_IGT_test/Patchwork_1231/

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Limit the auto arming of mmio debugs on vlv/chv

[Mika Kuoppala]

Daniel Vetter <daniel@ffwll.ch> writes:

> On Wed, Jan 20, 2016 at 12:32:23PM +0200, Mika Kuoppala wrote:
>> The capability to detect unclaimed register access was
>> recently introduced for vlv/chv platforms. Apparently
>> there are plenty of unclaimed access on these platforms,
>> resulting in new dmesg warns. But as we are trying to form
>> a beachhead for CI/Bat, all new warns are adding to the
>> noise and thus not desirable at this point in time.
>> 
>> Make it so that if in these platforms the automatic arming
>> was responsible for mmio_debug enabling, ignore the warns.
>> 
>> If user/dev wants to fix these, he can still do so by
>> i915.mmio_debug=1234.
>> 
>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>
> Yeah it sucks, but otoh this will make CI more useful for everyone else
> and we can keep the original test coverage even.
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Applied to dinq. Thanks for review.

-Mika

>
>> ---
>>  drivers/gpu/drm/i915/intel_uncore.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
>> index c3c13dc929cb..bfa79e5c214e 100644
>> --- a/drivers/gpu/drm/i915/intel_uncore.c
>> +++ b/drivers/gpu/drm/i915/intel_uncore.c
>> @@ -631,6 +631,15 @@ __unclaimed_reg_debug(struct drm_i915_private *dev_priv,
>>  		      const bool read,
>>  		      const bool before)
>>  {
>> +	/* XXX. We limit the auto arming traces for mmio
>> +	 * debugs on these platforms. There are just too many
>> +	 * revealed by these and CI/Bat suffers from the noise.
>> +	 * Please fix and then re-enable the automatic traces.
>> +	 */
>> +	if (i915.mmio_debug < 2 &&
>> +	    (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)))
>> +		return;
>> +
>>  	if (WARN(check_for_unclaimed_mmio(dev_priv),
>>  		 "Unclaimed register detected %s %s register 0x%x\n",
>>  		 before ? "before" : "after",
>> -- 
>> 2.5.0
>> 
>
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx