From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934148AbcATOc5 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 20 Jan 2016 09:32:57 -0500
Received: from mail-yk0-f174.google.com ([209.85.160.174]:36453 "EHLO
	mail-yk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751367AbcATOcz (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 20 Jan 2016 09:32:55 -0500
Date: Wed, 20 Jan 2016 12:32:50 -0200
From: Gustavo Padovan <gustavo@padovan.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, daniels@collabora.com,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Riley Andrews <riandrews@android.com>, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org,
        Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
        John Harrison <John.C.Harrison@Intel.com>
Subject: Re: [RFC 00/29] De-stage android's sync framework
Message-ID: <20160120143250.GF8217@joana>
Mail-Followup-To: Gustavo Padovan <gustavo@padovan.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, daniels@collabora.com,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Riley Andrews <riandrews@android.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
	John Harrison <John.C.Harrison@Intel.com>
References: <1452869739-3304-1-git-send-email-gustavo@padovan.org>
 <569F614A.1070807@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <569F614A.1070807@linux.intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2016-01-20 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>:

> Hey,
> 
> Op 15-01-16 om 15:55 schreef Gustavo Padovan:
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >
> > This patch series de-stage the sync framework, and in order to accomplish that
> > a bunch of cleanups/improvements on the sync and fence were made.
> >
> > The sync framework contained some abstractions around struct fence and those
> > were removed in the de-staging process among other changes:
> >
> > Userspace visible changes
> > -------------------------
> >
> >  * The sw_sync file was moved from /dev/sw_sync to <debugfs>/sync/sw_sync. No
> >  other change.
> >
> > Kernel API changes
> > ------------------
> >
> >  * struct sync_timeline is now struct fence_timeline
> >  * sync_timeline_ops is now fence_timeline_ops and they now carry struct
> >  fence as parameter instead of struct sync_pt
> >  * a .cleanup() fence op was added to allow sync_fence to run a cleanup when
> >  the fence_timeline is destroyed
> >  * added fence_add_used_data() to pass a private point to struct fence. This
> >  pointer is sent back on the .cleanup op.
> >  * The sync timeline function were moved to be fence_timeline functions:
> > 	 - sync_timeline_create()	-> fence_timeline_create()
> > 	 - sync_timeline_get()		-> fence_timeline_get()
> > 	 - sync_timeline_put()		-> fence_timeline_put()
> > 	 - sync_timeline_destroy()	-> fence_timeline_destroy()
> > 	 - sync_timeline_signal()	-> fence_timeline_signal()
> >
> >   * sync_pt_create() was replaced be fence_create_on_timeline()
> >
> > Internal changes
> > ----------------
> >
> >  * fence_timeline_ops was removed in favor of direct use fence_ops
> >  * fence default functions were created for fence_ops
> >  * removed structs sync_pt, sw_sync_timeline and sw_sync_pt
> >
> > Gustavo Padovan (29):
> >   staging/android: fix sync framework documentation
> >   staging/android: fix checkpatch warning
> >   staging/android: rename sync_fence_release
> >   staging/android: rename 'android_fence' to 'sync_fence'
> >   staging/android: remove not used sync_timeline ops
> >   staging/android: create a 'sync' dir for debugfs information
> >   staging/android: move sw_sync file to debugfs file
> >   staging/android: Remove WARN_ON_ONCE when releasing sync_fence
> >   staging/android: rename struct sync_fence's variables to 'sync_fence'
> >   staging/android: rename 'sync_pt' to 'fence' in struct sync_fence_cb
> >   dma-buf/fence: move sync_timeline to fence_timeline
> >   staging/android: remove struct sync_pt
> >   dma-buf/fence: create fence_default_enable_signaling()
> >   dma-buf/fence: create fence_default_release()
> >   dma-buf/fence: create fence_default_get_driver_name()
> >   dma-buf/fence: create fence_default_timeline_name()
> This is misleading. I think timeline_fence prefix would be more appropriate here.

Why? These fence_default_.. functions are fence_ops and not related to
fence_timeline in any way.

> 
> I also believe this should be done in multiple series. First series should de-stage the userspace fence framework. The next series should fix up android_fence and maybe rename it to timeline_fence since sync_fence is already used for the userspace fd, which would add more confusion?

Sure. I've been thinking on how to split this properly. I'm trying to
add a bunch of clean up/renaming first, eg the sync_fence rename to
sync_file that Daniel Vetter and I discussed. 

Next my plan would be move sync_timeline to fence_timeline, add the
fence_default.. fence_ops, clean up sw_sync and finally merge
fence_context and fence_timeline.

Looking at how sync and fence It looks easier to me to de-stage sync_timeline first than userspace
fence.

	Gustavo

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gustavo Padovan <gustavo@padovan.org>
Subject: Re: [RFC 00/29] De-stage android's sync framework
Date: Wed, 20 Jan 2016 12:32:50 -0200
Message-ID: <20160120143250.GF8217@joana>
References: <1452869739-3304-1-git-send-email-gustavo@padovan.org>
 <569F614A.1070807@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-yk0-f172.google.com (mail-yk0-f172.google.com
 [209.85.160.172])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 7BC426E954
 for <dri-devel@lists.freedesktop.org>; Wed, 20 Jan 2016 06:32:55 -0800 (PST)
Received: by mail-yk0-f172.google.com with SMTP id v14so11157979ykd.3
 for <dri-devel@lists.freedesktop.org>; Wed, 20 Jan 2016 06:32:55 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <569F614A.1070807@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: devel@driverdev.osuosl.org, daniels@collabora.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Riley Andrews <riandrews@android.com>, Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, Gustavo Padovan <gustavo.padovan@collabora.co.uk>, John Harrison <John.C.Harrison@Intel.com>
List-Id: dri-devel@lists.freedesktop.org

MjAxNi0wMS0yMCBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50
ZWwuY29tPjoKCj4gSGV5LAo+IAo+IE9wIDE1LTAxLTE2IG9tIDE1OjU1IHNjaHJlZWYgR3VzdGF2
byBQYWRvdmFuOgo+ID4gRnJvbTogR3VzdGF2byBQYWRvdmFuIDxndXN0YXZvLnBhZG92YW5AY29s
bGFib3JhLmNvLnVrPgo+ID4KPiA+IFRoaXMgcGF0Y2ggc2VyaWVzIGRlLXN0YWdlIHRoZSBzeW5j
IGZyYW1ld29yaywgYW5kIGluIG9yZGVyIHRvIGFjY29tcGxpc2ggdGhhdAo+ID4gYSBidW5jaCBv
ZiBjbGVhbnVwcy9pbXByb3ZlbWVudHMgb24gdGhlIHN5bmMgYW5kIGZlbmNlIHdlcmUgbWFkZS4K
PiA+Cj4gPiBUaGUgc3luYyBmcmFtZXdvcmsgY29udGFpbmVkIHNvbWUgYWJzdHJhY3Rpb25zIGFy
b3VuZCBzdHJ1Y3QgZmVuY2UgYW5kIHRob3NlCj4gPiB3ZXJlIHJlbW92ZWQgaW4gdGhlIGRlLXN0
YWdpbmcgcHJvY2VzcyBhbW9uZyBvdGhlciBjaGFuZ2VzOgo+ID4KPiA+IFVzZXJzcGFjZSB2aXNp
YmxlIGNoYW5nZXMKPiA+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+Cj4gPiAgKiBUaGUg
c3dfc3luYyBmaWxlIHdhcyBtb3ZlZCBmcm9tIC9kZXYvc3dfc3luYyB0byA8ZGVidWdmcz4vc3lu
Yy9zd19zeW5jLiBObwo+ID4gIG90aGVyIGNoYW5nZS4KPiA+Cj4gPiBLZXJuZWwgQVBJIGNoYW5n
ZXMKPiA+IC0tLS0tLS0tLS0tLS0tLS0tLQo+ID4KPiA+ICAqIHN0cnVjdCBzeW5jX3RpbWVsaW5l
IGlzIG5vdyBzdHJ1Y3QgZmVuY2VfdGltZWxpbmUKPiA+ICAqIHN5bmNfdGltZWxpbmVfb3BzIGlz
IG5vdyBmZW5jZV90aW1lbGluZV9vcHMgYW5kIHRoZXkgbm93IGNhcnJ5IHN0cnVjdAo+ID4gIGZl
bmNlIGFzIHBhcmFtZXRlciBpbnN0ZWFkIG9mIHN0cnVjdCBzeW5jX3B0Cj4gPiAgKiBhIC5jbGVh
bnVwKCkgZmVuY2Ugb3Agd2FzIGFkZGVkIHRvIGFsbG93IHN5bmNfZmVuY2UgdG8gcnVuIGEgY2xl
YW51cCB3aGVuCj4gPiAgdGhlIGZlbmNlX3RpbWVsaW5lIGlzIGRlc3Ryb3llZAo+ID4gICogYWRk
ZWQgZmVuY2VfYWRkX3VzZWRfZGF0YSgpIHRvIHBhc3MgYSBwcml2YXRlIHBvaW50IHRvIHN0cnVj
dCBmZW5jZS4gVGhpcwo+ID4gIHBvaW50ZXIgaXMgc2VudCBiYWNrIG9uIHRoZSAuY2xlYW51cCBv
cC4KPiA+ICAqIFRoZSBzeW5jIHRpbWVsaW5lIGZ1bmN0aW9uIHdlcmUgbW92ZWQgdG8gYmUgZmVu
Y2VfdGltZWxpbmUgZnVuY3Rpb25zOgo+ID4gCSAtIHN5bmNfdGltZWxpbmVfY3JlYXRlKCkJLT4g
ZmVuY2VfdGltZWxpbmVfY3JlYXRlKCkKPiA+IAkgLSBzeW5jX3RpbWVsaW5lX2dldCgpCQktPiBm
ZW5jZV90aW1lbGluZV9nZXQoKQo+ID4gCSAtIHN5bmNfdGltZWxpbmVfcHV0KCkJCS0+IGZlbmNl
X3RpbWVsaW5lX3B1dCgpCj4gPiAJIC0gc3luY190aW1lbGluZV9kZXN0cm95KCkJLT4gZmVuY2Vf
dGltZWxpbmVfZGVzdHJveSgpCj4gPiAJIC0gc3luY190aW1lbGluZV9zaWduYWwoKQktPiBmZW5j
ZV90aW1lbGluZV9zaWduYWwoKQo+ID4KPiA+ICAgKiBzeW5jX3B0X2NyZWF0ZSgpIHdhcyByZXBs
YWNlZCBiZSBmZW5jZV9jcmVhdGVfb25fdGltZWxpbmUoKQo+ID4KPiA+IEludGVybmFsIGNoYW5n
ZXMKPiA+IC0tLS0tLS0tLS0tLS0tLS0KPiA+Cj4gPiAgKiBmZW5jZV90aW1lbGluZV9vcHMgd2Fz
IHJlbW92ZWQgaW4gZmF2b3Igb2YgZGlyZWN0IHVzZSBmZW5jZV9vcHMKPiA+ICAqIGZlbmNlIGRl
ZmF1bHQgZnVuY3Rpb25zIHdlcmUgY3JlYXRlZCBmb3IgZmVuY2Vfb3BzCj4gPiAgKiByZW1vdmVk
IHN0cnVjdHMgc3luY19wdCwgc3dfc3luY190aW1lbGluZSBhbmQgc3dfc3luY19wdAo+ID4KPiA+
IEd1c3Rhdm8gUGFkb3ZhbiAoMjkpOgo+ID4gICBzdGFnaW5nL2FuZHJvaWQ6IGZpeCBzeW5jIGZy
YW1ld29yayBkb2N1bWVudGF0aW9uCj4gPiAgIHN0YWdpbmcvYW5kcm9pZDogZml4IGNoZWNrcGF0
Y2ggd2FybmluZwo+ID4gICBzdGFnaW5nL2FuZHJvaWQ6IHJlbmFtZSBzeW5jX2ZlbmNlX3JlbGVh
c2UKPiA+ICAgc3RhZ2luZy9hbmRyb2lkOiByZW5hbWUgJ2FuZHJvaWRfZmVuY2UnIHRvICdzeW5j
X2ZlbmNlJwo+ID4gICBzdGFnaW5nL2FuZHJvaWQ6IHJlbW92ZSBub3QgdXNlZCBzeW5jX3RpbWVs
aW5lIG9wcwo+ID4gICBzdGFnaW5nL2FuZHJvaWQ6IGNyZWF0ZSBhICdzeW5jJyBkaXIgZm9yIGRl
YnVnZnMgaW5mb3JtYXRpb24KPiA+ICAgc3RhZ2luZy9hbmRyb2lkOiBtb3ZlIHN3X3N5bmMgZmls
ZSB0byBkZWJ1Z2ZzIGZpbGUKPiA+ICAgc3RhZ2luZy9hbmRyb2lkOiBSZW1vdmUgV0FSTl9PTl9P
TkNFIHdoZW4gcmVsZWFzaW5nIHN5bmNfZmVuY2UKPiA+ICAgc3RhZ2luZy9hbmRyb2lkOiByZW5h
bWUgc3RydWN0IHN5bmNfZmVuY2UncyB2YXJpYWJsZXMgdG8gJ3N5bmNfZmVuY2UnCj4gPiAgIHN0
YWdpbmcvYW5kcm9pZDogcmVuYW1lICdzeW5jX3B0JyB0byAnZmVuY2UnIGluIHN0cnVjdCBzeW5j
X2ZlbmNlX2NiCj4gPiAgIGRtYS1idWYvZmVuY2U6IG1vdmUgc3luY190aW1lbGluZSB0byBmZW5j
ZV90aW1lbGluZQo+ID4gICBzdGFnaW5nL2FuZHJvaWQ6IHJlbW92ZSBzdHJ1Y3Qgc3luY19wdAo+
ID4gICBkbWEtYnVmL2ZlbmNlOiBjcmVhdGUgZmVuY2VfZGVmYXVsdF9lbmFibGVfc2lnbmFsaW5n
KCkKPiA+ICAgZG1hLWJ1Zi9mZW5jZTogY3JlYXRlIGZlbmNlX2RlZmF1bHRfcmVsZWFzZSgpCj4g
PiAgIGRtYS1idWYvZmVuY2U6IGNyZWF0ZSBmZW5jZV9kZWZhdWx0X2dldF9kcml2ZXJfbmFtZSgp
Cj4gPiAgIGRtYS1idWYvZmVuY2U6IGNyZWF0ZSBmZW5jZV9kZWZhdWx0X3RpbWVsaW5lX25hbWUo
KQo+IFRoaXMgaXMgbWlzbGVhZGluZy4gSSB0aGluayB0aW1lbGluZV9mZW5jZSBwcmVmaXggd291
bGQgYmUgbW9yZSBhcHByb3ByaWF0ZSBoZXJlLgoKV2h5PyBUaGVzZSBmZW5jZV9kZWZhdWx0Xy4u
IGZ1bmN0aW9ucyBhcmUgZmVuY2Vfb3BzIGFuZCBub3QgcmVsYXRlZCB0bwpmZW5jZV90aW1lbGlu
ZSBpbiBhbnkgd2F5LgoKPiAKPiBJIGFsc28gYmVsaWV2ZSB0aGlzIHNob3VsZCBiZSBkb25lIGlu
IG11bHRpcGxlIHNlcmllcy4gRmlyc3Qgc2VyaWVzIHNob3VsZCBkZS1zdGFnZSB0aGUgdXNlcnNw
YWNlIGZlbmNlIGZyYW1ld29yay4gVGhlIG5leHQgc2VyaWVzIHNob3VsZCBmaXggdXAgYW5kcm9p
ZF9mZW5jZSBhbmQgbWF5YmUgcmVuYW1lIGl0IHRvIHRpbWVsaW5lX2ZlbmNlIHNpbmNlIHN5bmNf
ZmVuY2UgaXMgYWxyZWFkeSB1c2VkIGZvciB0aGUgdXNlcnNwYWNlIGZkLCB3aGljaCB3b3VsZCBh
ZGQgbW9yZSBjb25mdXNpb24/CgpTdXJlLiBJJ3ZlIGJlZW4gdGhpbmtpbmcgb24gaG93IHRvIHNw
bGl0IHRoaXMgcHJvcGVybHkuIEknbSB0cnlpbmcgdG8KYWRkIGEgYnVuY2ggb2YgY2xlYW4gdXAv
cmVuYW1pbmcgZmlyc3QsIGVnIHRoZSBzeW5jX2ZlbmNlIHJlbmFtZSB0bwpzeW5jX2ZpbGUgdGhh
dCBEYW5pZWwgVmV0dGVyIGFuZCBJIGRpc2N1c3NlZC4gCgpOZXh0IG15IHBsYW4gd291bGQgYmUg
bW92ZSBzeW5jX3RpbWVsaW5lIHRvIGZlbmNlX3RpbWVsaW5lLCBhZGQgdGhlCmZlbmNlX2RlZmF1
bHQuLiBmZW5jZV9vcHMsIGNsZWFuIHVwIHN3X3N5bmMgYW5kIGZpbmFsbHkgbWVyZ2UKZmVuY2Vf
Y29udGV4dCBhbmQgZmVuY2VfdGltZWxpbmUuCgpMb29raW5nIGF0IGhvdyBzeW5jIGFuZCBmZW5j
ZSBJdCBsb29rcyBlYXNpZXIgdG8gbWUgdG8gZGUtc3RhZ2Ugc3luY190aW1lbGluZSBmaXJzdCB0
aGFuIHVzZXJzcGFjZQpmZW5jZS4KCglHdXN0YXZvCl9fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp
c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v
bGlzdGluZm8vZHJpLWRldmVsCg==