From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757506AbcAUEIX (ORCPT ); Wed, 20 Jan 2016 23:08:23 -0500 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:40754 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752622AbcAUEIU (ORCPT ); Wed, 20 Jan 2016 23:08:20 -0500 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 165.244.98.203 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org Date: Thu, 21 Jan 2016 13:08:18 +0900 From: Namhyung Kim To: Jiri Olsa CC: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Stephane Eranian , Andi Kleen , Wang Nan Subject: Re: [PATCH 01/17] perf hists: Basic support of hierarchical report view Message-ID: <20160121040818.GD10179@sejong> References: <1452960197-5323-1-git-send-email-namhyung@kernel.org> <1452960197-5323-2-git-send-email-namhyung@kernel.org> <20160117161533.GC17618@krava.redhat.com> <20160119105118.GC1324@danjae.kornet> <20160119165047.GB27085@kernel.org> <20160120170059.GA26895@krava.brq.redhat.com> MIME-Version: 1.0 In-Reply-To: <20160120170059.GA26895@krava.brq.redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB08/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/01/21 13:08:18, Serialize by Router on LGEKRMHUB08/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/01/21 13:08:18, Serialize complete at 2016/01/21 13:08:18 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiri, On Wed, Jan 20, 2016 at 06:00:59PM +0100, Jiri Olsa wrote: > On Tue, Jan 19, 2016 at 01:50:47PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jan 19, 2016 at 07:51:18PM +0900, Namhyung Kim escreveu: > > > Hi Jiri, > > > > > > On Sun, Jan 17, 2016 at 05:15:33PM +0100, Jiri Olsa wrote: > > > > On Sun, Jan 17, 2016 at 01:03:01AM +0900, Namhyung Kim wrote: > > > > > > > > SNIP > > > > > > > > > char *srcfile; > > > > > struct symbol *parent; > > > > > - struct rb_root sorted_chain; > > > > > struct branch_info *branch_info; > > > > > struct hists *hists; > > > > > struct mem_info *mem_info; > > > > > void *raw_data; > > > > > u32 raw_size; > > > > > void *trace_output; > > > > > + struct perf_hpp_fmt *fmt; > > > > > + struct hist_entry *parent_he; > > > > > + union { > > > > > + /* this is for hierarchical entry structure */ > > > > > + struct { > > > > > + struct rb_root hroot_in; > > > > > + struct rb_root hroot_out; > > > > > + }; /* non-leaf entries */ > > > > > + struct rb_root sorted_chain; /* leaf entry has callchains */ > > > > > + }; > > > > > > > > looks like cool feature! > > > > > > Thanks! > > > > > > > > > > > could we have the hist_entry storage little more generic? > > > > and maybe dynamically allocated? > > > > > > I'm fine with it. > > > > Ok, so how should we proceed? I propose I test this patchkit, which > > indeed looks cool from this cover letter description, yay! > > > > If I find no problems, I'll merge it and, then, on top of it, you guys > > can work on having this per-feature priv storage sorted out? > > > > Please advise, meanwhile I'll cherry-pick whatever seems easy from both > > patchkits. > > Namhyung, > are you going to send another version, or should I review this one? Please review this version! Thanks, Namhyung