From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758934AbcAUH6s (ORCPT ); Thu, 21 Jan 2016 02:58:48 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:36930 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbcAUH6o (ORCPT ); Thu, 21 Jan 2016 02:58:44 -0500 Date: Thu, 21 Jan 2016 08:58:49 +0100 From: Daniel Vetter To: Michel =?iso-8859-1?Q?D=E4nzer?= Cc: Mario Kleiner , Vlastimil Babka , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Daniel Vetter , LKML , dri-devel@lists.freedesktop.org, mgraesslin@kde.org, kwin@kde.org, Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Message-ID: <20160121075849.GH19130@phenom.ffwll.local> Mail-Followup-To: Michel =?iso-8859-1?Q?D=E4nzer?= , Mario Kleiner , Vlastimil Babka , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , LKML , dri-devel@lists.freedesktop.org, mgraesslin@kde.org, kwin@kde.org, Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= References: <5698CB20.9050602@suse.cz> <20160115122629.GC23290@intel.com> <5699C5E5.90702@gmail.com> <569CC357.8030302@suse.cz> <569FEEDE.4060409@gmail.com> <56A053CE.7000500@daenzer.net> <56A06D2E.4000008@gmail.com> <56A07CF9.5060506@daenzer.net> <56A07D97.6030606@daenzer.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56A07D97.6030606@daenzer.net> X-Operating-System: Linux phenom 4.3.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 21, 2016 at 03:41:27PM +0900, Michel Dänzer wrote: > On 21.01.2016 15:38, Michel Dänzer wrote: > > On 21.01.2016 14:31, Mario Kleiner wrote: > >> On 01/21/2016 04:43 AM, Michel Dänzer wrote: > >>> On 21.01.2016 05:32, Mario Kleiner wrote: > >>>> > >>>> So the problem is that AMDs hardware frame counters reset to > >>>> zero during a modeset. The old DRM code dealt with drivers doing that by > >>>> keeping vblank irqs enabled during modesets and incrementing vblank > >>>> count by one during each vblank irq, i think that's what > >>>> drm_vblank_pre_modeset() and drm_vblank_post_modeset() were meant for. > >>> > >>> Right, looks like there's been a regression breaking this. I suspect the > >>> problem is that vblank->last isn't getting updated from > >>> drm_vblank_post_modeset. Not sure which change broke that though, or how > >>> to fix it. Ville? > >>> > >> > >> The whole logic has changed and the software counter updates are now > >> driven all the time by the hw counter. > >> > >>> > >>> BTW, I'm seeing a similar issue with drm_vblank_on/off as well, which > >>> exposed the bug fixed by 209e4dbc ("drm/vblank: Use u32 consistently for > >>> vblank counters"). I've been meaning to track that down since then; one > >>> of these days hopefully, but if anybody has any ideas offhand... > >> > >> I spent the last few hours reading through the drm and radeon code and i > >> think what should probably work is to replace the > >> drm_vblank_pre/post_modeset calls in radeon/amdgpu by drm_vblank_off/on > >> calls. These are apparently meant for drivers whose hw counters reset > >> during modeset, [...] > > > > ... just like drm_vblank_pre/post_modeset. That those were broken is a > > regression which needs to be fixed anyway. I don't think switching to > > drm_vblank_on/off is suitable for stable trees. > > Even more so since as I mentioned, there is (has been since at least > about half a year ago) a counter jumping bug with drm_vblank_on/off as well. Hm, never noticed you reported that. I thought the reason for not picking up my drm_vblank_on/off patches was that there's a bug in amdgpu userspace where it tried to use vblank waits on a disabled pipe? Can you please point me at the vblank on/off jump bug please? Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Date: Thu, 21 Jan 2016 08:58:49 +0100 Message-ID: <20160121075849.GH19130@phenom.ffwll.local> References: <5698CB20.9050602@suse.cz> <20160115122629.GC23290@intel.com> <5699C5E5.90702@gmail.com> <569CC357.8030302@suse.cz> <569FEEDE.4060409@gmail.com> <56A053CE.7000500@daenzer.net> <56A06D2E.4000008@gmail.com> <56A07CF9.5060506@daenzer.net> <56A07D97.6030606@daenzer.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E2686E8F0 for ; Wed, 20 Jan 2016 23:58:45 -0800 (PST) Received: by mail-wm0-f51.google.com with SMTP id r129so160915485wmr.0 for ; Wed, 20 Jan 2016 23:58:45 -0800 (PST) Content-Disposition: inline In-Reply-To: <56A07D97.6030606@daenzer.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Michel =?iso-8859-1?Q?D=E4nzer?= Cc: Daniel Vetter , LKML , dri-devel@lists.freedesktop.org, mgraesslin@kde.org, Vlastimil Babka , kwin@kde.org, Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKYW4gMjEsIDIwMTYgYXQgMDM6NDE6MjdQTSArMDkwMCwgTWljaGVsIETDpG56ZXIg d3JvdGU6Cj4gT24gMjEuMDEuMjAxNiAxNTozOCwgTWljaGVsIETDpG56ZXIgd3JvdGU6Cj4gPiBP biAyMS4wMS4yMDE2IDE0OjMxLCBNYXJpbyBLbGVpbmVyIHdyb3RlOgo+ID4+IE9uIDAxLzIxLzIw MTYgMDQ6NDMgQU0sIE1pY2hlbCBEw6RuemVyIHdyb3RlOgo+ID4+PiBPbiAyMS4wMS4yMDE2IDA1 OjMyLCBNYXJpbyBLbGVpbmVyIHdyb3RlOgo+ID4+Pj4KPiA+Pj4+IFNvIHRoZSBwcm9ibGVtIGlz IHRoYXQgQU1EcyBoYXJkd2FyZSBmcmFtZSBjb3VudGVycyByZXNldCB0bwo+ID4+Pj4gemVybyBk dXJpbmcgYSBtb2Rlc2V0LiBUaGUgb2xkIERSTSBjb2RlIGRlYWx0IHdpdGggZHJpdmVycyBkb2lu ZyB0aGF0IGJ5Cj4gPj4+PiBrZWVwaW5nIHZibGFuayBpcnFzIGVuYWJsZWQgZHVyaW5nIG1vZGVz ZXRzIGFuZCBpbmNyZW1lbnRpbmcgdmJsYW5rCj4gPj4+PiBjb3VudCBieSBvbmUgZHVyaW5nIGVh Y2ggdmJsYW5rIGlycSwgaSB0aGluayB0aGF0J3Mgd2hhdAo+ID4+Pj4gZHJtX3ZibGFua19wcmVf bW9kZXNldCgpIGFuZCBkcm1fdmJsYW5rX3Bvc3RfbW9kZXNldCgpIHdlcmUgbWVhbnQgZm9yLgo+ ID4+Pgo+ID4+PiBSaWdodCwgbG9va3MgbGlrZSB0aGVyZSdzIGJlZW4gYSByZWdyZXNzaW9uIGJy ZWFraW5nIHRoaXMuIEkgc3VzcGVjdCB0aGUKPiA+Pj4gcHJvYmxlbSBpcyB0aGF0IHZibGFuay0+ bGFzdCBpc24ndCBnZXR0aW5nIHVwZGF0ZWQgZnJvbQo+ID4+PiBkcm1fdmJsYW5rX3Bvc3RfbW9k ZXNldC4gTm90IHN1cmUgd2hpY2ggY2hhbmdlIGJyb2tlIHRoYXQgdGhvdWdoLCBvciBob3cKPiA+ Pj4gdG8gZml4IGl0LiBWaWxsZT8KPiA+Pj4KPiA+Pgo+ID4+IFRoZSB3aG9sZSBsb2dpYyBoYXMg Y2hhbmdlZCBhbmQgdGhlIHNvZnR3YXJlIGNvdW50ZXIgdXBkYXRlcyBhcmUgbm93Cj4gPj4gZHJp dmVuIGFsbCB0aGUgdGltZSBieSB0aGUgaHcgY291bnRlci4KPiA+Pgo+ID4+Pgo+ID4+PiBCVFcs IEknbSBzZWVpbmcgYSBzaW1pbGFyIGlzc3VlIHdpdGggZHJtX3ZibGFua19vbi9vZmYgYXMgd2Vs bCwgd2hpY2gKPiA+Pj4gZXhwb3NlZCB0aGUgYnVnIGZpeGVkIGJ5IDIwOWU0ZGJjICgiZHJtL3Zi bGFuazogVXNlIHUzMiBjb25zaXN0ZW50bHkgZm9yCj4gPj4+IHZibGFuayBjb3VudGVycyIpLiBJ J3ZlIGJlZW4gbWVhbmluZyB0byB0cmFjayB0aGF0IGRvd24gc2luY2UgdGhlbjsgb25lCj4gPj4+ IG9mIHRoZXNlIGRheXMgaG9wZWZ1bGx5LCBidXQgaWYgYW55Ym9keSBoYXMgYW55IGlkZWFzIG9m ZmhhbmQuLi4KPiA+Pgo+ID4+IEkgc3BlbnQgdGhlIGxhc3QgZmV3IGhvdXJzIHJlYWRpbmcgdGhy b3VnaCB0aGUgZHJtIGFuZCByYWRlb24gY29kZSBhbmQgaQo+ID4+IHRoaW5rIHdoYXQgc2hvdWxk IHByb2JhYmx5IHdvcmsgaXMgdG8gcmVwbGFjZSB0aGUKPiA+PiBkcm1fdmJsYW5rX3ByZS9wb3N0 X21vZGVzZXQgY2FsbHMgaW4gcmFkZW9uL2FtZGdwdSBieSBkcm1fdmJsYW5rX29mZi9vbgo+ID4+ IGNhbGxzLiBUaGVzZSBhcmUgYXBwYXJlbnRseSBtZWFudCBmb3IgZHJpdmVycyB3aG9zZSBodyBj b3VudGVycyByZXNldAo+ID4+IGR1cmluZyBtb2Rlc2V0LCBbLi4uXQo+ID4gCj4gPiAuLi4ganVz dCBsaWtlIGRybV92YmxhbmtfcHJlL3Bvc3RfbW9kZXNldC4gVGhhdCB0aG9zZSB3ZXJlIGJyb2tl biBpcyBhCj4gPiByZWdyZXNzaW9uIHdoaWNoIG5lZWRzIHRvIGJlIGZpeGVkIGFueXdheS4gSSBk b24ndCB0aGluayBzd2l0Y2hpbmcgdG8KPiA+IGRybV92Ymxhbmtfb24vb2ZmIGlzIHN1aXRhYmxl IGZvciBzdGFibGUgdHJlZXMuCj4gCj4gRXZlbiBtb3JlIHNvIHNpbmNlIGFzIEkgbWVudGlvbmVk LCB0aGVyZSBpcyAoaGFzIGJlZW4gc2luY2UgYXQgbGVhc3QKPiBhYm91dCBoYWxmIGEgeWVhciBh Z28pIGEgY291bnRlciBqdW1waW5nIGJ1ZyB3aXRoIGRybV92Ymxhbmtfb24vb2ZmIGFzIHdlbGwu CgpIbSwgbmV2ZXIgbm90aWNlZCB5b3UgcmVwb3J0ZWQgdGhhdC4gSSB0aG91Z2h0IHRoZSByZWFz b24gZm9yIG5vdCBwaWNraW5nCnVwIG15IGRybV92Ymxhbmtfb24vb2ZmIHBhdGNoZXMgd2FzIHRo YXQgdGhlcmUncyBhIGJ1ZyBpbiBhbWRncHUgdXNlcnNwYWNlCndoZXJlIGl0IHRyaWVkIHRvIHVz ZSB2Ymxhbmsgd2FpdHMgb24gYSBkaXNhYmxlZCBwaXBlPwoKQ2FuIHlvdSBwbGVhc2UgcG9pbnQg bWUgYXQgdGhlIHZibGFuayBvbi9vZmYganVtcCBidWcgcGxlYXNlPwoKVGhhbmtzLCBEYW5pZWwK LS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0 dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg==