From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759282AbcAUKJF (ORCPT ); Thu, 21 Jan 2016 05:09:05 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:37231 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759215AbcAUKI7 (ORCPT ); Thu, 21 Jan 2016 05:08:59 -0500 Date: Thu, 21 Jan 2016 11:09:05 +0100 From: Daniel Vetter To: Michel =?iso-8859-1?Q?D=E4nzer?= Cc: Mario Kleiner , Vlastimil Babka , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , LKML , dri-devel@lists.freedesktop.org, mgraesslin@kde.org, kwin@kde.org, Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Message-ID: <20160121100905.GL19130@phenom.ffwll.local> Mail-Followup-To: Michel =?iso-8859-1?Q?D=E4nzer?= , Mario Kleiner , Vlastimil Babka , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , LKML , dri-devel@lists.freedesktop.org, mgraesslin@kde.org, kwin@kde.org, Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= References: <20160115122629.GC23290@intel.com> <5699C5E5.90702@gmail.com> <569CC357.8030302@suse.cz> <569FEEDE.4060409@gmail.com> <56A053CE.7000500@daenzer.net> <56A06D2E.4000008@gmail.com> <56A07CF9.5060506@daenzer.net> <56A07D97.6030606@daenzer.net> <20160121075849.GH19130@phenom.ffwll.local> <56A0989E.30006@daenzer.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56A0989E.30006@daenzer.net> X-Operating-System: Linux phenom 4.3.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 21, 2016 at 05:36:46PM +0900, Michel Dänzer wrote: > On 21.01.2016 16:58, Daniel Vetter wrote: > > On Thu, Jan 21, 2016 at 03:41:27PM +0900, Michel Dänzer wrote: > >> On 21.01.2016 15:38, Michel Dänzer wrote: > >>> On 21.01.2016 14:31, Mario Kleiner wrote: > >>>> On 01/21/2016 04:43 AM, Michel Dänzer wrote: > >>>>> On 21.01.2016 05:32, Mario Kleiner wrote: > >>>>>> > >>>>>> So the problem is that AMDs hardware frame counters reset to > >>>>>> zero during a modeset. The old DRM code dealt with drivers doing that by > >>>>>> keeping vblank irqs enabled during modesets and incrementing vblank > >>>>>> count by one during each vblank irq, i think that's what > >>>>>> drm_vblank_pre_modeset() and drm_vblank_post_modeset() were meant for. > >>>>> > >>>>> Right, looks like there's been a regression breaking this. I suspect the > >>>>> problem is that vblank->last isn't getting updated from > >>>>> drm_vblank_post_modeset. Not sure which change broke that though, or how > >>>>> to fix it. Ville? > >>>>> > >>>> > >>>> The whole logic has changed and the software counter updates are now > >>>> driven all the time by the hw counter. > >>>> > >>>>> > >>>>> BTW, I'm seeing a similar issue with drm_vblank_on/off as well, which > >>>>> exposed the bug fixed by 209e4dbc ("drm/vblank: Use u32 consistently for > >>>>> vblank counters"). I've been meaning to track that down since then; one > >>>>> of these days hopefully, but if anybody has any ideas offhand... > >>>> > >>>> I spent the last few hours reading through the drm and radeon code and i > >>>> think what should probably work is to replace the > >>>> drm_vblank_pre/post_modeset calls in radeon/amdgpu by drm_vblank_off/on > >>>> calls. These are apparently meant for drivers whose hw counters reset > >>>> during modeset, [...] > >>> > >>> ... just like drm_vblank_pre/post_modeset. That those were broken is a > >>> regression which needs to be fixed anyway. I don't think switching to > >>> drm_vblank_on/off is suitable for stable trees. > >> > >> Even more so since as I mentioned, there is (has been since at least > >> about half a year ago) a counter jumping bug with drm_vblank_on/off as well. > > > > Hm, never noticed you reported that. I thought the reason for not picking > > up my drm_vblank_on/off patches was that there's a bug in amdgpu userspace > > where it tried to use vblank waits on a disabled pipe? > > http://lists.freedesktop.org/archives/dri-devel/2015-July/086451.html > > I don't know why it didn't get picked up. Yeah, checking my tree your ack is indeed in there. I think I'll resend them. > > Can you please point me at the vblank on/off jump bug please? > > AFAIR I originally reported it in response to > http://lists.freedesktop.org/archives/dri-devel/2015-August/087841.html > , but I can't find that in the archives, so maybe that was just on IRC. > See > http://lists.freedesktop.org/archives/dri-devel/2016-January/099122.html > . Basically, I ran into the bug fixed by your patch because the counter > jumped forward on every DPMS off, so it hit the 32-bit boundary after > just a few days. Ok, so just uncovered the overflow bug. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Date: Thu, 21 Jan 2016 11:09:05 +0100 Message-ID: <20160121100905.GL19130@phenom.ffwll.local> References: <20160115122629.GC23290@intel.com> <5699C5E5.90702@gmail.com> <569CC357.8030302@suse.cz> <569FEEDE.4060409@gmail.com> <56A053CE.7000500@daenzer.net> <56A06D2E.4000008@gmail.com> <56A07CF9.5060506@daenzer.net> <56A07D97.6030606@daenzer.net> <20160121075849.GH19130@phenom.ffwll.local> <56A0989E.30006@daenzer.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id A34226E212 for ; Thu, 21 Jan 2016 02:08:59 -0800 (PST) Received: by mail-wm0-f44.google.com with SMTP id r129so165248948wmr.0 for ; Thu, 21 Jan 2016 02:08:59 -0800 (PST) Content-Disposition: inline In-Reply-To: <56A0989E.30006@daenzer.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Michel =?iso-8859-1?Q?D=E4nzer?= Cc: kwin@kde.org, LKML , dri-devel@lists.freedesktop.org, mgraesslin@kde.org, Vlastimil Babka , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKYW4gMjEsIDIwMTYgYXQgMDU6MzY6NDZQTSArMDkwMCwgTWljaGVsIETDpG56ZXIg d3JvdGU6Cj4gT24gMjEuMDEuMjAxNiAxNjo1OCwgRGFuaWVsIFZldHRlciB3cm90ZToKPiA+IE9u IFRodSwgSmFuIDIxLCAyMDE2IGF0IDAzOjQxOjI3UE0gKzA5MDAsIE1pY2hlbCBEw6RuemVyIHdy b3RlOgo+ID4+IE9uIDIxLjAxLjIwMTYgMTU6MzgsIE1pY2hlbCBEw6RuemVyIHdyb3RlOgo+ID4+ PiBPbiAyMS4wMS4yMDE2IDE0OjMxLCBNYXJpbyBLbGVpbmVyIHdyb3RlOgo+ID4+Pj4gT24gMDEv MjEvMjAxNiAwNDo0MyBBTSwgTWljaGVsIETDpG56ZXIgd3JvdGU6Cj4gPj4+Pj4gT24gMjEuMDEu MjAxNiAwNTozMiwgTWFyaW8gS2xlaW5lciB3cm90ZToKPiA+Pj4+Pj4KPiA+Pj4+Pj4gU28gdGhl IHByb2JsZW0gaXMgdGhhdCBBTURzIGhhcmR3YXJlIGZyYW1lIGNvdW50ZXJzIHJlc2V0IHRvCj4g Pj4+Pj4+IHplcm8gZHVyaW5nIGEgbW9kZXNldC4gVGhlIG9sZCBEUk0gY29kZSBkZWFsdCB3aXRo IGRyaXZlcnMgZG9pbmcgdGhhdCBieQo+ID4+Pj4+PiBrZWVwaW5nIHZibGFuayBpcnFzIGVuYWJs ZWQgZHVyaW5nIG1vZGVzZXRzIGFuZCBpbmNyZW1lbnRpbmcgdmJsYW5rCj4gPj4+Pj4+IGNvdW50 IGJ5IG9uZSBkdXJpbmcgZWFjaCB2YmxhbmsgaXJxLCBpIHRoaW5rIHRoYXQncyB3aGF0Cj4gPj4+ Pj4+IGRybV92YmxhbmtfcHJlX21vZGVzZXQoKSBhbmQgZHJtX3ZibGFua19wb3N0X21vZGVzZXQo KSB3ZXJlIG1lYW50IGZvci4KPiA+Pj4+Pgo+ID4+Pj4+IFJpZ2h0LCBsb29rcyBsaWtlIHRoZXJl J3MgYmVlbiBhIHJlZ3Jlc3Npb24gYnJlYWtpbmcgdGhpcy4gSSBzdXNwZWN0IHRoZQo+ID4+Pj4+ IHByb2JsZW0gaXMgdGhhdCB2YmxhbmstPmxhc3QgaXNuJ3QgZ2V0dGluZyB1cGRhdGVkIGZyb20K PiA+Pj4+PiBkcm1fdmJsYW5rX3Bvc3RfbW9kZXNldC4gTm90IHN1cmUgd2hpY2ggY2hhbmdlIGJy b2tlIHRoYXQgdGhvdWdoLCBvciBob3cKPiA+Pj4+PiB0byBmaXggaXQuIFZpbGxlPwo+ID4+Pj4+ Cj4gPj4+Pgo+ID4+Pj4gVGhlIHdob2xlIGxvZ2ljIGhhcyBjaGFuZ2VkIGFuZCB0aGUgc29mdHdh cmUgY291bnRlciB1cGRhdGVzIGFyZSBub3cKPiA+Pj4+IGRyaXZlbiBhbGwgdGhlIHRpbWUgYnkg dGhlIGh3IGNvdW50ZXIuCj4gPj4+Pgo+ID4+Pj4+Cj4gPj4+Pj4gQlRXLCBJJ20gc2VlaW5nIGEg c2ltaWxhciBpc3N1ZSB3aXRoIGRybV92Ymxhbmtfb24vb2ZmIGFzIHdlbGwsIHdoaWNoCj4gPj4+ Pj4gZXhwb3NlZCB0aGUgYnVnIGZpeGVkIGJ5IDIwOWU0ZGJjICgiZHJtL3ZibGFuazogVXNlIHUz MiBjb25zaXN0ZW50bHkgZm9yCj4gPj4+Pj4gdmJsYW5rIGNvdW50ZXJzIikuIEkndmUgYmVlbiBt ZWFuaW5nIHRvIHRyYWNrIHRoYXQgZG93biBzaW5jZSB0aGVuOyBvbmUKPiA+Pj4+PiBvZiB0aGVz ZSBkYXlzIGhvcGVmdWxseSwgYnV0IGlmIGFueWJvZHkgaGFzIGFueSBpZGVhcyBvZmZoYW5kLi4u Cj4gPj4+Pgo+ID4+Pj4gSSBzcGVudCB0aGUgbGFzdCBmZXcgaG91cnMgcmVhZGluZyB0aHJvdWdo IHRoZSBkcm0gYW5kIHJhZGVvbiBjb2RlIGFuZCBpCj4gPj4+PiB0aGluayB3aGF0IHNob3VsZCBw cm9iYWJseSB3b3JrIGlzIHRvIHJlcGxhY2UgdGhlCj4gPj4+PiBkcm1fdmJsYW5rX3ByZS9wb3N0 X21vZGVzZXQgY2FsbHMgaW4gcmFkZW9uL2FtZGdwdSBieSBkcm1fdmJsYW5rX29mZi9vbgo+ID4+ Pj4gY2FsbHMuIFRoZXNlIGFyZSBhcHBhcmVudGx5IG1lYW50IGZvciBkcml2ZXJzIHdob3NlIGh3 IGNvdW50ZXJzIHJlc2V0Cj4gPj4+PiBkdXJpbmcgbW9kZXNldCwgWy4uLl0KPiA+Pj4KPiA+Pj4g Li4uIGp1c3QgbGlrZSBkcm1fdmJsYW5rX3ByZS9wb3N0X21vZGVzZXQuIFRoYXQgdGhvc2Ugd2Vy ZSBicm9rZW4gaXMgYQo+ID4+PiByZWdyZXNzaW9uIHdoaWNoIG5lZWRzIHRvIGJlIGZpeGVkIGFu eXdheS4gSSBkb24ndCB0aGluayBzd2l0Y2hpbmcgdG8KPiA+Pj4gZHJtX3ZibGFua19vbi9vZmYg aXMgc3VpdGFibGUgZm9yIHN0YWJsZSB0cmVlcy4KPiA+Pgo+ID4+IEV2ZW4gbW9yZSBzbyBzaW5j ZSBhcyBJIG1lbnRpb25lZCwgdGhlcmUgaXMgKGhhcyBiZWVuIHNpbmNlIGF0IGxlYXN0Cj4gPj4g YWJvdXQgaGFsZiBhIHllYXIgYWdvKSBhIGNvdW50ZXIganVtcGluZyBidWcgd2l0aCBkcm1fdmJs YW5rX29uL29mZiBhcyB3ZWxsLgo+ID4gCj4gPiBIbSwgbmV2ZXIgbm90aWNlZCB5b3UgcmVwb3J0 ZWQgdGhhdC4gSSB0aG91Z2h0IHRoZSByZWFzb24gZm9yIG5vdCBwaWNraW5nCj4gPiB1cCBteSBk cm1fdmJsYW5rX29uL29mZiBwYXRjaGVzIHdhcyB0aGF0IHRoZXJlJ3MgYSBidWcgaW4gYW1kZ3B1 IHVzZXJzcGFjZQo+ID4gd2hlcmUgaXQgdHJpZWQgdG8gdXNlIHZibGFuayB3YWl0cyBvbiBhIGRp c2FibGVkIHBpcGU/Cj4gCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9hcmNoaXZlcy9k cmktZGV2ZWwvMjAxNS1KdWx5LzA4NjQ1MS5odG1sCj4gCj4gSSBkb24ndCBrbm93IHdoeSBpdCBk aWRuJ3QgZ2V0IHBpY2tlZCB1cC4KClllYWgsIGNoZWNraW5nIG15IHRyZWUgeW91ciBhY2sgaXMg aW5kZWVkIGluIHRoZXJlLiBJIHRoaW5rIEknbGwgcmVzZW5kCnRoZW0uCgo+ID4gQ2FuIHlvdSBw bGVhc2UgcG9pbnQgbWUgYXQgdGhlIHZibGFuayBvbi9vZmYganVtcCBidWcgcGxlYXNlPwo+IAo+ IEFGQUlSIEkgb3JpZ2luYWxseSByZXBvcnRlZCBpdCBpbiByZXNwb25zZSB0bwo+IGh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMvZHJpLWRldmVsLzIwMTUtQXVndXN0LzA4Nzg0 MS5odG1sCj4gLCBidXQgSSBjYW4ndCBmaW5kIHRoYXQgaW4gdGhlIGFyY2hpdmVzLCBzbyBtYXli ZSB0aGF0IHdhcyBqdXN0IG9uIElSQy4KPiBTZWUKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL2FyY2hpdmVzL2RyaS1kZXZlbC8yMDE2LUphbnVhcnkvMDk5MTIyLmh0bWwKPiAuIEJhc2lj YWxseSwgSSByYW4gaW50byB0aGUgYnVnIGZpeGVkIGJ5IHlvdXIgcGF0Y2ggYmVjYXVzZSB0aGUg Y291bnRlcgo+IGp1bXBlZCBmb3J3YXJkIG9uIGV2ZXJ5IERQTVMgb2ZmLCBzbyBpdCBoaXQgdGhl IDMyLWJpdCBib3VuZGFyeSBhZnRlcgo+IGp1c3QgYSBmZXcgZGF5cy4KCk9rLCBzbyBqdXN0IHVu Y292ZXJlZCB0aGUgb3ZlcmZsb3cgYnVnLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3 YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=