Re: [PATCH v6 5/5] hisilicon/dts: Add hi655x pmic dts node

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1983 bytes --]

On Thu, Jan 21, 2016 at 06:32:32PM +0800, chenfeng wrote:
> On 2016/1/20 21:08, Mark Brown wrote:
> > On Tue, Jan 19, 2016 at 02:32:04PM +0800, Chen Feng wrote:

> I will change it like this:
>                 regulators {
>                         ldo2: LDO2@a21 {
>                                 regulator-name = "ldo2";
>                                 regulator-min-microvolt = <2500000>;
>                                 regulator-max-microvolt = <3200000>;
>                                 regulator-valid-modes-mask = <0x02>;
>                                 regulator-enable-ramp-delay = <120>;
>                         };

No, do not include the voltage constraints, see the second half of my
reply.

> >> +				regulator-min-microvolt = <2500000>;
> >> +				regulator-max-microvolt = <3200000>;

> > This is broken as it misunderstands the purpose of specifying
> > constraints.  The constraints are there to say what the safe and
> > supported configuration is on a given board, it is not possible to
> > provide this information safely in a general include that is used by all
> > systems using the PMIC.  Specifying the maximum voltage range for the
> > regulators is almost guaranteed to result in at least some
> > configurations being enabled which will not work, in the worst case this
> > may include configurations which could physically damage the system.

> > In general it is very unusual to include the regulators in a .dtsi since
> > essentially all the configuration for them should be board specific.

> Do you mean that I should move this into dts and enable it by default?

It would be more normal to put everything to do with the regulators into
the board DTS.  It is unlikely that a straight move would be the right
thing, you would need to understand what all the voltage ranges on the
board are and set them appropriately and should normally also be naming
the regulators as per the schematic so users can tie the DT and the
schematic together.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]