From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752936AbcAVJ5f (ORCPT ); Fri, 22 Jan 2016 04:57:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48057 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752599AbcAVJ5a (ORCPT ); Fri, 22 Jan 2016 04:57:30 -0500 Date: Fri, 22 Jan 2016 10:57:27 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, eranian@google.com, Andi Kleen Subject: Re: [PATCH 4/9] perf, tools, stat: Implement CSV metrics output Message-ID: <20160122095727.GA11995@krava.brq.redhat.com> References: <1453256812-24006-1-git-send-email-andi@firstfloor.org> <1453256812-24006-5-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453256812-24006-5-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 19, 2016 at 06:26:47PM -0800, Andi Kleen wrote: > From: Andi Kleen > > Now support CSV output for metrics. With the new output callbacks > this is relatively straight forward by creating new callbacks. > > The new line callback needs to know the number of fields to skip them > correctly could you please provide some output example into changelog? with fields described.. I've got: $ perf stat -e cycles,instructions -a -x, ^C154179453,,cycles,3358275330,100.00,,Ghz,3358275330,100.00 37699562,,instructions,3358350427,100.00,0.24,insn per cycle ,,,3358350427,100.00,,stalled cycles per insn,3358350427,100.00 and it seems this is extra -------------------^^^^^^^^^^^^^^^^^ thanks, jirka