From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754372AbcAVUVK (ORCPT ); Fri, 22 Jan 2016 15:21:10 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:43215 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753876AbcAVUVI (ORCPT ); Fri, 22 Jan 2016 15:21:08 -0500 Date: Fri, 22 Jan 2016 12:21:06 -0800 From: Andrew Morton To: Christian Borntraeger Cc: Linus Torvalds , Cyrill Gorcunov , LKML , Linux MM , Quentin Casasnovas , Vegard Nossum , Andrew Morton , Willy Tarreau , Andy Lutomirski , Kees Cook , Vladimir Davydov , Konstantin Khlebnikov , Pavel Emelyanov , Peter Zijlstra , stable@vger.kernel.org, Greg KH Subject: Re: [PATCH RFC] mm: Rework virtual memory accounting Message-Id: <20160122122106.c4e85c4501a049ad123e6153@linux-foundation.org> In-Reply-To: <56A28613.5070104@de.ibm.com> References: <20151228211015.GL2194@uranus> <56A28613.5070104@de.ibm.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Jan 2016 20:42:11 +0100 Christian Borntraeger wrote: > On 12/28/2015 11:22 PM, Linus Torvalds wrote: > > On Mon, Dec 28, 2015 at 1:10 PM, Cyrill Gorcunov wrote: > >> Really sorry for delays. Konstantin, I slightly updated the > >> changelog (to point where problem came from). Linus are you > >> fine with accounting not only anonymous memory in VmData? > > > > The patch looks ok to me. I guess if somebody relies on old behavior > > we may have to tweak it a bit, but on the whole this looks sane and > > I'd be happy to merge it in the 4.5 merge window (and maybe even have > > it marked for stable if it works out) > > > > Just want to mention that this patch breaks older versions of valgrind > (including the current release) > https://bugs.kde.org/show_bug.cgi?id=357833 > It is fixed in trunk (and even triggered some good cleanups, so the valgrind > developers do NOT want it to get reverted). Rawhide already has the valgrind > fix, others might not, so if we consider this for stable, things might break > here and there, but in general this looks like a good cleanup. > OK, thanks - that sounds reasonable, although a bit worrisome - what other userspace was affected? In some cases people won't find out for years... 84638335900f199 ("mm: rework virtual memory accounting") did not have the cc:stable tag so it should avoid the -stable dragnet. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 22 Jan 2016 12:21:06 -0800 From: Andrew Morton To: Christian Borntraeger Cc: Linus Torvalds , Cyrill Gorcunov , LKML , Linux MM , Quentin Casasnovas , Vegard Nossum , Andrew Morton , Willy Tarreau , Andy Lutomirski , Kees Cook , Vladimir Davydov , Konstantin Khlebnikov , Pavel Emelyanov , Peter Zijlstra , stable@vger.kernel.org, Greg KH Subject: Re: [PATCH RFC] mm: Rework virtual memory accounting Message-Id: <20160122122106.c4e85c4501a049ad123e6153@linux-foundation.org> In-Reply-To: <56A28613.5070104@de.ibm.com> References: <20151228211015.GL2194@uranus> <56A28613.5070104@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: On Fri, 22 Jan 2016 20:42:11 +0100 Christian Borntraeger wrote: > On 12/28/2015 11:22 PM, Linus Torvalds wrote: > > On Mon, Dec 28, 2015 at 1:10 PM, Cyrill Gorcunov wrote: > >> Really sorry for delays. Konstantin, I slightly updated the > >> changelog (to point where problem came from). Linus are you > >> fine with accounting not only anonymous memory in VmData? > > > > The patch looks ok to me. I guess if somebody relies on old behavior > > we may have to tweak it a bit, but on the whole this looks sane and > > I'd be happy to merge it in the 4.5 merge window (and maybe even have > > it marked for stable if it works out) > > > > Just want to mention that this patch breaks older versions of valgrind > (including the current release) > https://bugs.kde.org/show_bug.cgi?id=357833 > It is fixed in trunk (and even triggered some good cleanups, so the valgrind > developers do NOT want it to get reverted). Rawhide already has the valgrind > fix, others might not, so if we consider this for stable, things might break > here and there, but in general this looks like a good cleanup. > OK, thanks - that sounds reasonable, although a bit worrisome - what other userspace was affected? In some cases people won't find out for years... 84638335900f199 ("mm: rework virtual memory accounting") did not have the cc:stable tag so it should avoid the -stable dragnet. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org