From: Borislav Petkov <bp@suse.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] x86, microcode: remove an unneeded NULL check
Date: Fri, 22 Jan 2016 13:00:25 +0000 [thread overview]
Message-ID: <20160122130025.GB9306@pd.tnic> (raw)
On Mon, Jan 20, 2014 at 01:30:47PM +0300, Dan Carpenter wrote:
> "uci" is an element of the ucode_cpu_info[] array, it can't be NULL.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
> index 15c987698b0f..05db44e4198c 100644
> --- a/arch/x86/kernel/cpu/microcode/core.c
> +++ b/arch/x86/kernel/cpu/microcode/core.c
> @@ -382,7 +382,7 @@ static enum ucode_state microcode_init_cpu(int cpu, bool refresh_fw)
> enum ucode_state ustate;
> struct ucode_cpu_info *uci = ucode_cpu_info + cpu;
>
> - if (uci && uci->valid)
> + if (uci->valid)
> return UCODE_OK;
>
> if (collect_cpu_info(cpu))
Applied, after almost 2 years!
Thanks.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next reply other threads:[~2016-01-22 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 13:00 Borislav Petkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-01-20 10:30 [patch] x86, microcode: remove an unneeded NULL check Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160122130025.GB9306@pd.tnic \
--to=bp@suse.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.