From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752707AbcAVPSn (ORCPT ); Fri, 22 Jan 2016 10:18:43 -0500 Received: from mga02.intel.com ([134.134.136.20]:15387 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbcAVPSk (ORCPT ); Fri, 22 Jan 2016 10:18:40 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,331,1449561600"; d="scan'208";a="866236376" Date: Fri, 22 Jan 2016 17:18:35 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Michel =?iso-8859-1?Q?D=E4nzer?= Cc: Mario Kleiner , Vlastimil Babka , LKML , dri-devel@lists.freedesktop.org, Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Message-ID: <20160122151835.GM23290@intel.com> References: <569CC357.8030302@suse.cz> <569FEEDE.4060409@gmail.com> <56A053CE.7000500@daenzer.net> <56A06D2E.4000008@gmail.com> <56A07CF9.5060506@daenzer.net> <56A07D97.6030606@daenzer.net> <20160121075849.GH19130@phenom.ffwll.local> <56A0989E.30006@daenzer.net> <20160121100905.GL19130@phenom.ffwll.local> <56A19C98.8020208@daenzer.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56A19C98.8020208@daenzer.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2016 at 12:06:00PM +0900, Michel Dänzer wrote: > > [ Trimming KDE folks from Cc ] > > On 21.01.2016 19:09, Daniel Vetter wrote: > > On Thu, Jan 21, 2016 at 05:36:46PM +0900, Michel Dänzer wrote: > >> On 21.01.2016 16:58, Daniel Vetter wrote: > >>> > >>> Can you please point me at the vblank on/off jump bug please? > >> > >> AFAIR I originally reported it in response to > >> http://lists.freedesktop.org/archives/dri-devel/2015-August/087841.html > >> , but I can't find that in the archives, so maybe that was just on IRC. > >> See > >> http://lists.freedesktop.org/archives/dri-devel/2016-January/099122.html > >> . Basically, I ran into the bug fixed by your patch because the counter > >> jumped forward on every DPMS off, so it hit the 32-bit boundary after > >> just a few days. > > > > Ok, so just uncovered the overflow bug. > > Not sure what you mean by "just", but to be clear: The drm_vblank_on/off > counter jumping bug (similar to the bug this thread is about), which > exposed the overflow bug, is still alive and kicking in 4.5. It seems > to happen when turning off the CRTC: > > [drm:drm_update_vblank_count] updating vblank count on crtc 0: current=218104694, diff=0, hw=916 hw_last=916 > [drm:radeon_get_vblank_counter_kms] crtc 0: dist from vblank start 3 > [drm:drm_calc_vbltimestamp_from_scanoutpos] crtc 0 : v 0x7 p(2199,-45)@ 7304.307354 -> 7304.308006 [e 0 us, 0 rep] > [drm:radeon_get_vblank_counter_kms] crtc 0: dist from vblank start 3 > [drm:drm_update_vblank_count] updating vblank count on crtc 0: current=218104694, diff=16776301, hw=1 hw_last=916 Not sure what bug we're talking about here, but here the hw counter clearly jumps backwards. > [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 > [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 > [drm:drm_update_vblank_count] updating vblank count on crtc 1: current=0, diff=0, hw=0 hw_last=0 > [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 > [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 > [drm:drm_update_vblank_count] updating vblank count on crtc 2: current=0, diff=0, hw=0 hw_last=0 > [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 > [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 > [drm:drm_update_vblank_count] updating vblank count on crtc 3: current=0, diff=0, hw=0 hw_last=0 > [drm:radeon_get_vblank_counter_kms] Query failed! stat 1 > [drm:drm_calc_vbltimestamp_from_scanoutpos] crtc 0 : v 0x1 p(0,0)@ 7304.317140 -> 7304.317140 [e 0 us, 0 rep] > [drm:radeon_get_vblank_counter_kms] Query failed! stat 1 > [drm:drm_update_vblank_count] updating vblank count on crtc 0: current=234880995, diff=16777215, hw=0 hw_last=1 Same here. These things just don't happen on i915 because drm_vblank_off() and drm_vblank_on() are always called around the times when the hw counter might get reset. Or at least that's how it should be. > dev->max_vblank_count = 0xffffffff, which makes the wraparound code in > drm_update_vblank_count a no-op. Maybe you can reproduce it if you > artificially set a lower max_vblank_count in the driver. > > > -- > Earthling Michel Dänzer | http://www.amd.com > Libre software enthusiast | Mesa and X developer -- Ville Syrjälä Intel OTC From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Date: Fri, 22 Jan 2016 17:18:35 +0200 Message-ID: <20160122151835.GM23290@intel.com> References: <569CC357.8030302@suse.cz> <569FEEDE.4060409@gmail.com> <56A053CE.7000500@daenzer.net> <56A06D2E.4000008@gmail.com> <56A07CF9.5060506@daenzer.net> <56A07D97.6030606@daenzer.net> <20160121075849.GH19130@phenom.ffwll.local> <56A0989E.30006@daenzer.net> <20160121100905.GL19130@phenom.ffwll.local> <56A19C98.8020208@daenzer.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id F30436EC27 for ; Fri, 22 Jan 2016 07:18:40 -0800 (PST) Content-Disposition: inline In-Reply-To: <56A19C98.8020208@daenzer.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Michel =?iso-8859-1?Q?D=E4nzer?= Cc: LKML , dri-devel@lists.freedesktop.org, Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Vlastimil Babka List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKYW4gMjIsIDIwMTYgYXQgMTI6MDY6MDBQTSArMDkwMCwgTWljaGVsIETDpG56ZXIg d3JvdGU6Cj4gCj4gWyBUcmltbWluZyBLREUgZm9sa3MgZnJvbSBDYyBdCj4gCj4gT24gMjEuMDEu MjAxNiAxOTowOSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiA+IE9uIFRodSwgSmFuIDIxLCAyMDE2 IGF0IDA1OjM2OjQ2UE0gKzA5MDAsIE1pY2hlbCBEw6RuemVyIHdyb3RlOgo+ID4+IE9uIDIxLjAx LjIwMTYgMTY6NTgsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPj4+IAo+ID4+PiBDYW4geW91IHBs ZWFzZSBwb2ludCBtZSBhdCB0aGUgdmJsYW5rIG9uL29mZiBqdW1wIGJ1ZyBwbGVhc2U/Cj4gPj4K PiA+PiBBRkFJUiBJIG9yaWdpbmFsbHkgcmVwb3J0ZWQgaXQgaW4gcmVzcG9uc2UgdG8KPiA+PiBo dHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL2FyY2hpdmVzL2RyaS1kZXZlbC8yMDE1LUF1Z3Vz dC8wODc4NDEuaHRtbAo+ID4+ICwgYnV0IEkgY2FuJ3QgZmluZCB0aGF0IGluIHRoZSBhcmNoaXZl cywgc28gbWF5YmUgdGhhdCB3YXMganVzdCBvbiBJUkMuCj4gPj4gU2VlCj4gPj4gaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9hcmNoaXZlcy9kcmktZGV2ZWwvMjAxNi1KYW51YXJ5LzA5OTEy Mi5odG1sCj4gPj4gLiBCYXNpY2FsbHksIEkgcmFuIGludG8gdGhlIGJ1ZyBmaXhlZCBieSB5b3Vy IHBhdGNoIGJlY2F1c2UgdGhlIGNvdW50ZXIKPiA+PiBqdW1wZWQgZm9yd2FyZCBvbiBldmVyeSBE UE1TIG9mZiwgc28gaXQgaGl0IHRoZSAzMi1iaXQgYm91bmRhcnkgYWZ0ZXIKPiA+PiBqdXN0IGEg ZmV3IGRheXMuCj4gPiAKPiA+IE9rLCBzbyBqdXN0IHVuY292ZXJlZCB0aGUgb3ZlcmZsb3cgYnVn Lgo+IAo+IE5vdCBzdXJlIHdoYXQgeW91IG1lYW4gYnkgImp1c3QiLCBidXQgdG8gYmUgY2xlYXI6 IFRoZSBkcm1fdmJsYW5rX29uL29mZgo+IGNvdW50ZXIganVtcGluZyBidWcgKHNpbWlsYXIgdG8g dGhlIGJ1ZyB0aGlzIHRocmVhZCBpcyBhYm91dCksIHdoaWNoCj4gZXhwb3NlZCB0aGUgb3ZlcmZs b3cgYnVnLCBpcyBzdGlsbCBhbGl2ZSBhbmQga2lja2luZyBpbiA0LjUuIEl0IHNlZW1zCj4gdG8g aGFwcGVuIHdoZW4gdHVybmluZyBvZmYgdGhlIENSVEM6Cj4gCj4gW2RybTpkcm1fdXBkYXRlX3Zi bGFua19jb3VudF0gdXBkYXRpbmcgdmJsYW5rIGNvdW50IG9uIGNydGMgMDogY3VycmVudD0yMTgx MDQ2OTQsIGRpZmY9MCwgaHc9OTE2IGh3X2xhc3Q9OTE2Cj4gW2RybTpyYWRlb25fZ2V0X3ZibGFu a19jb3VudGVyX2ttc10gY3J0YyAwOiBkaXN0IGZyb20gdmJsYW5rIHN0YXJ0IDMKPiBbZHJtOmRy bV9jYWxjX3ZibHRpbWVzdGFtcF9mcm9tX3NjYW5vdXRwb3NdIGNydGMgMCA6IHYgMHg3IHAoMjE5 OSwtNDUpQCA3MzA0LjMwNzM1NCAtPiA3MzA0LjMwODAwNiBbZSAwIHVzLCAwIHJlcF0KPiBbZHJt OnJhZGVvbl9nZXRfdmJsYW5rX2NvdW50ZXJfa21zXSBjcnRjIDA6IGRpc3QgZnJvbSB2Ymxhbmsg c3RhcnQgMwo+IFtkcm06ZHJtX3VwZGF0ZV92YmxhbmtfY291bnRdIHVwZGF0aW5nIHZibGFuayBj b3VudCBvbiBjcnRjIDA6IGN1cnJlbnQ9MjE4MTA0Njk0LCBkaWZmPTE2Nzc2MzAxLCBodz0xIGh3 X2xhc3Q9OTE2CgpOb3Qgc3VyZSB3aGF0IGJ1ZyB3ZSdyZSB0YWxraW5nIGFib3V0IGhlcmUsIGJ1 dCBoZXJlIHRoZSBodyBjb3VudGVyCmNsZWFybHkganVtcHMgYmFja3dhcmRzLgoKPiBbZHJtOnJh ZGVvbl9nZXRfdmJsYW5rX2NvdW50ZXJfa21zXSBRdWVyeSBmYWlsZWQhIHN0YXQgMwo+IFtkcm06 cmFkZW9uX2dldF92YmxhbmtfY291bnRlcl9rbXNdIFF1ZXJ5IGZhaWxlZCEgc3RhdCAzCj4gW2Ry bTpkcm1fdXBkYXRlX3ZibGFua19jb3VudF0gdXBkYXRpbmcgdmJsYW5rIGNvdW50IG9uIGNydGMg MTogY3VycmVudD0wLCBkaWZmPTAsIGh3PTAgaHdfbGFzdD0wCj4gW2RybTpyYWRlb25fZ2V0X3Zi bGFua19jb3VudGVyX2ttc10gUXVlcnkgZmFpbGVkISBzdGF0IDMKPiBbZHJtOnJhZGVvbl9nZXRf dmJsYW5rX2NvdW50ZXJfa21zXSBRdWVyeSBmYWlsZWQhIHN0YXQgMwo+IFtkcm06ZHJtX3VwZGF0 ZV92YmxhbmtfY291bnRdIHVwZGF0aW5nIHZibGFuayBjb3VudCBvbiBjcnRjIDI6IGN1cnJlbnQ9 MCwgZGlmZj0wLCBodz0wIGh3X2xhc3Q9MAo+IFtkcm06cmFkZW9uX2dldF92YmxhbmtfY291bnRl cl9rbXNdIFF1ZXJ5IGZhaWxlZCEgc3RhdCAzCj4gW2RybTpyYWRlb25fZ2V0X3ZibGFua19jb3Vu dGVyX2ttc10gUXVlcnkgZmFpbGVkISBzdGF0IDMKPiBbZHJtOmRybV91cGRhdGVfdmJsYW5rX2Nv dW50XSB1cGRhdGluZyB2YmxhbmsgY291bnQgb24gY3J0YyAzOiBjdXJyZW50PTAsIGRpZmY9MCwg aHc9MCBod19sYXN0PTAKPiBbZHJtOnJhZGVvbl9nZXRfdmJsYW5rX2NvdW50ZXJfa21zXSBRdWVy eSBmYWlsZWQhIHN0YXQgMQo+IFtkcm06ZHJtX2NhbGNfdmJsdGltZXN0YW1wX2Zyb21fc2Nhbm91 dHBvc10gY3J0YyAwIDogdiAweDEgcCgwLDApQCA3MzA0LjMxNzE0MCAtPiA3MzA0LjMxNzE0MCBb ZSAwIHVzLCAwIHJlcF0KPiBbZHJtOnJhZGVvbl9nZXRfdmJsYW5rX2NvdW50ZXJfa21zXSBRdWVy eSBmYWlsZWQhIHN0YXQgMQo+IFtkcm06ZHJtX3VwZGF0ZV92YmxhbmtfY291bnRdIHVwZGF0aW5n IHZibGFuayBjb3VudCBvbiBjcnRjIDA6IGN1cnJlbnQ9MjM0ODgwOTk1LCBkaWZmPTE2Nzc3MjE1 LCBodz0wIGh3X2xhc3Q9MQoKU2FtZSBoZXJlLgoKVGhlc2UgdGhpbmdzIGp1c3QgZG9uJ3QgaGFw cGVuIG9uIGk5MTUgYmVjYXVzZSBkcm1fdmJsYW5rX29mZigpIGFuZApkcm1fdmJsYW5rX29uKCkg YXJlIGFsd2F5cyBjYWxsZWQgYXJvdW5kIHRoZSB0aW1lcyB3aGVuIHRoZSBodyBjb3VudGVyCm1p Z2h0IGdldCByZXNldC4gT3IgYXQgbGVhc3QgdGhhdCdzIGhvdyBpdCBzaG91bGQgYmUuCgo+IGRl di0+bWF4X3ZibGFua19jb3VudCA9IDB4ZmZmZmZmZmYsIHdoaWNoIG1ha2VzIHRoZSB3cmFwYXJv dW5kIGNvZGUgaW4KPiBkcm1fdXBkYXRlX3ZibGFua19jb3VudCBhIG5vLW9wLiBNYXliZSB5b3Ug Y2FuIHJlcHJvZHVjZSBpdCBpZiB5b3UKPiBhcnRpZmljaWFsbHkgc2V0IGEgbG93ZXIgbWF4X3Zi bGFua19jb3VudCBpbiB0aGUgZHJpdmVyLgo+IAo+IAo+IC0tIAo+IEVhcnRobGluZyBNaWNoZWwg RMOkbnplciAgICAgICAgICAgICAgIHwgICAgICAgICAgICAgICBodHRwOi8vd3d3LmFtZC5jb20K PiBMaWJyZSBzb2Z0d2FyZSBlbnRodXNpYXN0ICAgICAgICAgICAgIHwgICAgICAgICAgICAgTWVz YSBhbmQgWCBkZXZlbG9wZXIKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==