From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:52627 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751721AbcAVUEo (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 22 Jan 2016 15:04:44 -0500
Date: Fri, 22 Jan 2016 20:04:42 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Mike Marshall <hubcap@omnibond.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: Orangefs ABI documentation
Message-ID: <20160122200442.GF17997@ZenIV.linux.org.uk>
References: <CAOg9mSS0Jg5JEjXxn0S5vTpV4kWR6qEyBiif7hu9EohNB0X9Bg@mail.gmail.com>
 <20160122071147.GY17997@ZenIV.linux.org.uk>
 <CAOg9mST6tDsY-cwvJsfYbcLt41Uufyy8Y-nXiCFsXwRJ0xanjQ@mail.gmail.com>
 <CAOg9mSQf4m-MM_kKd=UcGsCx_LZg=+nFESd8jhzDEbcM9DOGjg@mail.gmail.com>
 <20160122170838.GZ17997@ZenIV.linux.org.uk>
 <20160122174338.GA17997@ZenIV.linux.org.uk>
 <CAOg9mSSL2vtehQd6r-bmxK+zdDdwudJSXMmX2HBscm3cW_sp9A@mail.gmail.com>
 <20160122183720.GB17997@ZenIV.linux.org.uk>
 <CAOg9mSTCkr5_or_VSOHnNSsVqd5S=ENuGYBsJkgitqgworN9Eg@mail.gmail.com>
 <CAOg9mSRoEFvFkdJmEmFOO_ErT7X3Q51=X=HP5Li6g-dVFANOOg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOg9mSRoEFvFkdJmEmFOO_ErT7X3Q51=X=HP5Li6g-dVFANOOg@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Jan 22, 2016 at 02:21:44PM -0500, Mike Marshall wrote:
> Al...
> 
> I think that my commit f987f4c28
> "don't trigger copy_attributes_to_inode from d_revalidate."
> doesn't really do the job... I think I at least need to
> write code that checks some of the attributes and
> fails the revalidate if they got changed via some
> external process... does that sound right?

Won't your orangefs_revalidate_lookup() spot the changed handle?  Anyway,
some sanity checks in there might be a good idea - at least "has the
object type somehow changed without handle going stale?"...

Said that, what should be picking e.g. chmod/chown by external source?
You don't have ->permission() instances in there, so inode->i_mode is
used directly by generic_inode_permission()...