From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: Re: [PATCH v1 02/12] xen/hvmlite: Factor out common kernel init code Date: Sat, 23 Jan 2016 00:41:31 +0100 Message-ID: <20160122234131.GB20964__43615.1689420969$1453506169$gmane$org@wotan.suse.de> References: <1453498558-6028-1-git-send-email-boris.ostrovsky@oracle.com> <1453498558-6028-3-git-send-email-boris.ostrovsky@oracle.com> <20160122230144.GZ20964@wotan.suse.de> <56A2B76F.4060704@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aMlKe-0004LE-Vy for xen-devel@lists.xenproject.org; Fri, 22 Jan 2016 23:41:33 +0000 Content-Disposition: inline In-Reply-To: <56A2B76F.4060704@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky Cc: xen-devel@lists.xenproject.org, roger.pau@citrix.com, david.vrabel@citrix.com, linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org On Fri, Jan 22, 2016 at 06:12:47PM -0500, Boris Ostrovsky wrote: > On 01/22/2016 06:01 PM, Luis R. Rodriguez wrote: > >On Fri, Jan 22, 2016 at 04:35:48PM -0500, Boris Ostrovsky wrote: > >>HVMlite guests (to be introduced in subsequent patches) share most > >>of the kernel initialization code with PV(H). > >> > >>Signed-off-by: Boris Ostrovsky > >>--- > >> arch/x86/xen/enlighten.c | 225 ++++++++++++++++++++++++---------------------- > >> 1 files changed, 119 insertions(+), 106 deletions(-) > >> > >>diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c > >>index d09e4c9..2cf446a 100644 > >>--- a/arch/x86/xen/enlighten.c > >>+++ b/arch/x86/xen/enlighten.c > >Whoa, I'm lost, its hard for me to tell what exactly stayed and what > >got pulled into a helper, etc. Is there a possibility to split this > >patch in 2 somehow to make the actual functional changes easier to > >read? There are too many changes here and I just can't tell easily > >what's going on. > > > The only real changes that this patch introduces is it reorders some > of the operations that used to be in xen_start_kernel(). This is > done so that in the next patch when we add hvmlite we can easily put > those specific to PV(H) inside 'if (!xen_hvm_domain())'. I probably > should have said so in the commit message. Ah, I see thanks. > It is indeed difficult to review but I don't see how I can split > this. Even if I just moved it (without reordering) it would still be > hard to read. A code shuffle but yet introducing non-functional changes as you did in some other patches might help if possible, but sure if you can say this is non-functional here or if you can split this up. Luis