From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 22 Jan 2016 21:01:02 -0500 From: Matthew Wilcox Subject: Re: [RFC PATCH] dax, ext2, ext4, XFS: fix data corruption race Message-ID: <20160123020102.GG2948@linux.intel.com> References: <1453503971-5319-1-git-send-email-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453503971-5319-1-git-send-email-ross.zwisler@linux.intel.com> Sender: linux-ext4-owner@vger.kernel.org To: Ross Zwisler Cc: linux-kernel@vger.kernel.org, Theodore Ts'o , Alexander Viro , Andreas Dilger , Andrew Morton , Dan Williams , Dave Chinner , Jan Kara , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, xfs@oss.sgi.com List-ID: On Fri, Jan 22, 2016 at 04:06:11PM -0700, Ross Zwisler wrote: > +++ b/fs/block_dev.c > @@ -1733,13 +1733,28 @@ static const struct address_space_operations def_blk_aops = { > */ > static int blkdev_dax_fault(struct vm_area_struct *vma, struct vm_fault *vmf) > { > - return __dax_fault(vma, vmf, blkdev_get_block, NULL); > + int ret; > + > + ret = __dax_fault(vma, vmf, blkdev_get_block, NULL, false); > + > + if (WARN_ON_ONCE(ret == -EAGAIN)) > + ret = VM_FAULT_SIGBUS; > + > + return ret; > } Let's not mix up -E returns and VM_FAULT returns. We already have a perfectly good VM_FAULT return value -- VM_FAULT_RETRY. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755691AbcAWCBq (ORCPT ); Fri, 22 Jan 2016 21:01:46 -0500 Received: from mga04.intel.com ([192.55.52.120]:51225 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755569AbcAWCBF (ORCPT ); Fri, 22 Jan 2016 21:01:05 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,334,1449561600"; d="scan'208";a="732672491" Date: Fri, 22 Jan 2016 21:01:02 -0500 From: Matthew Wilcox To: Ross Zwisler Cc: linux-kernel@vger.kernel.org, "Theodore Ts'o" , Alexander Viro , Andreas Dilger , Andrew Morton , Dan Williams , Dave Chinner , Jan Kara , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nvdimm@ml01.01.org, xfs@oss.sgi.com Subject: Re: [RFC PATCH] dax, ext2, ext4, XFS: fix data corruption race Message-ID: <20160123020102.GG2948@linux.intel.com> References: <1453503971-5319-1-git-send-email-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453503971-5319-1-git-send-email-ross.zwisler@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2016 at 04:06:11PM -0700, Ross Zwisler wrote: > +++ b/fs/block_dev.c > @@ -1733,13 +1733,28 @@ static const struct address_space_operations def_blk_aops = { > */ > static int blkdev_dax_fault(struct vm_area_struct *vma, struct vm_fault *vmf) > { > - return __dax_fault(vma, vmf, blkdev_get_block, NULL); > + int ret; > + > + ret = __dax_fault(vma, vmf, blkdev_get_block, NULL, false); > + > + if (WARN_ON_ONCE(ret == -EAGAIN)) > + ret = VM_FAULT_SIGBUS; > + > + return ret; > } Let's not mix up -E returns and VM_FAULT returns. We already have a perfectly good VM_FAULT return value -- VM_FAULT_RETRY. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [RFC PATCH] dax, ext2, ext4, XFS: fix data corruption race Date: Fri, 22 Jan 2016 21:01:02 -0500 Message-ID: <20160123020102.GG2948@linux.intel.com> References: <1453503971-5319-1-git-send-email-ross.zwisler@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Theodore Ts'o , linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Andreas Dilger , Alexander Viro , Jan Kara , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-ext4@vger.kernel.org, Dan Williams To: Ross Zwisler Return-path: Content-Disposition: inline In-Reply-To: <1453503971-5319-1-git-send-email-ross.zwisler@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com List-Id: linux-ext4.vger.kernel.org On Fri, Jan 22, 2016 at 04:06:11PM -0700, Ross Zwisler wrote: > +++ b/fs/block_dev.c > @@ -1733,13 +1733,28 @@ static const struct address_space_operations def_blk_aops = { > */ > static int blkdev_dax_fault(struct vm_area_struct *vma, struct vm_fault *vmf) > { > - return __dax_fault(vma, vmf, blkdev_get_block, NULL); > + int ret; > + > + ret = __dax_fault(vma, vmf, blkdev_get_block, NULL, false); > + > + if (WARN_ON_ONCE(ret == -EAGAIN)) > + ret = VM_FAULT_SIGBUS; > + > + return ret; > } Let's not mix up -E returns and VM_FAULT returns. We already have a perfectly good VM_FAULT return value -- VM_FAULT_RETRY. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs