From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] package/sqlite: add optional support for libedit
Date: Sat, 23 Jan 2016 13:10:48 +0100 [thread overview]
Message-ID: <20160123131048.579f660b@free-electrons.com> (raw)
In-Reply-To: <1453544625-30597-4-git-send-email-bernd.kuhls@t-online.de>
Dear Bernd Kuhls,
On Sat, 23 Jan 2016 11:23:45 +0100, Bernd Kuhls wrote:
> diff --git a/package/sqlite/Config.in b/package/sqlite/Config.in
> index 7ea9eb1..31add17 100644
> --- a/package/sqlite/Config.in
> +++ b/package/sqlite/Config.in
> @@ -8,13 +8,25 @@ config BR2_PACKAGE_SQLITE
>
> if BR2_PACKAGE_SQLITE
>
> +choice
> + prompt "Command-line editing"
> + default BR2_PACKAGE_SQLITE_READLINE
> + help
> + Enable command-line editing.
> +
> +config BR2_PACKAGE_SQLITE_LIBEDIT
> + bool "libedit"
> + select BR2_PACKAGE_LIBEDIT
> +
> config BR2_PACKAGE_SQLITE_READLINE
> - bool "Command-line editing"
> + bool "readline"
> select BR2_PACKAGE_NCURSES
> select BR2_PACKAGE_READLINE
> help
> Enable command-line editing. This requires ncurses and readline.
I am not sure I like adding a choice for such a simple thing.
Config.in choices are not randomized in our build testing.
What about instead dropping the BR2_PACKAGE_SQLITE_READLINE option, and
automatically enable readline/libedit support in sqlite when the
corresponding packages are enabled ?
Peter, what do you think ?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-01-23 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 10:23 [Buildroot] [PATCH 1/4] package/sqlite: Disable autoreconf Bernd Kuhls
2016-01-23 10:23 ` [Buildroot] [PATCH 2/4] package/sqlite: Dynamically link libsqlite.so to bin/sqlite3 Bernd Kuhls
2016-01-23 10:23 ` [Buildroot] [PATCH 3/4] package/sqlite: Fix readline support Bernd Kuhls
2016-01-23 10:23 ` [Buildroot] [PATCH 4/4] package/sqlite: add optional support for libedit Bernd Kuhls
2016-01-23 12:10 ` Thomas Petazzoni [this message]
2016-01-23 13:10 ` Peter Korsgaard
2016-01-23 12:09 ` [Buildroot] [PATCH 1/4] package/sqlite: Disable autoreconf Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160123131048.579f660b@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.