From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: fix mv88e6xxx switches
Date: Sat, 23 Jan 2016 20:44:16 +0000 [thread overview]
Message-ID: <20160123204416.GC10826@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20160123201647.GH3880@lunn.ch>
On Sat, Jan 23, 2016 at 09:16:47PM +0100, Andrew Lunn wrote:
> On Sat, Jan 23, 2016 at 07:48:57PM +0000, Russell King - ARM Linux wrote:
> > On Sat, Jan 23, 2016 at 08:37:05PM +0100, Andrew Lunn wrote:
> > > I'm testing on a 6172. But 6172 and 6176 are both in the same family
> > > 6352, and share the same driver.
> >
> > Hmm, can't be that then.
> >
> > > So you initially have lan1 in an bridge. I don't.
>
> Running tcpdump on the device i'm trying to ping, there are ARP
> requests and replies. But the replies are never received by the
> target, arp -a shows <incomplete>.
>
> Looking at the stats counters in debugfs, the packets are counted in
> in_unicast, but also sw_in_filtered.
>
> Port 0 is lan0 and port 5 is the cpu port.
>
> root@370-rd:/sys/kernel/debug/dsa0# cat regs
> GLOBAL GLOBAL2 SERDES 0 1 2 3 4 5 6
> 0: c874 0 1940 1d0f 1d0f 1d0f 1d0f 100f e07 6
> 1: fa0 0 149 3 3 3 3 3 c03e 3
> 2: fa0 ffff 141 0 0 0 0 0 0 0
> 3: 0 ffff ea1 1721 1721 1721 1721 1721 1721 1721
> 4: 6000 258 1e0 433 433 433 433 433 373f 433
> 5: 3000 ff 0 0 0 0 0 0 0 0
> 6: fa0 1f0f 4 7f 7e 7d 7c 7b 7a 79
> 7: 3331 707f 2001 0 fa1 fa2 fa3 fa4 0 fa6
This shows port 0 is on vlan 0, but it should default to vlan 1 when
no vlans are configured. The patch below should at least allow some
diagnosis of what's being requested, and when.
diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
index a43354ed0607..8a9cf67eb16d 100644
--- a/drivers/net/dsa/mv88e6xxx.c
+++ b/drivers/net/dsa/mv88e6xxx.c
@@ -1511,6 +1511,9 @@ int mv88e6xxx_port_vlan_add(struct dsa_switch *ds, int port,
u16 vid;
int err = 0;
+ printk("%s: port %d vid %u-%u flags %x\n",
+ __func__, port, vlan->vid_begin, vlan->vid_end, vlan->flags);
+
mutex_lock(&ps->smi_mutex);
for (vid = vlan->vid_begin; vid <= vlan->vid_end; ++vid) {
--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-01-23 20:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 10:51 [PATCH] net: dsa: fix mv88e6xxx switches Russell King
2016-01-23 18:15 ` Andrew Lunn
2016-01-23 19:06 ` Russell King - ARM Linux
2016-01-23 19:37 ` Andrew Lunn
2016-01-23 19:48 ` Russell King - ARM Linux
2016-01-23 20:16 ` Andrew Lunn
2016-01-23 20:44 ` Russell King - ARM Linux [this message]
2016-01-23 22:12 ` Andrew Lunn
2016-01-23 22:23 ` Andrew Lunn
2016-01-23 23:31 ` Russell King - ARM Linux
2016-01-24 6:01 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160123204416.GC10826@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.