From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Richter Subject: Re: [PATCH v3 08/12] arm64, numa: rework numa_add_memblk() Date: Mon, 25 Jan 2016 10:34:29 +0100 Message-ID: <20160125093429.GD24726@rric.localdomain> References: <1453541967-3744-1-git-send-email-guohanjun@huawei.com> <1453541967-3744-9-git-send-email-guohanjun@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1453541967-3744-9-git-send-email-guohanjun@huawei.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Hanjun Guo Cc: Mark Rutland , Lorenzo Pieralisi , Steve Capper , "Rafael J. Wysocki" , Will Deacon , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Shannon Zhao , Catalin Marinas , Ganapatrao Kulkarni , linux-arm-kernel@lists.infradead.org, Hanjun Guo List-Id: linux-acpi@vger.kernel.org On 23.01.16 17:39:23, Hanjun Guo wrote: > Rework numa_add_memblk() to update the parameter "u64 size" > to "u64 end", this will make it consistent with x86 and > can simplify the code later. > --- a/arch/arm64/kernel/of_numa.c > +++ b/arch/arm64/kernel/of_numa.c > @@ -168,7 +168,7 @@ static int __init early_init_parse_memory_node(unsigned long node) > pr_debug("NUMA-DT: base = %llx , node = %u\n", > base, nid); > > - if (numa_add_memblk(nid, base, size) < 0) > + if (numa_add_memblk(nid, base, base + size) < 0) The overall function usage looks more like as it should use size instead of end. Even in the x86 implementation end is calculated from base + size. So better change x86 code to use size instead. Though this might involve to change the interface for numa_add_memblk_to() for unifcation too. -Robert From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932335AbcAYKH7 (ORCPT ); Mon, 25 Jan 2016 05:07:59 -0500 Received: from mail-bl2on0090.outbound.protection.outlook.com ([65.55.169.90]:15520 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932290AbcAYKHv (ORCPT ); Mon, 25 Jan 2016 05:07:51 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Robert.Richter@caviumnetworks.com; Date: Mon, 25 Jan 2016 10:34:29 +0100 From: Robert Richter To: Hanjun Guo CC: "Rafael J. Wysocki" , Will Deacon , Catalin Marinas , , , , Ganapatrao Kulkarni , Lorenzo Pieralisi , Shannon Zhao , "Steve Capper" , Mark Rutland , "Hanjun Guo" Subject: Re: [PATCH v3 08/12] arm64, numa: rework numa_add_memblk() Message-ID: <20160125093429.GD24726@rric.localdomain> References: <1453541967-3744-1-git-send-email-guohanjun@huawei.com> <1453541967-3744-9-git-send-email-guohanjun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1453541967-3744-9-git-send-email-guohanjun@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [92.224.194.101] X-ClientProxiedBy: AM2PR03CA0041.eurprd03.prod.outlook.com (25.160.207.51) To BLUPR0701MB1604.namprd07.prod.outlook.com (25.163.84.153) X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB1604;2:ptPB5x6mRFY76PHgWI9NC5fKUpCVf7EesKvQKC2CTe92F07Gz1Ju1QRNMvVN7O9WEZ8vHGXLVwRQ91FwXC/n5wRLS8wxOv6tOYVO8KkwqjQO45P6FnYyG5aqdDIwFvh2XOjRvWAdRNKGmGx5gXCOjQ==;3:b84GcDihCUtzJhz2RVbkCJvzjjD23FVVaJouDyTZMfqXUzdLfG/nMaDTdqUWUo7XA2MG3DNiARJ6IwfC1yPgAsPiVVEpwC8ZFKKdBzpv7lYo2kBo9PIJU4VfjXZQPGkg;25:irGZBPEHHqK6O6HRqLxiVGmlI0ATw3l5cs1RfLKdPv8tWeV1Clx9HqhOo0SOlxb+NJzcnzJpVUR11cjVtIMC6us54tVJK5Oza+fMinmG9+k5ebkqgfw/4VOWFvhCEpZV49PXLNwHFFX7ovvFMiU220efTY6q7nqjHTJd+GwHkN2gQD6Hl7c9FRsiicNzjxJqyAaa3/fjyvT5g25UVK0Jrl/snTnSb5BceGsL+yNZGIA9OBNgQySAmrorbHT9yKRh X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1604; X-MS-Office365-Filtering-Correlation-Id: bd4428a2-ed55-4395-514d-08d3256ac255 X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB1604;20:tVP97e+Vr93JrDa0VGi2kw++OpQgak5z+pJylGInrodv9Ro+9LJE3svoK6/gOnag2A1Zf8PUI2qFyQIqYdJv5M02ok3WMomFh1yFHGTrk2wlf9UKTNomTkPJMr9Xw2I2+IghzRXlLCm0OSVKm7DtKxTcD73ZWnikXAVtAV1j2aIiqcqVLdtWs7tHE2FAJElmkihmCAQYLJmqBeSrOX/dwbMopwCkCHRb1+3iSeCQTNY1d7gme2WQzQfvUUxCTAm63kWXCBhnJRoo0fgNIB/qINQWK2j35gn6dnf6051IRFXOSkI/iUONgGhlUD3wKddqU2Hs9tCJdC0vb4OleEtJiIAnNToX6PxICWpIQNBueD2QMURUFEecOh8XwWC9FjifyP04Z5YhHSdP7U6mx/j4hq8H4vPNiUw9rm5OSDtgzR1Dg2bZyXXoit/CShACyn0xu9ZS2ioBhr2TF7hPz+dGL+oD7JIGoaYPCXfc6s+lOK8gQDJcjzc2gQcNoVOJjlqAQ0qq1hICZaNpkh0CzSXNaGw7mRTWuar3qCCKp0hKB7GUt4R23W4gSi5/wS3X+kB4Zkhd2zXgBTb/8ieVWyca/QP7c9sn8aUnACn0jqVY+5I= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(3002001)(10201501046);SRVR:BLUPR0701MB1604;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1604; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB1604;4:odDCI5GZm507jYCkB1cK+kM2xR9Gw89SpRGNGHMWbR1ng5lO/DnB+nF4Ld3yT+gFyjLRD1Vx5D+Dv//hLd/ALcchOx9RxLPc16pVXIR0xPr0mh5dA7V8tLezAG302+8GCsJM95XaDQlWVd0Z1R7cJrqYjWY2laIKLYEZ+ejw8dEL1Lx0Cu8uQe9k168bSW9Lz1ywKoyERm11SP4cyWB5A9uwkBEOh+VzdhdhaMLuS3+rVTSvCzgXdjqDpR/wSmztfMZcv07YH1kcrhenQuN4kZ4gMudw1uVEIOtVlqLrc1bRqBD11E/zkyUgbaDkA8i/VCFZm5D3la2y+79KkgD0w6+z5ujTe7xd3iok+yZZH1afg9x/p362kveZge91GYKT X-Forefront-PRVS: 083289FD26 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(189002)(24454002)(199003)(4326007)(97756001)(2906002)(87976001)(42186005)(83506001)(50466002)(122386002)(86362001)(40100003)(92566002)(46406003)(5004730100002)(6116002)(1096002)(23726003)(110136002)(5001960100002)(77096005)(2950100001)(54356999)(3846002)(81156007)(97736004)(33656002)(4001350100001)(1076002)(189998001)(66066001)(101416001)(47776003)(50986999)(76176999)(106356001)(586003)(5008740100001)(105586002);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR0701MB1604;H:rric.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR0701MB1604;23:zIKHUqrHkK1d1n47QjezMBCkApguVZBpv5IFLcQ?= =?us-ascii?Q?1QSGVJQ8eGeU2czUxX8rYOVjVMvLuOyidKTpBAM4SwrulJJN/sNsFa+yIO8u?= =?us-ascii?Q?K5ThZNodtx3ThyGpAWK1bOybv/SHWfovpHkAGhiJ6Woq/EVY2YsnvZNkzHDi?= =?us-ascii?Q?CRboCMZQHBKoIo9yocOjdpS+cT9OY1M6OeySAKEH1begrEOWy+xvUtfIBHkR?= =?us-ascii?Q?frZsC7qo9HxVicgwhYqgCCaM/Wvi0uvWOxrI8iTXhQS3HHGrbUJ3uHI9Poz7?= =?us-ascii?Q?0LdgxIwOYhTZ/i2XtYtFIiEsbf4CiJ/U5pHJvxSR+dTIwbif0ZIRuywyAok/?= =?us-ascii?Q?QqCf9N3p3pzlbIX1gc2L4fnW51OhJIqxlMfJfFwSnou6UVismkXhUC+D4chW?= =?us-ascii?Q?R2KZTMi2dp6bPMLkYQqEhHoqqTUq5uhf5j2lM16kqH1DKEPdCmt80xEu+mpj?= =?us-ascii?Q?DhZkOdQH+LdQGMe0DHW35sQ287Pefa1J8r87MQ8ecHqXithCxb97oS3Kf+mJ?= =?us-ascii?Q?ozFss3CtEoae3CYuiGTH0SxVqYHZ9agqZEhEWvKsm/zk8wfzZs0XYdD9sg9a?= =?us-ascii?Q?T3seXCFtMA5dNkYAZ2BNsDl4hG4VBOV1JplZja9NvnpWfMZdLGXs/lqXDoRN?= =?us-ascii?Q?eZPNSdGlrGD6epIsE0SmakeeGJ6saZXAkEn3h04Y4rTdE0BbT4jBVOoVErYr?= =?us-ascii?Q?tlpg+JfNgr59/Qf0T2kwS1g3iYjEkGHNMPg0pGdFpwFMHseRRAUe0PylDmfR?= =?us-ascii?Q?veME7Wn/qaMVwq/T14FtdY+zmGhl27TUD0YZs7gnUkMl5lXCRTqxK8sqtMkk?= =?us-ascii?Q?UYNQH7rro8x/Reru2pf4CEfH9nut5dPE4qs0tokRJLvOJeId2Sp4v3MZaw4C?= =?us-ascii?Q?3d0z8Y6/nx17YfAJe7ddHSji9sz83IgweYYNWpEZzvQpx6lhZdGmjXjha8pK?= =?us-ascii?Q?iQKk5ox2TPO4RuNwPyyo1la7z0zZK9IbMiv+hSLS2O8y16nf7qVaSA+4TXqO?= =?us-ascii?Q?Q4aWHnO6tOvFN39A/xDgUTGiB6zQrMrc4O4tBlntj6sT1eT/2kmlTdCjJ5li?= =?us-ascii?Q?xu+5UoyVo9zP/PxNY4LgDg/bvuj+8?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB1604;5:J2VxMxlEptc8uomHzqmMEvurCBdqTvNmINiWMdEw7iBMR2GMMiriWBNulC2QUIZVjAoFFCJxjA31yPNFnPQVvMJT33ZKG9qOWWJMo3k2/zGtyxr+IIiJ0o6w5Im8ryyGu1SuZRocgbAyuLLrtnxbnQ==;24:/w9u2bYuljKXXLDtRfjKDixP15BSBV5P+4ILt4insM60zNvhjLA6XKUyqOJNRD9Y+B+tI5oCr1z0MvkwoXLOhMnuLCGqDYNBiiAXKlzPAhc= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2016 09:34:42.5253 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1604 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23.01.16 17:39:23, Hanjun Guo wrote: > Rework numa_add_memblk() to update the parameter "u64 size" > to "u64 end", this will make it consistent with x86 and > can simplify the code later. > --- a/arch/arm64/kernel/of_numa.c > +++ b/arch/arm64/kernel/of_numa.c > @@ -168,7 +168,7 @@ static int __init early_init_parse_memory_node(unsigned long node) > pr_debug("NUMA-DT: base = %llx , node = %u\n", > base, nid); > > - if (numa_add_memblk(nid, base, size) < 0) > + if (numa_add_memblk(nid, base, base + size) < 0) The overall function usage looks more like as it should use size instead of end. Even in the x86 implementation end is calculated from base + size. So better change x86 code to use size instead. Though this might involve to change the interface for numa_add_memblk_to() for unifcation too. -Robert From mboxrd@z Thu Jan 1 00:00:00 1970 From: robert.richter@caviumnetworks.com (Robert Richter) Date: Mon, 25 Jan 2016 10:34:29 +0100 Subject: [PATCH v3 08/12] arm64, numa: rework numa_add_memblk() In-Reply-To: <1453541967-3744-9-git-send-email-guohanjun@huawei.com> References: <1453541967-3744-1-git-send-email-guohanjun@huawei.com> <1453541967-3744-9-git-send-email-guohanjun@huawei.com> Message-ID: <20160125093429.GD24726@rric.localdomain> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 23.01.16 17:39:23, Hanjun Guo wrote: > Rework numa_add_memblk() to update the parameter "u64 size" > to "u64 end", this will make it consistent with x86 and > can simplify the code later. > --- a/arch/arm64/kernel/of_numa.c > +++ b/arch/arm64/kernel/of_numa.c > @@ -168,7 +168,7 @@ static int __init early_init_parse_memory_node(unsigned long node) > pr_debug("NUMA-DT: base = %llx , node = %u\n", > base, nid); > > - if (numa_add_memblk(nid, base, size) < 0) > + if (numa_add_memblk(nid, base, base + size) < 0) The overall function usage looks more like as it should use size instead of end. Even in the x86 implementation end is calculated from base + size. So better change x86 code to use size instead. Though this might involve to change the interface for numa_add_memblk_to() for unifcation too. -Robert