From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756957AbcAYKGW (ORCPT ); Mon, 25 Jan 2016 05:06:22 -0500 Received: from ozlabs.org ([103.22.144.67]:56449 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754796AbcAYKGP (ORCPT ); Mon, 25 Jan 2016 05:06:15 -0500 Date: Mon, 25 Jan 2016 21:06:09 +1100 From: Paul Mackerras To: Michael Ellerman Cc: Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [kernel] powerpc: Make vmalloc_to_phys() public Message-ID: <20160125100609.GA24295@fergus.ozlabs.ibm.com> References: <1453361708-19422-1-git-send-email-aik@ozlabs.ru> <20160125054603.5D55B140326@ozlabs.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160125054603.5D55B140326@ozlabs.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 25, 2016 at 04:46:03PM +1100, Michael Ellerman wrote: > On Thu, 2016-21-01 at 07:35:08 UTC, Alexey Kardashevskiy wrote: > > This makes vmalloc_to_phys() public as there will be another user > > (in-kernel VFIO acceleration) for it soon. > > > > As a part of future little optimization, this changes the helper to call > > vmalloc_to_pfn() instead of vmalloc_to_page() as the size of the > > struct page may not be power-of-two aligned which will make gcc use > > multiply instructions instead of shifts. > > You should also mention why you need to export it, presumably because whatever > new user you have in mind can be built as a module. If I remember correctly, it's the *existing* user in hv-24x7.c that needs the export. Paul.