From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756626AbcAYLRx (ORCPT ); Mon, 25 Jan 2016 06:17:53 -0500 Received: from foss.arm.com ([217.140.101.70]:35965 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755674AbcAYLRv (ORCPT ); Mon, 25 Jan 2016 06:17:51 -0500 Date: Mon, 25 Jan 2016 11:18:24 +0000 From: Juri Lelli To: Viresh Kumar Cc: "Gautham R. Shenoy" , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Shilpasri G Bhat Subject: Re: [PATCH] cpufreq: Use list_is_last() to check last entry of the policy list Message-ID: <20160125111824.GH10898@e106622-lin> References: <1453715167-26165-1-git-send-email-ego@linux.vnet.ibm.com> <20160125095029.GE3183@vireshk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160125095029.GE3183@vireshk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 25/01/16 15:20, Viresh Kumar wrote: > On 25-01-16, 15:16, Gautham R. Shenoy wrote: > > Currently next_policy() explicitly checks if a policy is the last > > policy in the cpufreq_policy_list. Use the standard list_is_last > > primitive instead. > > > > Cc: Viresh Kumar > > Signed-off-by: Gautham R. Shenoy > > --- > > drivers/cpufreq/cpufreq.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > > index 78b1e2f..b3059a3 100644 > > --- a/drivers/cpufreq/cpufreq.c > > +++ b/drivers/cpufreq/cpufreq.c > > @@ -67,11 +67,11 @@ static struct cpufreq_policy *next_policy(struct cpufreq_policy *policy, > > { > > lockdep_assert_held(&cpufreq_driver_lock); Which branch is this patch based on? Thanks, - Juri > > do { > > - policy = list_next_entry(policy, policy_list); > > - > > /* No more policies in the list */ > > - if (&policy->policy_list == &cpufreq_policy_list) > > + if (list_is_last(&policy->policy_list, &cpufreq_policy_list)) > > return NULL; > > + > > + policy = list_next_entry(policy, policy_list); > > } while (!suitable_policy(policy, active)); > > > > return policy; > > Acked-by: Viresh Kumar > > -- > viresh >