From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNhgJ-0000tM-IW for qemu-devel@nongnu.org; Mon, 25 Jan 2016 08:59:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNhgI-00050S-7J for qemu-devel@nongnu.org; Mon, 25 Jan 2016 08:59:47 -0500 Date: Tue, 26 Jan 2016 01:00:38 +1100 From: David Gibson Message-ID: <20160125140038.GK32205@voom.redhat.com> References: <1453684527-23564-1-git-send-email-david@gibson.dropbear.id.au> <20160125111936.GI32205@voom.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DozTQjXnjm3C9Xhk" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Laurent Vivier , Thomas Huth , Mark Cave-Ayland , Alexander Graf , QEMU Developers , "qemu-ppc@nongnu.org" , "bharata@linux.vnet.ibm.com" , Greg Kurz --DozTQjXnjm3C9Xhk Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 25, 2016 at 11:59:22AM +0000, Peter Maydell wrote: > On 25 January 2016 at 11:19, David Gibson w= rote: > > I think I've fixed it, but it's a bit hard to tell since for me > > origin/master also fails to compile on 32-bit :(. >=20 > Oops -- what's the failure there? >=20 > (I do know of a vixl compile failure with older gcc you might be running > into; if that's it try configuring with --cxx=3Dnone. I should send a pat= ch > to fix that.) Doesn't look like it. Might be something to do with a specific glib version though: $ make -k CC qga/commands-posix.o qga/commands-posix.c: In function =E2=80=98qmp_guest_file_write=E2=80=99: qga/commands-posix.c:529:39: error: passing argument 3 of =E2=80=98qbase64_= decode=E2=80=99 from incompatible pointer type [-Werror=3Dincompatible-poin= ter-types] buf =3D qbase64_decode(buf_b64, -1, &buf_len, errp); ^ In file included from qga/commands-posix.c:32:0: /home/dwg/src/qemu/include/qemu/base64.h:52:10: note: expected =E2=80=98siz= e_t * {aka unsigned int *}=E2=80=99 but argument is of type =E2=80=98gsize = * {aka long unsigned int *}=E2=80=99 uint8_t *qbase64_decode(const char *input, ^ cc1: all warnings being treated as errors /home/dwg/src/qemu/rules.mak:57: recipe for target 'qga/commands-posix.o' f= ailed make: *** [qga/commands-posix.o] Error 1 CC util/base64.o util/base64.c: In function =E2=80=98qbase64_decode=E2=80=99: util/base64.c:59:35: error: passing argument 2 of =E2=80=98g_base64_decode= =E2=80=99 from incompatible pointer type [-Werror=3Dincompatible-pointer-ty= pes] return g_base64_decode(input, out_len); ^ In file included from /usr/include/glib-2.0/glib.h:35:0, from /home/dwg/src/qemu/include/glib-compat.h:19, from /home/dwg/src/qemu/include/qemu/osdep.h:72, from /home/dwg/src/qemu/include/qemu-common.h:15, from /home/dwg/src/qemu/include/qemu/base64.h:24, from util/base64.c:23: /usr/include/glib-2.0/glib/gbase64.h:52:9: note: expected =E2=80=98gsize * = {aka long unsigned int *}=E2=80=99 but argument is of type =E2=80=98size_t = * {aka unsigned int *}=E2=80=99 guchar *g_base64_decode (const gchar *text, ^ cc1: all warnings being treated as errors /home/dwg/src/qemu/rules.mak:57: recipe for target 'util/base64.o' failed make: *** [util/base64.o] Error 1 CC crypto/secret.o crypto/secret.c: In function =E2=80=98qcrypto_secret_load_data=E2=80=99: crypto/secret.c:47:55: error: passing argument 3 of =E2=80=98g_file_get_con= tents=E2=80=99 from incompatible pointer type [-Werror=3Dincompatible-point= er-types] if (!g_file_get_contents(secret->file, &data, &length, &gerr)) { ^ In file included from /usr/include/glib-2.0/glib.h:48:0, from /home/dwg/src/qemu/include/glib-compat.h:19, from /home/dwg/src/qemu/include/qemu/osdep.h:72, from /home/dwg/src/qemu/include/qemu-common.h:15, from /home/dwg/src/qemu/include/crypto/secret.h:24, from crypto/secret.c:21: /usr/include/glib-2.0/glib/gfileutils.h:85:10: note: expected =E2=80=98gsiz= e * {aka long unsigned int *}=E2=80=99 but argument is of type =E2=80=98siz= e_t * {aka unsigned int *}=E2=80=99 gboolean g_file_get_contents (const gchar *filename, ^ cc1: all warnings being treated as errors /home/dwg/src/qemu/rules.mak:57: recipe for target 'crypto/secret.o' failed make: *** [crypto/secret.o] Error 1 CC qemu-char.o qemu-char.c: In function =E2=80=98qmp_ringbuf_write=E2=80=99: qemu-char.c:3317:37: error: passing argument 3 of =E2=80=98qbase64_decode= =E2=80=99 from incompatible pointer type [-Werror=3Dincompatible-pointer-ty= pes] &write_count, ^ In file included from qemu-char.c:35:0: /home/dwg/src/qemu/include/qemu/base64.h:52:10: note: expected =E2=80=98siz= e_t * {aka unsigned int *}=E2=80=99 but argument is of type =E2=80=98gsize = * {aka long unsigned int *}=E2=80=99 uint8_t *qbase64_decode(const char *input, ^ cc1: all warnings being treated as errors /home/dwg/src/qemu/rules.mak:57: recipe for target 'qemu-char.o' failed make: *** [qemu-char.o] Error 1 CC vl.o vl.c: In function =E2=80=98parse_fw_cfg=E2=80=99: vl.c:2317:46: error: passing argument 3 of =E2=80=98g_file_get_contents=E2= =80=99 from incompatible pointer type [-Werror=3Dincompatible-pointer-types] if (!g_file_get_contents(file, &buf, &size, NULL)) { ^ In file included from /usr/include/glib-2.0/glib.h:48:0, from vl.c:59: /usr/include/glib-2.0/glib/gfileutils.h:85:10: note: expected =E2=80=98gsiz= e * {aka long unsigned int *}=E2=80=99 but argument is of type =E2=80=98siz= e_t * {aka unsigned int *}=E2=80=99 gboolean g_file_get_contents (const gchar *filename, ^ cc1: all warnings being treated as errors /home/dwg/src/qemu/rules.mak:57: recipe for target 'vl.o' failed make: *** [vl.o] Error 1 make: Target 'all' not remade because of errors. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --DozTQjXnjm3C9Xhk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWpiqGAAoJEGw4ysog2bOSdw8QAM+4I/hAeYGSYdnP0Sqs2QsA 5okH3f6wGHCLlYZC1yrYhRopOYwa2jZQGyuOIze5bMFVQMkmT8WmjHHwjUpodF2u sJ57yq80k4P3Lk6rW5bzZVbNdrqTNBUP8gZlezHbLh2UwLzTKjW+XHs+69DUsgyh MbI6nfsfcM1yZnpSQZE/M8BPFDhF26uq3fpo9h3LonhbNISvCwgGMpZIcyfSYUJ2 swrSkxDaLzi/rSZbWeqGK+hO1WP57wv+ilk9H8qbNokSAaw/9SURXegVirJESrbB XO/RSi65Tg/XawTfcB7s/+Ix5tyHgCCc3RQdVHJMAbHnYrjPm38mNjXl22k3GJpU jnz2vhse2wx0B759VIxFcfqBhLeKzT93ZH4Og5YJbepD08CUpqI15DCq2ALnn1qL tbXJc9Q4ffyxac84OyrPbRV1bXIBk8m1tN4kCHCwHny7qpI7iv6EZEo1kYKoHv92 LrzvMcUQ+kDd65XWdu/WiZ/CYSgE4Z0xTkg1C8Ibg0FGEzRm3U4GqHekgrWI+4SY 7zcDaeeKYIqaIvjQ8Ycr8CJgOScEWQpJ4kBaMaREMVZWgs7PCUGvPuEALeFHWXe0 nTZx7brodopPNVTW3P4PVYNJWFVk3HRd+TeUvgD7rEMx08D+/VgGlafiamrPgY4d zFDKsihVQsjkAMnB3bVK =9kCd -----END PGP SIGNATURE----- --DozTQjXnjm3C9Xhk--