From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757177AbcAYOob (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Jan 2016 09:44:31 -0500
Received: from foss.arm.com ([217.140.101.70]:37869 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756000AbcAYOo3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Jan 2016 09:44:29 -0500
Date: Mon, 25 Jan 2016 14:44:26 +0000
From: Javi Merino <javi.merino@arm.com>
To: Zhang Rui <rui.zhang@intel.com>, Eduardo Valentin <edubezval@gmail.com>
Cc: Nicolas Boichat <drinkcat@chromium.org>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Amit Daniel Kachhap <amit.kachhap@gmail.com>,
        Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH] thermal: cpu_cooling: fix out of bounds access in
 time_in_idle
Message-ID: <20160125144426.GD4718@e104805>
References: <1450529677-23426-1-git-send-email-javi.merino@arm.com>
 <20151221031940.GB5532@ubuntu>
 <20160105191925.GD3163@e104805>
 <20160115152055.GA2917@e104805>
 <CANMq1KCD0n1mdp2dU5mL5YZvk5SwMi+Nnwqr+c5Qi7FOPNg2PA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CANMq1KCD0n1mdp2dU5mL5YZvk5SwMi+Nnwqr+c5Qi7FOPNg2PA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 18, 2016 at 10:25:35AM +0800, Nicolas Boichat wrote:
> On Fri, Jan 15, 2016 at 11:20 PM, Javi Merino <javi.merino@arm.com> wrote:
> > Eduardo, Rui,
> >
> > On Tue, Jan 05, 2016 at 07:19:25PM +0000, Javi Merino wrote:
> >> On Mon, Dec 21, 2015 at 08:49:40AM +0530, Viresh Kumar wrote:
> >> > On 19-12-15, 12:54, Javi Merino wrote:
> >> > > In __cpufreq_cooling_register() we allocate the arrays for time_in_idle
> >> > > and time_in_idle_timestamp to be as big as the number of cpus in this
> >> > > cpufreq device.  However, in get_load() we access this array using the
> >> > > cpu number as index, which can result in an out of bound access.
> >> > >
> >> > > Index time_in_idle{,_timestamp} using the index in the cpufreq_device's
> >> > > allowed_cpus mask, as we do for the load_cpu array in
> >> > > cpufreq_get_requested_power()
> >> > >
> >> > > Reported-by: Nicolas Boichat <drinkcat@chromium.org>
> >> > > Cc: Amit Daniel Kachhap <amit.kachhap@gmail.com>
> >> > > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> >> > > Cc: Zhang Rui <rui.zhang@intel.com>
> >> > > Cc: Eduardo Valentin <edubezval@gmail.com>
> >> > > Signed-off-by: Javi Merino <javi.merino@arm.com>
> >> > > ---
> >> > >  drivers/thermal/cpu_cooling.c | 14 ++++++++------
> >> > >  1 file changed, 8 insertions(+), 6 deletions(-)
> >> >
> >> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> >>
> >> If there are no more objections, can you pick this up?
> >
> > Another gentle ping, can this be merged?
> 
> Tested-by: Nicolas Boichat <drinkcat@chromium.org>

Eduardo, Rui,

This has been in the list for more than a month now.  It fixes an out
of bounds access.  It has been acked by Viresh (comaintainer of
cpu_cooling) and has been tested by Nicolas.  Can you guys merge it
please?

Cheers,
Javi