From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Make wa_tail_dwords flexible for future platforms. Date: Tue, 26 Jan 2016 14:06:48 +0000 Message-ID: <20160126140648.GL8281@nuc-i3427.alporthouse.com> References: <1453750159-26475-1-git-send-email-rodrigo.vivi@intel.com> <20160125211715.GA9621@nuc-i3427.alporthouse.com> <20160126082958.GC32190@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B9AD6E224 for ; Tue, 26 Jan 2016 06:06:58 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKYW4gMjYsIDIwMTYgYXQgMDE6NTE6MTlQTSArMDAwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+ICAgIE9uIFR1ZSwgSmFuIDI2LCAyMDE2IGF0IDEyOjMwIEFNIENocmlzIFdpbHNvbgo+ ICAgIDxbMV1jaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyb3RlOgo+IAo+ICAgICAgT24gTW9u LCBKYW4gMjUsIDIwMTYgYXQgMDk6MTc6MTVQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+ ICAgICAgPiBPbiBNb24sIEphbiAyNSwgMjAxNiBhdCAxMToyOToxOUFNIC0wODAwLCBSb2RyaWdv IFZpdmkgd3JvdGU6Cj4gICAgICA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf bHJjLmMKPiAgICAgID4gPiBAQCAtNzY0LDE4ICs3NjQsMTggQEAgaW50ZWxfbG9naWNhbF9yaW5n X2FkdmFuY2VfYW5kX3N1Ym1pdChzdHJ1Y3QKPiAgICAgIGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpy ZXF1ZXN0KQo+ICAgICAgPiA+wqAgewo+ICAgICAgPiA+wqAgwqAgwqBzdHJ1Y3QgaW50ZWxfcmlu Z2J1ZmZlciAqcmluZ2J1ZiA9IHJlcXVlc3QtPnJpbmdidWY7Cj4gICAgICA+ID7CoCDCoCDCoHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHJlcXVlc3QtPmk5MTU7Cj4gICAgICA+ ID4gK8KgIMKgaW50IGk7Cj4gICAgICA+ID4KPiAgICAgID4gPsKgIMKgIMKgaW50ZWxfbG9naWNh bF9yaW5nX2FkdmFuY2UocmluZ2J1Zik7Cj4gICAgICA+ID7CoCDCoCDCoHJlcXVlc3QtPnRhaWwg PSByaW5nYnVmLT50YWlsOwo+ICAgICAgPiA+Cj4gICAgICA+ID7CoCDCoCDCoC8qCj4gICAgICA+ ID4gLcKgIMKgICogSGVyZSB3ZSBhZGQgdHdvIGV4dHJhIE5PT1BzIGFzIHBhZGRpbmcgdG8gYXZv aWQKPiAgICAgID4gPiArwqAgwqAgKiBIZXJlIHdlIGFkZCBleHRyYSBOT09QcyBhcyBwYWRkaW5n IHRvIGF2b2lkCj4gICAgICA+ID7CoCDCoCDCoCAqIGxpdGUgcmVzdG9yZSBvZiBhIGNvbnRleHQg d2l0aCBIRUFEPT1UQUlMLgo+ICAgICAgPiA+IC3CoCDCoCAqCj4gICAgICA+ID4gLcKgIMKgICog Q2FsbGVyIG11c3QgcmVzZXJ2ZSBXQV9UQUlMX0RXT1JEUyBmb3IgdXMhCj4gICAgICA+ID7CoCDC oCDCoCAqLwo+ICAgICAgPiA+IC3CoCDCoGludGVsX2xvZ2ljYWxfcmluZ19lbWl0KHJpbmdidWYs IE1JX05PT1ApOwo+ICAgICAgPiA+IC3CoCDCoGludGVsX2xvZ2ljYWxfcmluZ19lbWl0KHJpbmdi dWYsIE1JX05PT1ApOwo+ICAgICAgPiA+ICvCoCDCoGZvciAoaSA9IDA7IGkgPCByaW5nYnVmLT53 YV90YWlsX2R3b3JkczsgaSsrKQo+ICAgICAgPiA+ICvCoCDCoCDCoCDCoCDCoCDCoGludGVsX2xv Z2ljYWxfcmluZ19lbWl0KHJpbmdidWYsIE1JX05PT1ApOwo+ICAgICAgPiA+ICsKPiAgICAgID4g PsKgIMKgIMKgaW50ZWxfbG9naWNhbF9yaW5nX2FkdmFuY2UocmluZ2J1Zik7Cj4gICAgICA+ID4K PiAgICAgID4gPsKgIMKgIMKgaWYgKGludGVsX3Jpbmdfc3RvcHBlZChyZXF1ZXN0LT5yaW5nKSkK PiAgICAgID4gPiBAQCAtODc2LDYgKzg3NiwxNiBAQCBpbnQgaW50ZWxfbG9naWNhbF9yaW5nX2Jl Z2luKHN0cnVjdAo+ICAgICAgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwgaW50IG51bV9kd29y ZHMpCj4gICAgICA+ID7CoCDCoCDCoGlmIChyZXQpCj4gICAgICA+ID7CoCDCoCDCoCDCoCDCoCDC oCDCoHJldHVybiByZXQ7Cj4gICAgICA+ID4KPiAgICAgID4gPiArwqAgwqBpZiAoSVNfR0VOOChy ZXEtPnJpbmctPmRldikgfHwgSVNfR0VOOShyZXEtPnJpbmctPmRldikpCj4gICAgICA+Cj4gICAg ICA+IHJlcS0+aTkxNQo+ICAgICAgPgo+ICAgICAgPiBUaGlzIGlzIGF0dHJvY2lvdXMuIEp1c3Qg YWxsb2NhdGUgdGhlIGV4dHJhIHNwYWNlIHdoZW4gcmVxdWlyZWQuCj4gCj4gICAgYnkgdGhpcyBs b2dpYyBJIHNob3VsZCBqdXN0IGVtaXQgdGhlIG1pX25vb3BzIHdoZW4gcmVxdWlyZWQgYXMgd2Vs bCwKPiAgICByaWdodD8KClllcywgSSBkaWRuJ3QgbGlrZSB0aGUgcGxhY2VtZW50IG9mIHRoZSB3 YV90YWlsIGJ1dCBJIHdlbnQgd2l0aCB0aGF0IHRvCmF2b2lkIHRoZSBjb2RlIGR1cGxpY2F0aW9u LgoKPiAgICAgIFNsaWdodGx5IGxlc3MgZ3J1bXB5IHRoaXMgbW9ybmluZy4KPiAKPiAgICB0aGFu a3PCoAo+IAo+ICAgICAgMS4gVGhpcyBpcyBkdXBsaWNhdGluZyB0aGUgcmVzZXJ2ZWQtc3BhY2Ug bWVjaGFuaXNtLCBieSBvcGVuLWNvZGluZyB0aGUKPiAgICAgIHJlcXVpcmVtZW50cyBmb3IgZXhl Y2xpc3RzLiBGaW5lLXR1bmluZyB0aGUgcmVzZXJ2ZWQgc3BhY2UgcGVyIHJpbmcgbWF5Cj4gICAg ICBiZSB3b3J0aCBpdCwgYnV0IHByb2JhYmx5IG5vdC4gT3ZlciByZXNlcnZpbmcgc3BhY2UgaXMg bm90IGEgaHVuZyBpc3N1ZQo+ICAgICAgKGl0IGp1c3QgZWZmZWN0aXZlbHkgcmVkdWNlcyB0aGUg c2l6ZSBvZiB0aGUgcmluZyksIGFuZCB0aGUgZ3JhbnVsYXJpdHkKPiAgICAgIGlzIHRoZSBzaXpl IG9mIHRoZSBhdmVyYWdlIHJlcXVlc3QuCj4gCj4gICAgZm9yZ2l2ZSB0aGlzIGNsdWVsZXNzIG1p bmQgaGVyZSwgYnV0IEkgZG9uJ3Qgc2VlIGhvdyBJJ20gZHVwbGljYXRpbmcgdGhlCj4gICAgcmVz ZXJ2ZWQtc3BhY2UuLi7CoAoKWW91IGFyZSBleHRlbmRpbmcgZXZlcnkgYmVnaW4gYnkgdGhlIG92 ZXJhbGxvY2F0aW9uIHJlcXVpcmVkIHRvIGVtaXQKdGhlIHRhaWwgZHdvcmRzLiBXZSBhbHJlYWR5 IGV4dGVuZCBldmVyeSBiZWdpbiBieSB0aGUgb3ZlcmFsbG9jYXRpb24KcmVxdWlyZWQgdG8gZW1p dCB0aGUgcmVxdWVzdCAodW50aWwgd2UgY29tZSB0byBlbWl0IHRoZSByZXF1ZXN0LCB3aGVyZQp0 aGVyZSBpcyBubyBtb3JlIG92ZXJhbGxvY2F0aW9uIGFwcGxpZWQpLgoKPiAgICAgIDIuIFlvdSBh cmUgaGlkaW5nIGhvdyBtdWNoIHNwYWNlIGlzIGFjdHVhbGx5IHVzZWQgZHVyaW5nIHJlcXVlc3QK PiAgICAgIGVtaXNzaW9uLiBUaGlzIG1ha2VzIHJldmlldyBpbXBvc3NpYmxlLCBhbmQgd2UgZGVw ZW5kIHVwb24gcmV2aWV3IHRvCj4gICAgICB2ZXJpZnkgdGhhdCB0aGUgaW50ZWxfcmluZ19iZWdp bigpIG1hdGNoZXMgdGhlIG51bWJlciBvZiBkd29yZHMgZW1pdHRlZC4KPiAKPiAgICBidXQgdGhl IG1pX25vb3BzIGFyZSBoaWRkZW4gb24gdGhlIHN1Ym1pdCBhbmQgYWR2YW5jZS4uLiBzaG91bGRu J3Qgd2UgbW92ZQo+ICAgIGl0IGJhY2sgdG8gdGhlIHBsYWNlcyB0aGF0IGFsbG9jYXRlcyBpdC4K CkhlbmNlIHdoeSBJIHN0cmVzc2VkIHRoYXQgaW4gdGhlIGNvbW1lbnRzIC0gYnV0IGl0IGlzIGEg dGFpbCBjYWxsLCBqdXN0CnJlYWQgaXQgYXMgb25lIGZ1bmN0aW9uLiBUaGUgaW1wb3J0YW50IHNl cXVlbmNlIGlzIHRoYXQKCmludGVsX3JpbmdfYmVnaW4oY291bnQpCi4uLgpjb3VudCB4IGludGVs X3JpbmdfZW1pdAouLi4KaW50ZWxfcmluZ19hZHZhbmNlKCkKCmlzIGNsZWFyIHRvIHRoZSByZWFk ZXIuIFllcywgdGhpcyBicmVha3MgdGhhdCBydWxlIGJ5IHJlcGxhY2luZwppbnRlbF9yaW5nX2Fk dmFuY2UoKSB3aXRoIGEgY3VzdG9tIGxyX3JpbmdfYWR2YW5jZV9hbmRfc3VibWl0KCkgYW5kCnBl cmhhcHMgaXQgd291bGQgYmUgY2xlYXJlciB0byBhZGQgbHJfcmluZ19iZWdpbl9mb3Jfc3VibWl0 KCkgb3IKc29tZXRoaW5nIHRvIHN0cmVzcyB0aGUgc2xpZ2h0IGRpc2NyZXBhbmN5LCBidXQgc3Rp bGwgbWFrZSB0aGUgcGFpcmluZwpjbGVhci4KCj4gICAgICAzLiBJcyB0aGlzIGV2ZW4gdGhlIHJp Z2h0IG1lY2hhbmlzbSBjb25zaWRlcmluZyB0aGUgbnVtYmVyIG9mIG90aGVyIHdheXMKPiAgICAg IG9mIGF1dG9tYXRpY2FsbHkgZW1pdHRpbmcgaW5zdHJ1Y3Rpb25zIGJldHdlZW4gYmF0Y2hlcyBh bmQgY29udGV4dHM/IFdlCj4gICAgICBjYW5ub3QgYW5zd2VyIHRoYXQgYXMgdGhpcyBwYXRjaCBp cyBvdXQgb2YgY29udGV4dC4KPiAKPiAgICB5ZWFwLCBzb3JyeSBhZ2FpbiwgSSB3YXMganVzdCBn b2luZyB0byB0aGUgZWFzaWVzdCBwYXRoIHRvIGJlIGFibGUgdG8KPiAgICBhdm9pZCB0aGUgbnVs bHMgcGVyIHBsYXRmb3JtIHdpdGhvdXQgYWRkaW5nIDMgaWZzLi4KPiAgICBCdXQgSSB3b25kZXIg aWYgeW91IG1lYW4gb24gY29tbWVudCAiMS4iIHRoYXQgd2UgY2FuIGxpdmUgd2l0aAo+ICAgIFdB X1RBSUxfRFdPUkRTIDIgYW5kIGF2b2lkIG9ubHkgdGhlIE5VTExzIHdoZW4gbmVlZGVkLi4uIElz IHRoaXMgdGhlIGNhc2U/CgpJZiB5b3Ugd2FudCBtb3JlIGR3b3JkcyBpbiB0aGUgYWRkX3JlcXVl c3QgY2FsbGJhY2ssIHdlIG5lZWQgdG8gYWRkCnRob3NlIHRvIHRoZSBNSU5fU1BBQ0VfRk9SX0FE RF9SRVFVRVNULiBJZiB3ZSBuZWVkIHRvIGFkZCBhIGxvdCwgdGhlbgptYWtpbmcgaXQgdmFyaWFi bGUgc2VlbXMgZmluZSAtIGJ1dCBpdCBzaG91bGQganVzdCBob29rIGludG8gdGhlIGNvbW1vbgpt ZWNoYW5pc20gaS5lLiB0aGUgbWluaW11bSBzcGFjZSBzaG91bGQgYmUgY29tcHV0ZWQgZHVyaW5n IGVuZ2luZQppbml0aWFsaXNhdGlvbiBhbmQgdGhlIHJlc2VydmF0aW9uIGFwcGxpZWQgYXQgaTkx NV9nZW1fZWVxdWVzdF9hbGxvYygpLgotQ2hyaXMKCi0tIApDaHJpcyBXaWxzb24sIEludGVsIE9w ZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudHJlCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==