From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] dt: new package
Date: Tue, 26 Jan 2016 21:58:33 +0100 [thread overview]
Message-ID: <20160126215833.1afdb8dc@free-electrons.com> (raw)
In-Reply-To: <1453840823-24345-1-git-send-email-gustavo.zacarias@free-electrons.com>
Gustavo,
On Tue, 26 Jan 2016 17:40:23 -0300, gustavo.zacarias at free-electrons.com
wrote:
> +# uClibc doesn't provide POSIX AIO
> +ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),)
> +DT_AIO_FLAG = -DAIO
> +endif
I think this one should rather be:
ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),y)
...
endif
> +define DT_BUILD_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/$(DT_SUBDIR) -f Makefile.linux \
> + CC="$(TARGET_CC)" \
> + CFLAGS="$(TARGET_CFLAGS) -std=c99 $(DT_AIO_FLAG) -DMMAP -D__linux__ -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -DTHREADS -DSCSI" \
> + LDFLAGS="$(TARGET_LDFLAGS)" \
> + OS=linux
Can you use TARGET_CONFIGURE_OPTS here instead ?
Maybe something like:
DT_CFLAGS = \
-std=c99 \
$(DT_AIO_FLAG) \
-DMMAP \
-D__linux__ \
-D_GNU_SOURCE \
-D_FILE_OFFSET_BITS=64 \
-DTHREADS \
-DSCSI
and then:
$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/$(DT_SUBDIR) -f Makefile.linux \
$(TARGET_CONFIGURE_OPTS) CFLAGS="$(TARGET_CFLAGS) $(DT_CFLAGS)" \
OS=linux
What do you think ?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-01-26 20:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 20:40 [Buildroot] [PATCH] dt: new package gustavo.zacarias at free-electrons.com
2016-01-26 20:58 ` Thomas Petazzoni [this message]
2016-01-26 23:22 ` Gustavo Zacarias
2016-01-27 8:24 ` Thomas Petazzoni
2016-01-26 20:42 gustavo.zacarias at free-electrons.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126215833.1afdb8dc@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.