All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Olof Johansson <olof@lixom.net>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Aaro Koskinen <aaro.koskinen@nokia.com>,
	"David S. Miller" <davem@davemloft.net>,
	Network Development <netdev@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [BISECTED] v4.5-rc1 phylib regression
Date: Tue, 26 Jan 2016 23:09:24 +0100	[thread overview]
Message-ID: <20160126220924.GK27473@lunn.ch> (raw)
In-Reply-To: <CAOesGMiEzhN9sGBTq57xnti_Fy1J4rO=djehNHwj47ZhetymXw@mail.gmail.com>

> > Nope, not an option. Only a small number of DTB actually use c22 or
> > c45. The majority of devices have no compatible at all. Why should
> > they, the binding documentation says it is optional!
> 
> So one thing that can be done is to just have a whitelist in the
> driver that we add the known phy compatibles to, with a nice comment
> above that this should only be for legacy device trees.

So you mean drivers/of/of_mdio.c:of_mdiobus_child_is_phy()
has a white list like:

"brcm,40nm-ephy"
"marvell,88E1111", 
"marvell,88e1116",
"marvell,88e1118",
"marvell,88e1149r",
"marvell,88e1310",
"marvell,88E1510",
"marvell,88E1514",
"moxa,moxart-rtl8201cp",

Yes, that would work.

We should also update the binding documentation to limit what is legal
in the compatible string.

   Andrew

  reply	other threads:[~2016-01-26 22:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25 15:45 [BISECTED] v4.5-rc1 phylib regression Aaro Koskinen
2016-01-25 16:38 ` Andrew Lunn
2016-01-25 21:31 ` Andrew Lunn
2016-01-26  4:46 ` Andrew Lunn
2016-01-26 12:14   ` Aaro Koskinen
2016-01-26 13:34     ` Andrew Lunn
2016-01-26 17:23       ` Olof Johansson
2016-01-26 17:53         ` Andrew Lunn
2016-01-26 18:08           ` Olof Johansson
2016-01-26 18:14             ` Olof Johansson
     [not found]               ` <CAOesGMi+ymn_FdDfgTjwgyO-MsEJNGBDU9ayRJvGkjJ7T_ExfA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-26 20:46                 ` Florian Fainelli
     [not found]                   ` <56A7DB27.6080203-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-26 21:36                     ` Andrew Lunn
2016-01-26 21:48                       ` Olof Johansson
2016-01-26 22:09                         ` Andrew Lunn [this message]
2016-01-26 23:54                           ` Florian Fainelli
     [not found]                             ` <56A80725.1070808-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-27  0:15                               ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160126220924.GK27473@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=aaro.koskinen@nokia.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.