* [mtd-utils PATCH] Makefile: install: don't look for scripts in BUILDDIR
@ 2016-01-26 21:36 Brian Norris
2016-01-27 0:42 ` Dongsheng Yang
0 siblings, 1 reply; 3+ messages in thread
From: Brian Norris @ 2016-01-26 21:36 UTC (permalink / raw)
To: linux-mtd; +Cc: Brian Norris, Dongsheng Yang
Our ${SCRIPTS} (e.g., flash_eraseall) are not found in the build
directory; they should be found in their original location.
This fixes a typo in the Makefile refactoring, which caused 'make
install' to fail with messages like:
make: *** No rule to make target '[...my source-build directory...]/armv7a-cros-linux-gnueabi/misc-utils/flash_eraseall'. Stop.
because the install target is looking in the wrong place for
flash_eraseall.
Fixes: 7d81790ced34 ("mtd-utils: Restructure the mtd-utils source.")
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index bd9504ae72f0..977c9c5056ed 100644
--- a/Makefile
+++ b/Makefile
@@ -67,7 +67,7 @@ endif
rm -f $(BUILDDIR)/include/version.h
$(MAKE) -C $(TESTS) clean
-install:: $(addprefix $(BUILDDIR)/,${BINS} ${SCRIPTS})
+install:: $(addprefix $(BUILDDIR)/,${BINS}) ${SCRIPTS}
mkdir -p ${DESTDIR}/${SBINDIR}
install -m 0755 $^ ${DESTDIR}/${SBINDIR}/
mkdir -p ${DESTDIR}/${MANDIR}/man1
--
2.7.0.rc3.207.g0ac5344
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [mtd-utils PATCH] Makefile: install: don't look for scripts in BUILDDIR
2016-01-26 21:36 [mtd-utils PATCH] Makefile: install: don't look for scripts in BUILDDIR Brian Norris
@ 2016-01-27 0:42 ` Dongsheng Yang
2016-01-27 1:06 ` Brian Norris
0 siblings, 1 reply; 3+ messages in thread
From: Dongsheng Yang @ 2016-01-27 0:42 UTC (permalink / raw)
To: Brian Norris, linux-mtd
On 01/27/2016 05:36 AM, Brian Norris wrote:
> Our ${SCRIPTS} (e.g., flash_eraseall) are not found in the build
> directory; they should be found in their original location.
>
> This fixes a typo in the Makefile refactoring, which caused 'make
> install' to fail with messages like:
Ooooops, yes, it's my typo. Sorry for that.
Reviewed-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
Thanx
Yang
>
> make: *** No rule to make target '[...my source-build directory...]/armv7a-cros-linux-gnueabi/misc-utils/flash_eraseall'. Stop.
>
> because the install target is looking in the wrong place for
> flash_eraseall.
>
> Fixes: 7d81790ced34 ("mtd-utils: Restructure the mtd-utils source.")
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index bd9504ae72f0..977c9c5056ed 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -67,7 +67,7 @@ endif
> rm -f $(BUILDDIR)/include/version.h
> $(MAKE) -C $(TESTS) clean
>
> -install:: $(addprefix $(BUILDDIR)/,${BINS} ${SCRIPTS})
> +install:: $(addprefix $(BUILDDIR)/,${BINS}) ${SCRIPTS}
> mkdir -p ${DESTDIR}/${SBINDIR}
> install -m 0755 $^ ${DESTDIR}/${SBINDIR}/
> mkdir -p ${DESTDIR}/${MANDIR}/man1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [mtd-utils PATCH] Makefile: install: don't look for scripts in BUILDDIR
2016-01-27 0:42 ` Dongsheng Yang
@ 2016-01-27 1:06 ` Brian Norris
0 siblings, 0 replies; 3+ messages in thread
From: Brian Norris @ 2016-01-27 1:06 UTC (permalink / raw)
To: Dongsheng Yang; +Cc: linux-mtd
On Wed, Jan 27, 2016 at 08:42:38AM +0800, Dongsheng Yang wrote:
> Reviewed-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
Thanks! Applied to mtd-utils.git
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-27 1:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-26 21:36 [mtd-utils PATCH] Makefile: install: don't look for scripts in BUILDDIR Brian Norris
2016-01-27 0:42 ` Dongsheng Yang
2016-01-27 1:06 ` Brian Norris
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.