From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753071AbcA0BWf (ORCPT ); Tue, 26 Jan 2016 20:22:35 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:34831 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751529AbcA0BWc (ORCPT ); Tue, 26 Jan 2016 20:22:32 -0500 X-AuditID: cbfee68d-f79646d000001355-04-56a81bd71a53 Date: Wed, 27 Jan 2016 10:22:30 +0900 From: Andi Shyti To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Krzysztof Kozlowski , Laxman Dewangan , linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn() Message-id: <20160127012230.GE14296@samsunx.samsung> References: <1453836020-29579-1-git-send-email-javier@osg.samsung.com> <1453836020-29579-8-git-send-email-javier@osg.samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <1453836020-29579-8-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGIsWRmVeSWpSXmKPExsWyRsSkSPe69Iowg1WvOSw6ri1msrj+5Tmr xZu3a5gsXr8wtOh//JrZYum+1SwWl3fNYbOYcX4fk8X+zg5GB06PJ5suMnrsmXiSzWPTqk42 j97md2weW/rvsnv0bVnF6PF5k1wAexSXTUpqTmZZapG+XQJXRuP1hSwF11kqLu05ydbAeJi5 i5GTQ0LAROLB9umsELaYxIV769m6GLk4hARWMEqsb3/OBlO0+vdSqMQsRolfE5sZIZyPjBK9 Z68xdTFycLAIqEpMOuQH0sAmoCnRdPsHWLOIgKnEr7UvWEHqmQX2Mkk0vrrDApIQFgiQWPfh NCOIzQu0oXf6X6gNzYwSJ/6uY4ZICEr8mHwPrIFZQEti/c7jTBC2tMSjvzPYQRZzCrhLPN8u DGKKCqhIvDpYDzJGQuAtu8SKfxPBjmAREJD4NvkQC0iNhICsxKYDUN9LShxccYNlAqPYLCTL ZiFZNgvJsgWMzKsYRVMLkguKk9KLDPWKE3OLS/PS9ZLzczcxAqPz9L9nvTsYbx+wPsQowMGo xMN7Y//yMCHWxLLiytxDjKZAV0xklhJNzgemgLySeENjMyMLUxNTYyNzSzMlcV5FqZ/BQgLp iSWp2ampBalF8UWlOanFhxiZODilGhhTn70Mrf82Z3W/z4fMS9cuLFwnmNxY6+5w8vuh34el ygI+dT06LRDrvfAYT5i/03fv2xOXirisq4xT9jllxXhzVWfJAxbxnWc1r9oKm7foh8m7XGN9 uWS6yZcNAhYbr+6fY22n94XJilWq8ufh1x/C9nTtuhHdFCb3IbicZ8/TXYuOzPrLEnBbiaU4 I9FQi7moOBEAhaJ5OckCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42I5/e+xoO516RVhBkfvMlt0XFvMZHH9y3NW izdv1zBZvH5haNH/+DWzxdJ9q1ksLu+aw2Yx4/w+Jov9nR2MDpweTzZdZPTYM/Ekm8emVZ1s Hr3N79g8tvTfZffo27KK0ePzJrkA9qgGRpuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11D SwtzJYW8xNxUWyUXnwBdt8wcoNOUFMoSc0qBQgGJxcVK+naYJoSGuOlawDRG6PqGBMH1GBmg gYQ1jBmN1xeyFFxnqbi05yRbA+Nh5i5GTg4JAROJ1b+XskHYYhIX7q0Hsrk4hARmMUr8mtjM COF8ZJToPXuNqYuRg4NFQFVi0iE/kAY2AU2Jpts/wJpFBEwlfq19wQpSzyywl0mi8dUdFpCE sECAxLoPpxlBbF6gbb3T/0JtaGaUOPF3HTNEQlDix+R7YA3MAloS63ceZ4KwpSUe/Z3BDrKY U8Bd4vl2YRBTVEBF4tXB+gmMQFciNM9C0jwLSfMCRuZVjBKpBckFxUnpuUZ5qeV6xYm5xaV5 6XrJ+bmbGMEJ4Jn0DsbDu9wPMQpwMCrx8N7YvzxMiDWxrLgy9xCjBAezkghvMsOKMCHelMTK qtSi/Pii0pzU4kOMpsDwmMgsJZqcD0xOeSXxhsYmZkaWRuaGFkbG5krivPsuRYYJCaQnlqRm p6YWpBbB9DFxcEo1MJq+UtotecBLr0fCWvVxqah2a7iDH39Gg5/c0s3SUxMtM2dWyP7uCZ2o NFdt/u0DKQmtzz80rWSa8P54ydOqvkucH7ZqqHo5fLPQXuj9wfc757WDfMvVIw+/WeIXo8Gi 5F36RkbSuSXt7P2aloQXXOvWfa/6rD5JniuiuHO9A1v6kSrziRYflFiKMxINtZiLihMBfUXC DRYDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javier, > if (tm->tm_year < 100) { > - pr_warn("RTC can't handle year %d. Assume it's 2000.\n", > - 1900 + tm->tm_year); > + dev_warn(info->dev, > + "RTC can't handle year %d. Assume it's 2000\n", > + 1900 + tm->tm_year); > return -EINVAL; Because we are returning an error value, why not use dev_err()? > } > } else { > -- > 2.5.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTPS id u66si35611pfa.2.2016.01.26.17.22.32 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 26 Jan 2016 17:22:32 -0800 (PST) Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O1L014KU7TJES70@mailout1.samsung.com> for rtc-linux@googlegroups.com; Wed, 27 Jan 2016 10:22:31 +0900 (KST) Date: Wed, 27 Jan 2016 10:22:30 +0900 From: Andi Shyti To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Krzysztof Kozlowski , Laxman Dewangan , linux-samsung-soc@vger.kernel.org Subject: [rtc-linux] Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn() Message-id: <20160127012230.GE14296@samsunx.samsung> References: <1453836020-29579-1-git-send-email-javier@osg.samsung.com> <1453836020-29579-8-git-send-email-javier@osg.samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 In-reply-to: <1453836020-29579-8-git-send-email-javier@osg.samsung.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hi Javier, > if (tm->tm_year < 100) { > - pr_warn("RTC can't handle year %d. Assume it's 2000.\n", > - 1900 + tm->tm_year); > + dev_warn(info->dev, > + "RTC can't handle year %d. Assume it's 2000\n", > + 1900 + tm->tm_year); > return -EINVAL; Because we are returning an error value, why not use dev_err()? > } > } else { > -- > 2.5.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.