From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752994AbcA0DVA (ORCPT ); Tue, 26 Jan 2016 22:21:00 -0500 Received: from mga11.intel.com ([192.55.52.93]:61697 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751311AbcA0DU6 (ORCPT ); Tue, 26 Jan 2016 22:20:58 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,353,1449561600"; d="scan'208";a="36813907" Date: Tue, 26 Jan 2016 22:20:55 -0500 From: Matthew Wilcox To: Andrew Morton Cc: Matthew Wilcox , Johannes Weiner , "Kirill A. Shutemov" , Ross Zwisler , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/8] radix tree test harness Message-ID: <20160127032055.GN2948@linux.intel.com> References: <1453213533-6040-1-git-send-email-matthew.r.wilcox@intel.com> <1453213533-6040-3-git-send-email-matthew.r.wilcox@intel.com> <20160126154438.c07554d49c14b57005b64319@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160126154438.c07554d49c14b57005b64319@linux-foundation.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2016 at 03:44:38PM -0800, Andrew Morton wrote: > > diff --git a/tools/testing/radix-tree/linux/radix-tree.h b/tools/testing/radix-tree/linux/radix-tree.h > > new file mode 120000 > > index 0000000..1e6f41f > > --- /dev/null > > +++ b/tools/testing/radix-tree/linux/radix-tree.h > > @@ -0,0 +1 @@ > > +../../../../include/linux/radix-tree.h > > \ No newline at end of file > > glumpf. My tools have always had trouble with symlinks - patch(1) > seems to handle them OK but diff(1) screws things up. I've had one go > at using git to replace patch/diff but it was a fail. > > Am presently too lazy to have attempt #2 so I think I'll just do > > --- /dev/null > +++ a/tools/testing/radix-tree/linux/radix-tree.h > @@ -0,0 +1 @@ > +#include "../../../../include/linux/radix-tree.h" Fine by me; I wasn't sure whether to do it as an include or a symlink. I could have gone either way. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 26 Jan 2016 22:20:55 -0500 From: Matthew Wilcox To: Andrew Morton Cc: Matthew Wilcox , Johannes Weiner , "Kirill A. Shutemov" , Ross Zwisler , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/8] radix tree test harness Message-ID: <20160127032055.GN2948@linux.intel.com> References: <1453213533-6040-1-git-send-email-matthew.r.wilcox@intel.com> <1453213533-6040-3-git-send-email-matthew.r.wilcox@intel.com> <20160126154438.c07554d49c14b57005b64319@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160126154438.c07554d49c14b57005b64319@linux-foundation.org> Sender: owner-linux-mm@kvack.org List-ID: On Tue, Jan 26, 2016 at 03:44:38PM -0800, Andrew Morton wrote: > > diff --git a/tools/testing/radix-tree/linux/radix-tree.h b/tools/testing/radix-tree/linux/radix-tree.h > > new file mode 120000 > > index 0000000..1e6f41f > > --- /dev/null > > +++ b/tools/testing/radix-tree/linux/radix-tree.h > > @@ -0,0 +1 @@ > > +../../../../include/linux/radix-tree.h > > \ No newline at end of file > > glumpf. My tools have always had trouble with symlinks - patch(1) > seems to handle them OK but diff(1) screws things up. I've had one go > at using git to replace patch/diff but it was a fail. > > Am presently too lazy to have attempt #2 so I think I'll just do > > --- /dev/null > +++ a/tools/testing/radix-tree/linux/radix-tree.h > @@ -0,0 +1 @@ > +#include "../../../../include/linux/radix-tree.h" Fine by me; I wasn't sure whether to do it as an include or a symlink. I could have gone either way. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org